From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01EA0C4727C for ; Thu, 1 Oct 2020 08:03:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC1CB20872 for ; Thu, 1 Oct 2020 08:03:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V5dI8k0J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726992AbgJAIDW (ORCPT ); Thu, 1 Oct 2020 04:03:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725883AbgJAIDW (ORCPT ); Thu, 1 Oct 2020 04:03:22 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 904ACC0613D0 for ; Thu, 1 Oct 2020 01:03:21 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id u4so3822383ljd.10 for ; Thu, 01 Oct 2020 01:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YYHHGDFcyV7m8A+kwt4Um8hblS35Zy5LrCr00HSCg5U=; b=V5dI8k0JGBDJKaUjGkZd5nb7FzKkNjAUGj5Vtz/vwaOkdbsk6Kfj/tmoI9iIZ1EsBr aD0K4VFAX8MLbgmH7OLqizXrI8d3P4p+YYeQZX3ae2tdMsL1Vm5bLjDfOYlcP1JcitaB Dl0EfsIi5mkBQ4A22FPU8fDnsa9ugjECw+1FE9iQlMUmqxgurQjB+a0knVgjE0yqtyk4 DtH3WcgwZWwr1QzCBGkMPKAr0RQNrx9OfD+0fOPZwF9SgVqdm8ro/mLu0kaP2NDqbAGu 1A4zBRIRD6OGp0vlQhTbU5MktfsOzI6rM7rsHzYQnx2GMb3f/R3DeS9Kzc4QPyShlVzI 3zUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YYHHGDFcyV7m8A+kwt4Um8hblS35Zy5LrCr00HSCg5U=; b=DOom66LFa2smBaM0/zZBHuSBrLrq+oa/UDHlqzdC6iKGAeTEW9FQ+Qm9IO8U/69WoP D3Y2KwJCYQjHR59MGJ9DW3h2m5q7jBI0znliULn/boZVTr4YEidfVHAtJt3xx+QdpFSz ssdfV9qItDHO/h2CvDCrVPIyq/z4VGy8fD0xhMjNSCPcxEDMOIzFzIZ1qbVr4TWnf/LE Ft+B3zLLEGANF+nG6GrrMNLjMwvZDqtrReyL+4+AAcyobGTxxNRMvZqvZUrkf6BHexFr uuVU+roJg8Z5wQg4wUoGRxKko5QvgM1h36LwImvOJGhbox+l7WfXo5xneooZNK+ilH4o 7JLA== X-Gm-Message-State: AOAM53275Gda5vJ9YWK258pgcI6s7+6y6qWA9zKZDJfF1ygU6bMIKiY7 m6LOjjEcDbNQB/X9OBtryBlD/rpb/3/NYd2jbf4jcg== X-Google-Smtp-Source: ABdhPJxObbJWEMCPewD8z+AbY9e15OBPYDfPTz8C51qe9fXmpPzD4vXP4mXTehFmCobLoRIHlfHzT37WBOKXg2KqIaY= X-Received: by 2002:a2e:9b15:: with SMTP id u21mr2102611lji.283.1601539399825; Thu, 01 Oct 2020 01:03:19 -0700 (PDT) MIME-Version: 1.0 References: <20200930174839.1308344-1-drew@beagleboard.org> In-Reply-To: <20200930174839.1308344-1-drew@beagleboard.org> From: Linus Walleij Date: Thu, 1 Oct 2020 10:03:08 +0200 Message-ID: Subject: Re: [PATCH v2] pinctrl: single: fix pinctrl_spec.args_count bounds check To: Drew Fustini Cc: Tony Lindgren , Rob Herring , Jason Kridner , Robert Nelson , Trent Piepho , Christina Quast , Linux-OMAP , "linux-kernel@vger.kernel.org" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Wed, Sep 30, 2020 at 7:51 PM Drew Fustini wrote: > The property #pinctrl-cells can either be 1 or 2: > > - if #pinctrl-cells = <1>, then pinctrl_spec.args_count = 2 > - if #pinctrl-cells = <2>, then pinctrl_spec.args_count = 3 > > All other values of pinctrl_spec.args_count are incorrect. This fix > checks the upper bound instead of just the lower bound. > > Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2") > Reported-by: Trent Piepho > Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/ > Signed-off-by: Drew Fustini > --- > v2 change: > - correct the description as I had previously been mistakenly using the > term #pinctrl-cells instead of pinctrl_spec.args_count Patch applied! Yours, Linus Walleij