From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C10ECC433E0 for ; Tue, 9 Mar 2021 13:41:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EE2465243 for ; Tue, 9 Mar 2021 13:41:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231139AbhCINlT (ORCPT ); Tue, 9 Mar 2021 08:41:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231308AbhCINk5 (ORCPT ); Tue, 9 Mar 2021 08:40:57 -0500 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE68EC06175F for ; Tue, 9 Mar 2021 05:40:56 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id r25so20623306ljk.11 for ; Tue, 09 Mar 2021 05:40:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M2PVFTJad13/HHdNzwN8/vmlKlKOh1dKDhYFEC+sxbs=; b=oCa2SWgwfdjgNjhmNjTTUyxncE1srgWbgq4n1tk+YicLak1fz2d0Ocha/HJoao7WS4 ijbw64tDUrTAHzwHknKJW5AWPQKLFKb9IYDL4Qsofhy5Zym6TQryG8BBvl1YlDiaM1Wx PzK6QjxGbq6GglgWkaZRgJwFDjNDCYoFLs7xqyx5sZav6TvYbzLRsIbSF6k5iYuOBTmk MuGvUGklfu2vmHSLGHJKvH0szrB7f5LB0aK8Bd9d4LWpxQXqhcHjW0+clsfA6zcFiXPZ QJEOtQF+8u7WccHrdPD389iZjrOIP+sR/aSMvqPTn8OA/LFDOkOn1URA6ZDzGTykGwjc d1Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M2PVFTJad13/HHdNzwN8/vmlKlKOh1dKDhYFEC+sxbs=; b=sCXmhUFjqhd/ob7WHSEvE24xqGaSDf53FiYe04yNCN4b/UsyLJMfGTauNhfwgpSulS 83ImZ6yTBgIk1dThKBB3jRd2X3g1eb6GIr6ixZgxJo6SSWsouk+kWhy5jp7Dd1n0hZZY 9grwrPN3CXVcMnaDaZL+OC0fxtKcG+fVyjsDDRSI2aE4sxEOT6KxTwA7zJnxc34E3/Ul +XvVry6lze5wAObENbBvqbU0NLM6lv5iYUehnQjDb0fweJhymuRTVelX23oBE+3+wfp5 N0Gkd2HpVc+htCsjvknbtQZr/mgP/Dk8lK4vQpCJqUt8x/PmnMsT1ZmdyToSablqfAA/ as2g== X-Gm-Message-State: AOAM533xsOkvopqabXitDCc9MsDIXFKs/flgNUPRws5uiZlWgPr/p5P5 PJaRsoakn/RNRWQDq42kEkFLWeToIIe5oggwYF/EeA== X-Google-Smtp-Source: ABdhPJybzyO6ZNZPaRk+OvWdcYfIHCWIpj+B9KZrup6oxp1HHl3PlLebHYEChGoROoICQaGOC6ZyrFwRYceCJuRDs0w= X-Received: by 2002:a05:651c:103a:: with SMTP id w26mr14436853ljm.273.1615297255364; Tue, 09 Mar 2021 05:40:55 -0800 (PST) MIME-Version: 1.0 References: <20210302011813.2331879-1-alexander.sverdlin@gmail.com> <20210308183704.GA2747088@robh.at.kernel.org> In-Reply-To: <20210308183704.GA2747088@robh.at.kernel.org> From: Linus Walleij Date: Tue, 9 Mar 2021 14:40:44 +0100 Message-ID: Subject: Re: [PATCH] gpio: omap: Honor "aliases" node To: Rob Herring , "open list:GPIO SUBSYSTEM" Cc: Alexander Sverdlin , Linux-OMAP , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Bartosz Golaszewski , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Mon, Mar 8, 2021 at 7:37 PM Rob Herring wrote: > Can we remove the ones we have already for GPIO? I think we would get pretty hard pushback if we attempt that. We have all these drivers that utilize it: gpio-clps711x.c: id = of_alias_get_id(np, "gpio"); gpio-mvebu.c: id = of_alias_get_id(pdev->dev.of_node, "gpio"); gpio-mxc.c: port->gc.base = (pdev->id < 0) ? of_alias_get_id(np, "gpio") * 32 : gpio-mxs.c: port->id = of_alias_get_id(np, "gpio"); gpio-vf610.c: gc->base = of_alias_get_id(np, "gpio") * VF610_GPIO_PER_PORT; gpio-zynq.c: chip->base = of_alias_get_id(pdev->dev.of_node, "gpio"); pinctrl-at91.c: int alias_idx = of_alias_get_id(np, "gpio"); pinctrl-st.c: int bank_num = of_alias_get_id(np, "gpio"); samsung/pinctrl-samsung.c: id = of_alias_get_id(node, "pinctrl"); Predictably it is so many bad examples that new driver authors will claim something along the line of "why can't I have a lollipop when all other kids got one". Several of those have this by a claim one way or another that the DT boot need to look like the boardfile boot. Some of these have been migrated from board files so could possible drop this id/base coding. I don't know what the maintainers would say, should we send attack patches? :D At least some kind of motivation would come out of it. Yours, Linus Walleij