From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FF2AC433E0 for ; Thu, 28 Jan 2021 12:03:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 439F564DDE for ; Thu, 28 Jan 2021 12:03:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231496AbhA1MCx (ORCPT ); Thu, 28 Jan 2021 07:02:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231564AbhA1MBx (ORCPT ); Thu, 28 Jan 2021 07:01:53 -0500 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B410AC0613D6 for ; Thu, 28 Jan 2021 04:01:12 -0800 (PST) Received: by mail-lj1-x235.google.com with SMTP id l12so5990282ljc.3 for ; Thu, 28 Jan 2021 04:01:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n9EOKkeTY2+d1Fa4iHB/4cHa37Z0fzFo4OzOK4oM6Q4=; b=F/CmSMOuSr5zNpyIz8oDpfs0uxO2NhcU5b2INzxjrItESHLsnvvNX/yf1410eKA9ve VQpoXLUK241FEkj9ofwBDSWNFjyOlJ1/B0w503sD1RjI/Sv8Mpy9AuKTl4v9unPAbVpt o2NhCHR1kO8BzF2uLKVtJlY/eb6hmEA6dxkoKIZIDA//svyJxEpWliH0+/KoPRpX6yuQ xOaOhiqgJROQ4qzL4Ai4Vu8QEK7vHTmjcR+D0QSzio07rhzy0JmaMHDNZNHoYvUzzBdq PIk0qSMqBACkwRrT1oeqoueNhsZKSRQyiROFe5pXaQq2lZ0IVc3HI0/lPCj4ym1EPKe0 BuLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n9EOKkeTY2+d1Fa4iHB/4cHa37Z0fzFo4OzOK4oM6Q4=; b=aHOGphor1SiPauM9DszKqnKx+GhQB192f936UPMIAuM6WSStowhPKrj1s6m3er/0O+ cXrPs8D0HwLRGCMmxk18YuXnnZMKiQpmyBIbfPNVSQ8GdweUNzQzMDIWBmLlr37u3sVb Ba29AFMuCUjlN2OShGp2bXaS7YOH/TGuOYKKaNFCwB4oXDSdBcaDPp2jZ9AFktcD/+2o 9dzAv8uCyxxe3i7o5adbqOz1qsep3vSKVz/K/WDt5/PX1OybMMchNvgtFAyXFbrQfmuK W/ALDBGd7WXGF9JV/xciZEi+oftY9MIa+nIo3oRkv4GBQ6GIXSQsmdBGVa+6ifFz7ELS kV4g== X-Gm-Message-State: AOAM533/P3Q1pB4GkU+aMzrzztvtxylraLoporKR1cnhwWFF94Nv1cny +C92enWd4yRHF3R5xizCdWfzRMcQjwi03u3uTpbPZw== X-Google-Smtp-Source: ABdhPJypbRkZO7oNmfkvuCEOFNhZkoDt3uSClsJKrU2bBbdo1JdlUWBieGzbeMl4eG6ef0bI+oE4Ri5xIQqzgGc6PuE= X-Received: by 2002:a2e:8ec3:: with SMTP id e3mr7938969ljl.467.1611835271030; Thu, 28 Jan 2021 04:01:11 -0800 (PST) MIME-Version: 1.0 References: <20210127000303.436595-1-drew@beagleboard.org> In-Reply-To: <20210127000303.436595-1-drew@beagleboard.org> From: Linus Walleij Date: Thu, 28 Jan 2021 13:01:00 +0100 Message-ID: Subject: Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names To: Drew Fustini Cc: =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Rob Herring , Linux-OMAP , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Jason Kridner , Robert Nelson , Bjorn Andersson , Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Wed, Jan 27, 2021 at 1:04 AM Drew Fustini wrote: > Based on linux-gpio discussion [1], it is best practice to make the > gpio-line-names unique. Generic names like "[ethernet]" are replaced > with the name of the unique signal on the AM3358 SoC ball corresponding > to the gpio line. "[NC]" is also renamed to the standard "NC" name to > represent "not connected". > > [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/ > > Signed-off-by: Drew Fustini This certainly looks better! Reviewed-by: Linus Walleij Yours, Linus Walleij