From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 209EFC433B4 for ; Fri, 21 May 2021 10:04:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 003AC6109F for ; Fri, 21 May 2021 10:04:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232208AbhEUKFw (ORCPT ); Fri, 21 May 2021 06:05:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230257AbhEUKFs (ORCPT ); Fri, 21 May 2021 06:05:48 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8791C06138A for ; Fri, 21 May 2021 03:04:25 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id o8so23334164ljp.0 for ; Fri, 21 May 2021 03:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y703Ccx+OTVaWUBCSYH8WB2pCfwJTEkBdShX5aoEd5U=; b=FK4Uxegv3dlbXSHmfZkIILoMjTrkUnCadXvOCTXwz61zBEqo8XuxaRLI477qridtDX KWRqC0Xsyy0RaSBAfI6HDwck/LKYxEk94TEDa96tzAY98IC0ure6vHgQGuXZUV/0XYOe 1byrlbnUhRcixOf3T1VQq+B04CvZyvvz6tG+DBF4g3Sok9dofTiV0jMkvyyiZSqCs/z6 e7lV7gcjVa3MfE9TgNzQj7WnkfmpOF2UlkJ7vIpEVMrPfud5DKKbcPSZFcXpqMZFIllr T6sTGSQtx5RTFo2r9r6qO8uQ33iyoHjb2iat48Ts9zBk5bMolvT4PaaI7DjVSkCgjqVf +7ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y703Ccx+OTVaWUBCSYH8WB2pCfwJTEkBdShX5aoEd5U=; b=jVmHA4nlbIxJjeYXNr8ObfIapuVo7hA8zDEw2Fzuy7zW9HQd59OSFMMfNdsgawlS8X vA7JD38e+xkB+3CfYRuCVZs3jdzv2kmM8DPcWeUdkwsfQon2vIWot6AfgSJ9gm5h/TNd 8lzxT5pJLL5wtPl/ZYmV2U113Uo9Xtnxhxiu6ReObXyTcnOOPR+x6bQHK/NLlMNyf27W 3XYyQnOAHSwP6F/RQKthANH7yXaZ/X4trNeQihR6SN85ldzfFB8VodXN3GO5b72endoA wIjaZGZSLEvJHvpt8Dw/jaQgVW7fDL66lElmg60ZApRqAyInpgTNWinybYfXKQ779HAJ C6MA== X-Gm-Message-State: AOAM5334ZIMi7s97eF2TjhJ4V/NhwW1T+Fh4Zot4aoTp3JxFkgBLn0JL k+GdhbUKrlPlKyS9/pWYMSmU3T97FPXYCEzur5ta0A== X-Google-Smtp-Source: ABdhPJxYYlDb+WDA9clSQo27j62lQA1sN33Wn6ony6XmM/ZkiSizwZPVoBxp6VVDs3T+PGjG3ATJK87UTncv58xBVOI= X-Received: by 2002:a05:651c:4c6:: with SMTP id e6mr6517419lji.326.1621591464170; Fri, 21 May 2021 03:04:24 -0700 (PDT) MIME-Version: 1.0 References: <52df0592c81ac000d3f486a9ba5a4d84b0f42c47.1621583562.git.geert+renesas@glider.be> In-Reply-To: <52df0592c81ac000d3f486a9ba5a4d84b0f42c47.1621583562.git.geert+renesas@glider.be> From: Linus Walleij Date: Fri, 21 May 2021 12:04:12 +0200 Message-ID: Subject: Re: [PATCH 3/3] dt-bindings: gpio: pcf857x: Convert to json-schema To: Geert Uytterhoeven Cc: Rob Herring , Laurent Pinchart , Bartosz Golaszewski , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Jan Tuerk , Shawn Guo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:GPIO SUBSYSTEM" , Linux-OMAP , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Fri, May 21, 2021 at 9:54 AM Geert Uytterhoeven wrote: > Convert the PCF857x-compatible I/O expanders Device Tree binding > documentation to json-schema. > > Document missing compatible values, properties, and gpio hogs. > > Signed-off-by: Geert Uytterhoeven (...) > Perhaps the "ti,pcf8575" construct should be removed, and the few users > fixed instead? You would rather list it as deprecated I think? It is ABI... > + gpio-controller: true So this is implicitly using the generic schema in /dtschema/schemas/gpio/gpio.yaml > + lines-initial-states: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Bitmask that specifies the initial state of each line. > + When a bit is set to zero, the corresponding line will be initialized to > + the input (pulled-up) state. > + When the bit is set to one, the line will be initialized to the > + low-level output state. > + If the property is not specified all lines will be initialized to the > + input state. Is this something we standardized or something that should actually be a custom "nxp," property we just missed it? (Looks like the latter... oh well, now it is there.) > +patternProperties: > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": > + type: object But this is already in /dtschema/schemas/gpio/gpio-hog.yaml for nodename, isn't that where it properly belongs? I'm however confused here Rob will know what to do. > required: > - gpio-hog > - gpios This is already in /dtschema/schemas/gpio/gpio-hog.yaml as well? Yours, Linus Walleij