From: Drew Fustini <pdp7pdp7@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Drew Fustini <drew@beagleboard.org>,
Jason Kridner <jkridner@beagleboard.org>,
Robert Nelson <robertcnelson@beagleboard.org>,
Tony Lindgren <tony@atomide.com>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
linux-omap@vger.kernel.org
Subject: Re: gpio-omap: add support gpiolib bias (pull-up/down) flags?
Date: Fri, 13 Mar 2020 03:39:13 +0300 [thread overview]
Message-ID: <CAEf4M_B_sxOiKFnEVUrx00RE2MaMA98LpijNhp0EVY11eRAXHg@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdaPoMGZ7jGh6j4dYexx+qCcoMQ37vS7kbpf=3TtcA9zQQ@mail.gmail.com>
On Thu, Mar 12, 2020 at 1:43 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> Do we have a datasheet for this GPIO block somewhere? Should
> be the datasheet for the ASIC.
I am looking at the AM335x reference manual [0] but I can not actually
find any references to pull-up/down or bias for GPIO pins. I guess I
was making of the mistake of assuming this would be something the gpio
pins support.
> We already have the required .set_config() callback on the OMAP
> driver, it's just that it only uses it for debounce.
>
> The driver is a bit convoluted with register offsets in a struct
> omap_gpio_reg_offs depending on variant, but if they have
> a register for this I'd say just get hacking.
>
> If the GPIO driver is using pin control as back-end you are
> looking at something more complex similar to what Intel is
> doing inside drivers/pinctrl/intel/pinctrl-intel.c: this driver
> is just calling up to gpiochip_generic_config() which will
> try to configure the lines behind the GPIO using pin config,
> which works if the proper ranges are defined so the
> framework can map a GPIO line to a pin control pin.
Thank you for the feedback, Linus.
Upon further review of drivers/pinctrl/pinctrl-single.c, I am not
certain it actually supports pull-up/down.
I see there is pcs_pinconf_clear_bias() and pcs_pinconf_bias_disable()
but I don't see a place where the PIN_CONFIG_BIAS_PULL_DOWN or
PIN_CONFIG_BIAS_PULL_UP get set.
I'll have to look at that some more before I go back to thinking about
how to integrate into gpio-omap.
Thanks,
Drew
[0] http://www.ti.com/lit/ug/spruh73q/spruh73q.pdf
next parent reply other threads:[~2020-03-13 0:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAEf4M_Du6Egn-3nZHtSnMMwohc+-DyEdtWU5DqSJi71+nDthFw@mail.gmail.com>
[not found] ` <CACRpkdaPoMGZ7jGh6j4dYexx+qCcoMQ37vS7kbpf=3TtcA9zQQ@mail.gmail.com>
2020-03-13 0:39 ` Drew Fustini [this message]
2020-03-13 5:23 ` gpio-omap: add support gpiolib bias (pull-up/down) flags? Haojian Zhuang
2020-04-13 12:39 ` Drew Fustini
2020-04-15 13:15 ` Grygorii Strashko
2020-04-15 13:20 ` Robert Nelson
2020-04-15 13:47 ` Grygorii Strashko
2020-04-15 13:59 ` Robert Nelson
2020-04-15 23:37 ` Drew Fustini
2020-04-16 12:03 ` Linus Walleij
2020-04-16 16:07 ` Drew Fustini
2020-04-16 14:16 ` Grygorii Strashko
2020-04-17 10:37 ` Linus Walleij
2020-04-16 16:32 ` Tony Lindgren
2020-04-23 13:17 ` Drew Fustini
2020-04-23 16:42 ` Tony Lindgren
2020-04-24 17:32 ` Drew Fustini
2020-04-24 17:49 ` Tony Lindgren
2020-05-25 13:17 ` Drew Fustini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4M_B_sxOiKFnEVUrx00RE2MaMA98LpijNhp0EVY11eRAXHg@mail.gmail.com \
--to=pdp7pdp7@gmail.com \
--cc=drew@beagleboard.org \
--cc=grygorii.strashko@ti.com \
--cc=haojian.zhuang@linaro.org \
--cc=jkridner@beagleboard.org \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@beagleboard.org \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).