From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65F92C4363C for ; Fri, 2 Oct 2020 17:52:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2AD9620795 for ; Fri, 2 Oct 2020 17:52:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Hrn+Czu+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388345AbgJBRwb (ORCPT ); Fri, 2 Oct 2020 13:52:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbgJBRw2 (ORCPT ); Fri, 2 Oct 2020 13:52:28 -0400 Received: from mail-yb1-xb42.google.com (mail-yb1-xb42.google.com [IPv6:2607:f8b0:4864:20::b42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17489C0613E2 for ; Fri, 2 Oct 2020 10:52:28 -0700 (PDT) Received: by mail-yb1-xb42.google.com with SMTP id b142so1748069ybg.9 for ; Fri, 02 Oct 2020 10:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lW22Qzd9PGiP/2qzJ0inuLN63Dw7cetpUVChJaty2gE=; b=Hrn+Czu+Upto30ahHpqz77XC0AVbryq8MDWS/Cg35v6e3+jm93XxMW799+oo0wmJCX mMXHudebFmP8Ys+9w/RQcPL2f7Mnerj3jbyFp39ZwzbpbQE1w9F3wldwtqRqjU7NFCl5 DXY7Fpi9XYkfpBnirOpPnGDsydsDjA/wUrp9tqJoR4VEgWXIW8BnE1IFn0tUNE0dYY3u KBLk/lWz4ZJ9bIQPBTjtRV0ygVvrkbXa9VWbhIV0G+8a0IkdILlriUf7qDpDEIHsrO5g 7lOOgb1hg4imG+RF8Ji9cqGBdhkknr3GVqfkmxdR+nREoCNPAFqg5UdDt8J+8Svgc4V2 kRJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lW22Qzd9PGiP/2qzJ0inuLN63Dw7cetpUVChJaty2gE=; b=q/Jv/zny8wH62z59NigAorYh5KkvtRhEjSv/acWyBKncDZeEESqijunD4+CgxyzLJm Dc74gIVAVfdwpXULS3y+dQiQ+v5wY2oYEIuMDX53nRe65zQ5tun7PiNBxGBv3UK6KYnx RdkEe6rP0d7aKR77ZIdhF/cFwb7fFVS0PxUqGeNIFEriKxImiH1SHNZIULXcAwowwR1D XamkPD2deIKxIwy/+jz11haYdqLv8CJ/rn9LyK6b/j07iVbvtkmysNOCpLcsUNls3tZJ Qq76+2ZvGByGXPD+8NwyygiO/bVsjVzmGuN9ugdbzUw/1qAhCKl1baJydmzgfhpaeara 87OA== X-Gm-Message-State: AOAM531Jrkl/RMGe7BRRY7cjXrQyXaXbYD0Sh/oFtpiZk6aoVAwx0trM OFZ0QMGlSvYqzv3930F4mnt1anUaOPk7B6gMWmTnLQ== X-Google-Smtp-Source: ABdhPJy4XhKvg/fcRsKDUtj8ituzDGpU4LofV1mA+byx9rafxRXok/qNPb40BvV5nKhx2JlN6+fH0sxc/b6LCow6y+k= X-Received: by 2002:a25:8041:: with SMTP id a1mr4363493ybn.412.1601661147077; Fri, 02 Oct 2020 10:52:27 -0700 (PDT) MIME-Version: 1.0 References: <20201001225952.3676755-1-saravanak@google.com> In-Reply-To: From: Saravana Kannan Date: Fri, 2 Oct 2020 10:51:51 -0700 Message-ID: Subject: Re: [PATCH v1] of: platform: Batch fwnode parsing in the init_machine() path To: Rob Herring Cc: Frank Rowand , Geert Uytterhoeven , Greg Kroah-Hartman , Grygorii Strashko , Laurent Pinchart , linux-omap , "open list:THERMAL" , Peter Ujfalusi , "Rafael J. Wysocki" , Tomi Valkeinen , Tony Lindgren , Ulf Hansson , Android Kernel Team , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Fri, Oct 2, 2020 at 7:08 AM Rob Herring wrote: > > On Thu, Oct 1, 2020 at 5:59 PM Saravana Kannan wrote: > > > > When commit 93d2e4322aa7 ("of: platform: Batch fwnode parsing when > > adding all top level devices") optimized the fwnode parsing when all top > > level devices are added, it missed out optimizing this for platform > > where the top level devices are added through the init_machine() path. > > > > This commit does the optimization for all paths by simply moving the > > fw_devlink_pause/resume() inside of_platform_default_populate(). > > > > Reported-by: Tomi Valkeinen > > Signed-off-by: Saravana Kannan > > --- > > drivers/of/platform.c | 19 +++++++++++++++---- > > 1 file changed, 15 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/of/platform.c b/drivers/of/platform.c > > index 071f04da32c8..79972e49b539 100644 > > --- a/drivers/of/platform.c > > +++ b/drivers/of/platform.c > > @@ -501,8 +501,21 @@ int of_platform_default_populate(struct device_node *root, > > const struct of_dev_auxdata *lookup, > > struct device *parent) > > { > > - return of_platform_populate(root, of_default_bus_match_table, lookup, > > - parent); > > + int ret; > > + > > + /* > > + * fw_devlink_pause/resume() are only safe to be called around top > > + * level device addition due to locking constraints. > > + */ > > + if (!root) > > + fw_devlink_pause(); > > + > > + ret = of_platform_populate(root, of_default_bus_match_table, lookup, > > + parent); > > of_platform_default_populate() vs. of_platform_populate() is just a > different match table. I don't think the behavior should otherwise be > different. > > There's also of_platform_probe() which has slightly different matching > behavior. It should not behave differently either with respect to > devlinks. So I'm trying to do this only when the top level devices are added for the first time. of_platform_default_populate() seems to be the most common path. For other cases, I think we just need to call fw_devlink_pause/resume() wherever the top level devices are added for the first time. As I said in the other email, we can't add fw_devlink_pause/resume() by default to of_platform_populate(). Do you have other ideas for achieving "call fw_devlink_pause/resume() only when top level devices are added for the first time"? -Saravana