From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Drew Fustini <drew@beagleboard.org>
Cc: Tony Lindgren <tony@atomide.com>,
Linus Walleij <linus.walleij@linaro.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jason Kridner <jkridner@beagleboard.org>,
Robert Nelson <robertcnelson@gmail.com>
Subject: Re: [PATCH v2] pinctrl: core: print gpio in pins debugfs file
Date: Tue, 21 Jul 2020 09:49:07 +0300 [thread overview]
Message-ID: <CAHp75Vec23BDJt3woKL+SiY0dxPLFADdGaf=RbDuOWCHwtj_iA@mail.gmail.com> (raw)
In-Reply-To: <20200720191740.1974132-1-drew@beagleboard.org>
On Mon, Jul 20, 2020 at 10:18 PM Drew Fustini <drew@beagleboard.org> wrote:
>
> If there is a gpio range mapping for the pin, then print out the gpio
> number for the pin in the debugfs 'pins' file.
>
> Here is an example output on the BeagleBone Black from:
> /sys/kernel/debug/pinctrl/44e10800.pinmux-pinctrl-single/pins
>
> pin 100 (PIN100) gpiochip:gpio-96-127 line-name:P1.36 [PWM0A] 44e10990 00000001 pinctrl-single
> pin 101 (PIN101) gpiochip:gpio-96-127 line-name:P1.33 [PRU0.1] 44e10994 00000027 pinctrl-single
> pin 102 (PIN102) gpiochip:gpio-96-127 line-name:P2.32 [PRU0.2] 44e10998 00000027 pinctrl-single
It becomes unnecessarily long. I would drop these 'gpiochip:' and
'line-name:' prefixes and NA case you rather should have the same
amount of arguments, so here would be something like NA NA or alike.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-07-21 6:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 19:17 [PATCH v2] pinctrl: core: print gpio in pins debugfs file Drew Fustini
2020-07-21 6:49 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-19 13:22 Drew Fustini
2020-07-19 13:28 ` Drew Fustini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vec23BDJt3woKL+SiY0dxPLFADdGaf=RbDuOWCHwtj_iA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=drew@beagleboard.org \
--cc=jkridner@beagleboard.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).