From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v1 1/5] drivercore: Revert "deferral race condition fix" Date: Wed, 14 Nov 2018 10:45:22 +0200 Message-ID: References: <20181110181101.24557-1-andriy.shevchenko@linux.intel.com> <1c2c1031-a6b4-cbce-ceed-c2ce229c204e@ti.com> <20181114003345.GV2089@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20181114003345.GV2089@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: Peter Ujfalusi , Andy Shevchenko , MyungJoo Ham , Chanwoo Choi , USB , Felipe Balbi , Guenter Roeck , "Krogerus, Heikki" , rogerq@ti.com, Linux PM , "Rafael J. Wysocki" , Sebastian Reichel , Linux OMAP Mailing List , Darren Hart , Platform Driver , Greg Kroah-Hartman , Linux Kernel Mailing List , Chen-Yu Tsai , Hans de Goede List-Id: linux-omap@vger.kernel.org On Wed, Nov 14, 2018 at 2:34 AM Mark Brown wrote: > > On Mon, Nov 12, 2018 at 06:11:26PM +0200, Peter Ujfalusi wrote: > > > if we revert the commit then the original issue will re-surfaces. afaik > > it was not only audio which hit the 'last driver to be probed from the > > deferred list would never probe, unless we provoke the kernel to load > > additional module, or remove/reload the module' issue. > > Right, aren't we just going to be swapping one bug for another? Have anyone in possession of Davinchi tested most recent kernel with this revert? > > Do I understand correctly that in your case you have two modules > > (dwc3-pci and extcon-intel-mrfld) in a deferred probe loop, iow both of > > the drivers returns -EPROBE_DEFER and they just spin? > > > If both is deferring, how this supposed to work? > > I'm struggling to follow the original explanation too :( Sorry, guys, I confused a nit myself. The bug is there, but exxplanation is not fully corrent, indeed. I'll come back with more details later. -- With Best Regards, Andy Shevchenko