From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Suman Anna <s-anna@ti.com>
Cc: Lee Jones <lee.jones@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
David Lechner <david@lechnology.com>,
Tony Lindgren <tony@atomide.com>, Roger Quadros <rogerq@ti.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2] mfd: syscon: Use a unique name with regmap_config
Date: Thu, 30 Jan 2020 17:34:15 +0200 [thread overview]
Message-ID: <CAHp75VfaOfBZYjQa960keORW=VjOn2PdwoYpJMG7SsN83daSJg@mail.gmail.com> (raw)
In-Reply-To: <20200127231208.1443-1-s-anna@ti.com>
On Tue, Jan 28, 2020 at 1:14 AM Suman Anna <s-anna@ti.com> wrote:
>
> The DT node full name is currently being used in regmap_config
> which in turn is used to create the regmap debugfs directories.
> This name however is not guaranteed to be unique and the regmap
> debugfs registration can fail in the cases where the syscon nodes
> have the same unit-address but are present in different DT node
> hierarchies. Replace this logic using the syscon reg resource
> address instead (inspired from logic used while creating platform
> devices) to ensure a unique name is given for each syscon.
> - syscon_config.name = of_node_full_name(np);
> + syscon_config.name = kasprintf(GFP_KERNEL, "%pOFn@%llx", np,
> + (u64)res.start);
Explicit castings in printf() usually tell us that something is not okay.
Yes, for resource_size_t we have %pa.
On top of that, I would rather see %pfwn to avoid modification for
other fwnode types.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-01-30 15:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 23:12 [PATCH v2] mfd: syscon: Use a unique name with regmap_config Suman Anna
2020-01-27 23:40 ` David Lechner
2020-01-28 0:27 ` Suman Anna
2020-01-30 15:34 ` Andy Shevchenko [this message]
2020-01-30 17:08 ` Suman Anna
2020-01-30 20:43 ` Andy Shevchenko
2020-02-24 10:00 ` Lee Jones
2020-03-06 0:29 ` Suman Anna
2020-07-24 16:06 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfaOfBZYjQa960keORW=VjOn2PdwoYpJMG7SsN83daSJg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=david@lechnology.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=s-anna@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).