From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Drew Fustini <drew@beagleboard.org>
Cc: Tony Lindgren <tony@atomide.com>,
Linus Walleij <linus.walleij@linaro.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jason Kridner <jkridner@beagleboard.org>,
Robert Nelson <robertcnelson@gmail.com>
Subject: Re: [PATCH v3] pinctrl: core: print gpio in pins debugfs file
Date: Tue, 21 Jul 2020 17:19:05 +0300 [thread overview]
Message-ID: <CAHp75Vfb-RJToJ8s=voPQ7tCutS9tTVpiLY6CwUgMAgcDQxbkQ@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VdfjYuau0cPES7LUy-jN_RLX-L3kspVRMP+1OSZVocmFA@mail.gmail.com>
On Tue, Jul 21, 2020 at 5:17 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Tue, Jul 21, 2020 at 5:10 PM Drew Fustini <drew@beagleboard.org> wrote:
> > On Tue, Jul 21, 2020 at 04:02:34PM +0200, Drew Fustini wrote:
> > > If there is a gpio range mapping for the pin, then print out the gpio
> > > chip and line index for the pin in the debugfs 'pins' file with the
> > > format: "[gpiochip-label]:line-[index] "
...
> > > pin 25 (PIN25) gpio-32-63:line-25 44e10864 00000037 pinctrl-single
> > > pin 26 (PIN26) gpio-32-63:line-26 44e10868 00000037 pinctrl-single
> > > pin 27 (PIN27) gpio-32-63:line-27 44e1086c 00000037 pinctrl-single
> > > pin 28 (PIN28) NA 44e10870 00000036 pinctrl-single
> > > pin 29 (PIN29) NA 44e10874 00000006 pinctrl-single
And would be also better to have
0:N/A
to keep both arguments in it.
> Because line is integer and label is string it is better (from parsing
> of view) to put it other way around, i.e.
>
> %u:%s, label, line
>
> ...
>
> > Apologies - I should not have put the change log in the commit message.
> > Please let me know if I should resubmit.
>
> Since the above comment, I guess it would be good.
> Thanks for doing this!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-07-21 14:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 14:02 [PATCH v3] pinctrl: core: print gpio in pins debugfs file Drew Fustini
2020-07-21 14:10 ` Drew Fustini
2020-07-21 14:17 ` Andy Shevchenko
2020-07-21 14:19 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vfb-RJToJ8s=voPQ7tCutS9tTVpiLY6CwUgMAgcDQxbkQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=drew@beagleboard.org \
--cc=jkridner@beagleboard.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).