linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Roger Quadros <rogerq@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memory: omap-gpmc: Fix compile test on SPARC
Date: Fri, 11 Sep 2020 16:55:44 +0200	[thread overview]
Message-ID: <CAJKOXPeGckdQbHPCw8-sYQgiwSf7aHKnGL0RJjM0K_U6KdROWg@mail.gmail.com> (raw)
In-Reply-To: <bf9aa130-d5e7-d180-5a52-0cb244ffbf4f@ti.com>

On Fri, 11 Sep 2020 at 16:48, Roger Quadros <rogerq@ti.com> wrote:
>
> Hi Krzysztof,
>
> On 11/09/2020 17:32, Krzysztof Kozlowski wrote:
> > SPARC comes without CONFIG_OF_ADDRESS thus compile testing fails on
> > linking:
> >
> >    /usr/bin/sparc64-linux-gnu-ld: drivers/memory/omap-gpmc.o: in function `gpmc_probe_generic_child':
> >    omap-gpmc.c:(.text.unlikely+0x14ec): undefined reference to `of_platform_device_create'
> >
> > Fixes: ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers")
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >   drivers/memory/Kconfig | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> > index 8072204bc21a..00e013b14703 100644
> > --- a/drivers/memory/Kconfig
> > +++ b/drivers/memory/Kconfig
> > @@ -104,6 +104,7 @@ config TI_EMIF
> >
> >   config OMAP_GPMC
> >       bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
> > +     depends on OF_ADDRESS
>
> but of_platform_device_create() is defined in platform.c which gets built
> irrespective of OF_ADDRESS.
>
> Maybe we need to just depend on CONFIG_OF ?

No, the of_platform_device_create() is defined there within #ifdef
CONFIG_OF_ADDRESS

The CONFIG_OF was already selected and was not enough.

Other solution is "depends on !SPARC"...

Best regards,
Krzysztof

  reply	other threads:[~2020-09-11 16:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11 14:32 [PATCH] memory: omap-gpmc: Fix compile test on SPARC Krzysztof Kozlowski
2020-09-11 14:48 ` Roger Quadros
2020-09-11 14:55   ` Krzysztof Kozlowski [this message]
2020-09-15  7:46     ` Roger Quadros
2020-09-15  7:46 ` Roger Quadros
2020-09-16 17:42 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJKOXPeGckdQbHPCw8-sYQgiwSf7aHKnGL0RJjM0K_U6KdROWg@mail.gmail.com \
    --to=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rogerq@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).