From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF2A6C43331 for ; Wed, 1 Apr 2020 18:02:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C64F20719 for ; Wed, 1 Apr 2020 18:02:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GsmNqDfW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732262AbgDASCQ (ORCPT ); Wed, 1 Apr 2020 14:02:16 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:43463 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732285AbgDASCQ (ORCPT ); Wed, 1 Apr 2020 14:02:16 -0400 Received: by mail-pf1-f195.google.com with SMTP id f206so343564pfa.10 for ; Wed, 01 Apr 2020 11:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nN3zsE+FK4cNT3gjBDZd4jgl2nFuBzMDukGWMo8ib/8=; b=GsmNqDfWVuI94Oouw5oRi/M8iAEHPfTyZl24/WcIsq+OX4gRmtf3p5E8jXOLhCQ4TV oQHOknDYzNgrtOTvOLkhmI5KQYwXGOlXugZ7Az/dfPT0w94IQpJSB1g7aPLA4fQ0ki7a vWyLIBQOiPMk+cGIFgLjcxu08/VVqH5PPTyHs8Y1RqOwg7XPnMFRVRBorTILaaFBk5Dg oYAFQoOsNWZYGRfdDUqC8VcyROFgelXyRnCDQH4Yw3Q/zw81xHzn2XO8T+NjwsrLUzjt +Q3etXSA1TCXn0XRKh6TMMW5DMaJNavmVgjbMVbMNioNZEbMInlu9jOGoJmNRRPfc16h mgtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nN3zsE+FK4cNT3gjBDZd4jgl2nFuBzMDukGWMo8ib/8=; b=rsetxr4g/TQMaYkqxwbuENpE0ZnSaG0cjapsYj+CkTtg4yr9hyj5dckdht99+hT/Ps hw82OMbLbeNi5MzKYnMsEowM9C1jdYoWbtl2NEHliWYbQqlIjJHZxeHZBi+MRHB1Oqog R1DbQmP6XU2kA+aNpj91RoadoGg2PQgjGpQ2B5xCOHCvVFyih49kA9LKtHlpjEsoCvFy f2JNK+pAGBffQNdWK0Y+qwPprf3HM4zBKJYCCrNfJ/zFpR7nmPbTtM1N5tx2ySBsauVK WjpdXqah8TOescI1HGKTDO0hfTcqnsG+EXU00g6cKt7+gHZJW9EfP+HXDtSLXqbSX0Kj CnXg== X-Gm-Message-State: ANhLgQ3fDsCkXsBrd3NLZijRQ8jiKvLk4vh9Xn70E0ASp/TTlVzeTuDN IzuIw7a7VmnyFghQ8qA4gE/vXAtDwmwJNg2Kp+M7J5TM838= X-Google-Smtp-Source: ADFU+vu46Uqfs6o6Px6mzmc9zh4c7v6h2s+5k/Y7IBrPgJB3jMFrWnCsH4/l3yf3W7Jxb0rN86SwRgc3KzwC01F6MbE= X-Received: by 2002:a05:6a00:42:: with SMTP id i2mr24113583pfk.108.1585764134729; Wed, 01 Apr 2020 11:02:14 -0700 (PDT) MIME-Version: 1.0 References: <5a6807f19fd69f2de6622c794639cc5d70b9563a.1585513949.git.stefan@agner.ch> In-Reply-To: <5a6807f19fd69f2de6622c794639cc5d70b9563a.1585513949.git.stefan@agner.ch> From: Nick Desaulniers Date: Wed, 1 Apr 2020 11:02:03 -0700 Message-ID: Subject: Re: [PATCH] ARM: OMAP2+: drop unnecessary adrl To: Stefan Agner Cc: tony@atomide.com, Russell King , Linux ARM , linux-omap@vger.kernel.org, LKML , clang-built-linux Content-Type: text/plain; charset="UTF-8" Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Sun, Mar 29, 2020 at 1:33 PM Stefan Agner wrote: > > The adrl instruction has been introduced with commit dd31394779aa ("ARM: > omap3: Thumb-2 compatibility for sleep34xx.S"), back when this assembly > file was considerably longer. Today adr seems to have enough reach, even > when inserting about 60 instructions between the use site and the label. > Replace adrl with conventional adr instruction. > > This allows to build this file using Clang's integrated assembler (which > does not support the adrl pseudo instruction). Context: https://github.com/ClangBuiltLinux/linux/issues/430#issuecomment-476124724 If Peter says it's difficult to implement, I trust him. Reviewed-by: Nick Desaulniers > > Link: https://github.com/ClangBuiltLinux/linux/issues/430 > Signed-off-by: Stefan Agner > --- > arch/arm/mach-omap2/sleep34xx.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/sleep34xx.S b/arch/arm/mach-omap2/sleep34xx.S > index ac1324c6453b..c4e97d35c310 100644 > --- a/arch/arm/mach-omap2/sleep34xx.S > +++ b/arch/arm/mach-omap2/sleep34xx.S > @@ -72,7 +72,7 @@ ENTRY(enable_omap3630_toggle_l2_on_restore) > stmfd sp!, {lr} @ save registers on stack > /* Setup so that we will disable and enable l2 */ > mov r1, #0x1 > - adrl r3, l2dis_3630_offset @ may be too distant for plain adr > + adr r3, l2dis_3630_offset > ldr r2, [r3] @ value for offset > str r1, [r2, r3] @ write to l2dis_3630 > ldmfd sp!, {pc} @ restore regs and return > -- > 2.25.1 > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/5a6807f19fd69f2de6622c794639cc5d70b9563a.1585513949.git.stefan%40agner.ch. -- Thanks, ~Nick Desaulniers