From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A47DEC433C1 for ; Mon, 22 Mar 2021 08:04:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B1A461974 for ; Mon, 22 Mar 2021 08:04:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229715AbhCVIEO (ORCPT ); Mon, 22 Mar 2021 04:04:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbhCVIEK (ORCPT ); Mon, 22 Mar 2021 04:04:10 -0400 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99E24C061574; Mon, 22 Mar 2021 01:04:10 -0700 (PDT) Received: by mail-io1-xd35.google.com with SMTP id v26so12947685iox.11; Mon, 22 Mar 2021 01:04:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NQCjdvCCiui7NyjVPyRHtMOqJO2l/XC/v3WkLyGdTXs=; b=Uq/OBklgV6KsgFXzbeyaRuJUapPvtKTysUFRcCWJfwnQUlE1UDpce59Owq2xmCVq3n C1wfKuf9Ekgl73sGCJOClyGBuNC1qFu3WC1F6XaQCt1Fq/Fiy2NlGpandRD5TdG6riiu qmh4wOzrQ8iGKgpNq45ywuxV1UsM5mL5qm7zapfXE19/Ba4cOlJks8otYTP/uNpi4U3e 070vXWykdlPihP1P5RWGFJd//yLrto7Pu/2e1vtiDGYM3AMBTYAE7wxtMWqgc3TvzffO EM1eV/M9mx8XveD0S5BS1W5Fl+Y1cI3ukzMX4QB4q/uhg9DCOxfAlA5J4ANFApt7utFB +98Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NQCjdvCCiui7NyjVPyRHtMOqJO2l/XC/v3WkLyGdTXs=; b=uTB5mceYOuvEpdk3EATAtf4itg5pzCvY4miNRPZNbXhhDFyDB7a+e9hkTj/Va8d3dE yBhBSBxmwUUgy3oaeY9dmwE23St2cUbBRtLChKXvNA9PTwSiZp2SQH96gkTIMljdPDMn Cvtc7/byJXeDrqlke0X3y0gOP/7FALXav/Q2Z9dS7mVeTTlqIF7fp7lDuqbcyCA3lWcN Ay1n18ArLBLA6wL0MBsM1mW1klolOJEolE46NbVQbddhokCR9h9+y5YWAZb9tlTLjoJ9 DJOWGQeA/NlchsNbU3cnlEafU/OUZG+8+TL6FYc5bzoKU05ngRTE/WHQGSkfPo8xhBGR toIg== X-Gm-Message-State: AOAM5323LMJUbvHYx9gCxDP4nnuv6SA7MitzdYCTNkT1HJs6SOq7uvYM T9/XoosDJ3hSockyOBIQ94JMi3M1xh26VY/2354gRLCd X-Google-Smtp-Source: ABdhPJwdqhT0oEb6tE/dej3q9+JpzvaDLk1Lxf4HQ/V4S8rkNVvaT6uKCMGjCO5kDCBKzvQld8WYIz1HewAlaPK1TRI= X-Received: by 2002:a02:a889:: with SMTP id l9mr10105193jam.1.1616400250019; Mon, 22 Mar 2021 01:04:10 -0700 (PDT) MIME-Version: 1.0 References: <20210318231829.3892920-1-olteanv@gmail.com> <20210318231829.3892920-15-olteanv@gmail.com> <20210319084025.GA2152639@haswell-ubuntu20> <20210319090642.bzmtlzc5im6xtbkh@skbuf> <20210319104924.gcdobjxmqcf6s4wq@skbuf> In-Reply-To: <20210319104924.gcdobjxmqcf6s4wq@skbuf> From: DENG Qingfang Date: Mon, 22 Mar 2021 16:04:01 +0800 Message-ID: Subject: Re: [RFC PATCH v2 net-next 14/16] net: dsa: don't set skb->offload_fwd_mark when not offloading the bridge To: Vladimir Oltean Cc: Jakub Kicinski , "David S. Miller" , Andrew Lunn , Vivien Didelot , Florian Fainelli , Tobias Waldekranz , netdev , linux-kernel@vger.kernel.org, Roopa Prabhu , Nikolay Aleksandrov , Jiri Pirko , Ido Schimmel , Alexandre Belloni , UNGLinuxDriver@microchip.com, Vadym Kochan , Taras Chornyi , Grygorii Strashko , Vignesh Raghavendra , Ioana Ciornei , Ivan Vecera , linux-omap@vger.kernel.org, Vladimir Oltean Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Fri, Mar 19, 2021 at 6:49 PM Vladimir Oltean wrote: > Why would you even want to look at the source net device for forwarding? > I'd say that if dp->bridge_dev is NULL in the xmit function, you certainly > want to bypass address learning if you can. Maybe also for link-local traffic. Also for trapped traffic (snooping, tc-flower trap action) if the CPU sends them back.