From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAE6DC77B75 for ; Tue, 16 May 2023 15:41:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234005AbjEPPlr (ORCPT ); Tue, 16 May 2023 11:41:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233998AbjEPPln (ORCPT ); Tue, 16 May 2023 11:41:43 -0400 Received: from mail-vk1-xa30.google.com (mail-vk1-xa30.google.com [IPv6:2607:f8b0:4864:20::a30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D2E17A94 for ; Tue, 16 May 2023 08:41:31 -0700 (PDT) Received: by mail-vk1-xa30.google.com with SMTP id 71dfb90a1353d-44fa6454576so5055029e0c.0 for ; Tue, 16 May 2023 08:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20221208.gappssmtp.com; s=20221208; t=1684251690; x=1686843690; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dUlgGwi/Bid+V+vNq0ihjnvnFHGXCmk1OrWz555v4NM=; b=PwfMKsdb+yRpZ4onFvCLkAE93SmlnNm0Ta3+o6TB28KIbmR8tK1ZYoO5t9fa4TfPDk lw9jaDL9fSmEFurrwzHmqYRCZPO8h/K8PRgP03l8Rpkpy/9kOa4cFt8n8j/IGa4PjN5e xe06l6ToYOPFrMKxW5ChRmmbw1TPJSTuq+KM+CMWNiIY1fnlHEq2AdRLU0uXN/ihPxLl D4LDqU8lNz6pSLUwB9xkU6A2/8AVlFvNoTVW4QYLQKPr6NwqWVxkKiNB3QSdLhGbe7dD zgCFO+ccPHibN/JBS4R/XtUiJFNonfUTYhe+mKZxY061UdbpsdpRUasBFCuuRG8NRtaP d4Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684251690; x=1686843690; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dUlgGwi/Bid+V+vNq0ihjnvnFHGXCmk1OrWz555v4NM=; b=WEcVL7nQYwu8oWh7kO+jG1O7Ytt5y8KS5f8FLP+zpThDAQPa1ne8kJ8VSiAuC48Oeb ZkSQQyLvrISoxcVfuy/RcDjOYosAnCdUgTCFazbLx2DUjbBuat5pRDjcDr+u39V/tV9S 7OOFYnc5p2ybJaMetkoW77zacGx7Q/Nv1SryNLyNg6jpHRKua8HGYKR2sFmlVq1potHW oOWv+CpTMF3m8ovBW8q+6NlEcONCdHOvE5mCIHhyKKTRZbfMHgO+bONql1HP0ZDB5H4L 3f+dqVs6XDYHfgXua+H10mgF6fuTgnJxBDa3ViZPu+Xvt9q8zV6QQZHyTXASKc4k+Waj BycA== X-Gm-Message-State: AC+VfDx5peceEMmvJ2dEHgGivkrCi/KyW95FxiFcr6zYFDLnj4j5yb9e aeeX5uIsyeoi6KSDcJvIz8vkc4oMrlOswdcjs+IwKg== X-Google-Smtp-Source: ACHHUZ7geFgnpKprltmekDwePERwLI1/NGr2YZczOVKccWMobKpDNL54KOiEZyFYlCUv/sA4Wmnqgjfv0BdhoMFOVIs= X-Received: by 2002:a1f:bd47:0:b0:44f:cc25:2007 with SMTP id n68-20020a1fbd47000000b0044fcc252007mr12901502vkf.11.1684251690642; Tue, 16 May 2023 08:41:30 -0700 (PDT) MIME-Version: 1.0 References: <20230516153109.514251-1-arnd@kernel.org> <20230516153109.514251-2-arnd@kernel.org> In-Reply-To: <20230516153109.514251-2-arnd@kernel.org> From: Bartosz Golaszewski Date: Tue, 16 May 2023 17:41:19 +0200 Message-ID: Subject: Re: [PATCH 01/13] ARM: davinci: fix davinci_cpufreq_init() declaration To: Arnd Bergmann Cc: soc@kernel.org, Arnd Bergmann , Russell King , Hartley Sweeten , Alexander Sverdlin , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Tue, May 16, 2023 at 5:31=E2=80=AFPM Arnd Bergmann wro= te: > > From: Arnd Bergmann > > The davinci_cpufreq_init() declaration is only seen by its caller > but not the definition: > > drivers/cpufreq/davinci-cpufreq.c:153:12: error: no previous prototype fo= r 'davinci_cpufreq_init' > > Move it into the platform_data header that is already used an > interface between the two places. > > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-davinci/common.c | 1 + > arch/arm/mach-davinci/common.h | 6 ------ > include/linux/platform_data/davinci-cpufreq.h | 6 ++++++ > 3 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/mach-davinci/common.c b/arch/arm/mach-davinci/commo= n.c > index c1ce6b2a8d48..7bc7018688de 100644 > --- a/arch/arm/mach-davinci/common.c > +++ b/arch/arm/mach-davinci/common.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > > #include > #include > diff --git a/arch/arm/mach-davinci/common.h b/arch/arm/mach-davinci/commo= n.h > index b2a96cdf88da..010ba1df27b3 100644 > --- a/arch/arm/mach-davinci/common.h > +++ b/arch/arm/mach-davinci/common.h > @@ -55,12 +55,6 @@ extern void davinci_common_init(const struct davinci_s= oc_info *soc_info); > extern void davinci_init_ide(void); > void davinci_init_late(void); > > -#ifdef CONFIG_CPU_FREQ > -int davinci_cpufreq_init(void); > -#else > -static inline int davinci_cpufreq_init(void) { return 0; } > -#endif > - > #ifdef CONFIG_SUSPEND > int davinci_pm_init(void); > #else > diff --git a/include/linux/platform_data/davinci-cpufreq.h b/include/linu= x/platform_data/davinci-cpufreq.h > index bc208c64e3d7..1ef91c36f609 100644 > --- a/include/linux/platform_data/davinci-cpufreq.h > +++ b/include/linux/platform_data/davinci-cpufreq.h > @@ -16,4 +16,10 @@ struct davinci_cpufreq_config { > int (*init)(void); > }; > > +#ifdef CONFIG_CPU_FREQ > +int davinci_cpufreq_init(void); > +#else > +static inline int davinci_cpufreq_init(void) { return 0; } > +#endif > + > #endif /* _MACH_DAVINCI_CPUFREQ_H */ > -- > 2.39.2 > Acked-by: Bartosz Golaszewski