linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
To: Suman Anna <s-anna@ti.com>
Cc: Santosh Shilimkar <ssantosh@kernel.org>,
	Santosh Shilimkar <santosh.shilimkar@oracle.com>,
	Lee Jones <lee.jones@linaro.org>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, "Bajjuri,
	Praneeth" <praneeth@ti.com>,
	tony@atomide.com, Wei Yongjun <weiyongjun1@huawei.com>
Subject: Re: [PATCH] soc: ti: pruss: Remove wrong check against *get_match_data return value
Date: Mon, 16 Nov 2020 18:17:37 +0100	[thread overview]
Message-ID: <CAMxfBF4SJsPYZqr5nB4puQAFPGWh6X-L6ty027dAJgdUvy9EZw@mail.gmail.com> (raw)
In-Reply-To: <a1a787b2-efac-3baf-2a3c-ba135b8b32d0@ti.com>

Hi Suman,

On Tue, 10 Nov 2020 at 21:43, Suman Anna <s-anna@ti.com> wrote:
>
> Hi Greg,
>
> On 10/26/20 9:49 AM, Grzegorz Jaszczyk wrote:
> > Since the of_device_get_match_data() doesn't return error code, remove
> > wrong IS_ERR test. Proper check against NULL pointer is already done
> > later before usage: if (data && data->...).
> >
> > Additionally, proceeding with empty device data is valid (e.g. in case
> > of "ti,am3356-pruss").
> >
> > Reported-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> Please add the appropriate Fixes: tag.
>
> And prefer %s/Remove/Fix/ in patch title.

Sure.

>
> With that,
> Acked-by: Suman Anna <s-anna@ti.com>

Thank you, I will post v2 with all improvements soon.
Best regards,
Grzegorz

      reply	other threads:[~2020-11-16 17:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 14:49 Grzegorz Jaszczyk
2020-11-10 20:42 ` Suman Anna
2020-11-16 17:17   ` Grzegorz Jaszczyk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMxfBF4SJsPYZqr5nB4puQAFPGWh6X-L6ty027dAJgdUvy9EZw@mail.gmail.com \
    --to=grzegorz.jaszczyk@linaro.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=praneeth@ti.com \
    --cc=s-anna@ti.com \
    --cc=santosh.shilimkar@oracle.com \
    --cc=ssantosh@kernel.org \
    --cc=tony@atomide.com \
    --cc=weiyongjun1@huawei.com \
    --subject='Re: [PATCH] soc: ti: pruss: Remove wrong check against *get_match_data return value' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).