From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4DADC433E0 for ; Mon, 8 Feb 2021 12:10:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4E6464E85 for ; Mon, 8 Feb 2021 12:10:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230208AbhBHMKb (ORCPT ); Mon, 8 Feb 2021 07:10:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233572AbhBHMIj (ORCPT ); Mon, 8 Feb 2021 07:08:39 -0500 Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D515C0617A9 for ; Mon, 8 Feb 2021 04:07:38 -0800 (PST) Received: by mail-vs1-xe33.google.com with SMTP id u7so2649084vsp.12 for ; Mon, 08 Feb 2021 04:07:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q+j5o1c0su2L6YdF71vWuSQLkAAyzmVika0Z7We4Rac=; b=fGVWBffzUrOIaO3OE9oqhO2bDHkyUt6xA45dv+PjB3q6C2+dLEpXekxAyisHfGOK+K ykgs+JcdTimpWykmP6LCmsZIUB8GrEmDWzU/hg7gooX8xJWFXUZMNORu/vPtadQUMdR4 1Om4gc4kgRhtpIllX9VLrQxhtdQKBd9LSk92ZhbA8B22mG00N9T+VjOIAKztk0/F57k1 ESTec0UJjqRtFNbSEWwqm6dJFxzWDjgrBfnRX9IS8A1tAtfWhjWG5Ocz9ProgoozNGHR RN2ww2Ey2y0zLA7/edPES5Jf0PRSTh0lN0adOf5qc5lMY8M3+CFTgUVzIED9TKqP7TpX +qUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q+j5o1c0su2L6YdF71vWuSQLkAAyzmVika0Z7We4Rac=; b=XlbqJHVF9hDBU+i6TC/fxo0HG7mtoxMewKqSzOdGuSQ9nd2j6hlAdbCY6MtUWDWUIu rl/0pOhGTP0obCr1FBkOFYKUvneOBY0cSAdkKnyv4R9TXTlYXvWvMv6r0Jfgcfbwpgul 9sO+QBSMITFg55NbZ/aMsl8xZugge1jzqQFI/dAdoumbFPzQkQK4O/egQovRxpN9y3N4 OowOLRKHmxzb4l5gyjJPNIuaifePui3Yql7QjJveaHr8efloyUB6QlLVT6/WUkw2jg7O QfEQjWkZ2gMEGAVnGLE59mZcJNS0SufX2d6I/72u9ZmfLkGtyeJxGBQlARqP4V/itLeF 9fRw== X-Gm-Message-State: AOAM531zoJWEhfQ8Kn+py1Liauy0wYTJJ8rlSkKzmP0ro0b9pKDcYmdC MaE6H+2gcDJX0hP6ckTUPVclC+7/aJXbBehMBdfo+w== X-Google-Smtp-Source: ABdhPJzdeJt7cR2Lci0/u43eiwTMDXryQjeAQX7GjhkgnwIUBZrkUU985x0DMiJvS4aJ2y06E5DIneLyvogQpFyKpI4= X-Received: by 2002:a67:c787:: with SMTP id t7mr10392016vsk.48.1612786057397; Mon, 08 Feb 2021 04:07:37 -0800 (PST) MIME-Version: 1.0 References: <20210204151847.91353-1-kernel@esmil.dk> In-Reply-To: <20210204151847.91353-1-kernel@esmil.dk> From: Ulf Hansson Date: Mon, 8 Feb 2021 13:07:00 +0100 Message-ID: Subject: Re: [PATCH 0/9] drivers: mmc: Update trivial tasklet_init() callers To: Emil Renner Berthing Cc: "linux-mmc@vger.kernel.org" , linux-omap , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Manuel Lauss , Jaehoon Chung , Aaro Koskinen , Ben Dooks , Alex Dubov , Bruce Chang , Harald Welte , Pierre Ossman , Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Thu, 4 Feb 2021 at 16:19, Emil Renner Berthing wrote: > > This updates callers of tasklet_init() in drivers/mmc to the new API > in commit 12cc923f1ccc ("tasklet: Introduce new initialization API") > > All changes are made by coccinelle using the following semantic patch: > > @ match @ > type T; > T *container; > identifier tasklet; > identifier callback; > @@ > tasklet_init(&container->tasklet, callback, (unsigned long)container); > > @ patch1 depends on match @ > type match.T; > identifier match.tasklet; > identifier match.callback; > identifier data; > identifier container; > @@ > -void callback(unsigned long data) > +void callback(struct tasklet_struct *t) > { > ... > - T *container = \( (T *)data \| (void *)data \); > + T *container = from_tasklet(container, t, tasklet); > ... > } > > @ patch2 depends on match @ > type match.T; > identifier match.tasklet; > identifier match.callback; > identifier data; > identifier container; > @@ > -void callback(unsigned long data) > +void callback(struct tasklet_struct *t) > { > ... > - T *container; > + T *container = from_tasklet(container, t, tasklet); > ... > - container = \( (T *)data \| (void *)data \); > ... > } > > @ depends on (patch1 || patch2) @ > match.T *container; > identifier match.tasklet; > identifier match.callback; > @@ > - tasklet_init(&container->tasklet, callback, (unsigned long)container); > + tasklet_setup(&container->tasklet, callback); > > > Emil Renner Berthing (9): > mmc: atmel-mci: Use new tasklet API > mmc: au1xmmc: Use new tasklet API > mmc: dw_mmc: Use new tasklet API > mmc: omap: Use new tasklet API > mmc: s3cmci: Use new tasklet API > mmc: tifm_sd: Use new tasklet API > mmc: uniphier-sd: Use new tasklet API > mmc: via-sdmmc: Use new tasklet API > mmc: wbsd: Use new tasklet API > > drivers/mmc/host/atmel-mci.c | 6 +++--- > drivers/mmc/host/au1xmmc.c | 14 ++++++-------- > drivers/mmc/host/dw_mmc.c | 6 +++--- > drivers/mmc/host/omap.c | 7 +++---- > drivers/mmc/host/s3cmci.c | 6 +++--- > drivers/mmc/host/tifm_sd.c | 7 +++---- > drivers/mmc/host/uniphier-sd.c | 14 ++++++-------- > drivers/mmc/host/via-sdmmc.c | 9 +++------ > drivers/mmc/host/wbsd.c | 35 +++++++++++++++------------------- > 9 files changed, 45 insertions(+), 59 deletions(-) > Applied for next, thanks! Kind regards Uffe