From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3CBFC388F9 for ; Wed, 11 Nov 2020 19:27:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 451A2208B8 for ; Wed, 11 Nov 2020 19:27:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="sif0h61B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725955AbgKKT1Y (ORCPT ); Wed, 11 Nov 2020 14:27:24 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.54]:29405 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727439AbgKKT1Y (ORCPT ); Wed, 11 Nov 2020 14:27:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1605122842; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=e9WwM7N9LOltdoG8H7BpzxtEEkb64OrgEv+/T1RrZfo=; b=sif0h61BlJby43VV88ub5XOXpXKe0YWrDVvkYdJoMSNdGwiwWe7Ab1o2JHRCzWFKIS JnImNipeHeptYYlpkTLaa2jkmCfCREfvzw+2PL4SNHUG8x45R6avEu1o7Y7mWQVytNjz 7WzMe+dS5or5aESf2IYX/Otj5LYssuy6DH7u2ah6a7mP/ppTnriaVewtKIS8DsB6q58G 6tezP6vCce6RunHLOeQ5NefFIbgJHI3b7YJXXZAr0rXZmGDaLMZIMKiGMLvRoE7l8ANF hD8Og/UrjUHEULMCRdtCJLNzsS+96vpMpAVYEf0MsP1QbugRCEgt32ywkvL+t6APuu5a pdsg== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw9iZeHmAvw43o9ik=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.3.4 DYNA|AUTH) with ESMTPSA id N02faawABJR1BVO (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 11 Nov 2020 20:27:01 +0100 (CET) Subject: Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=us-ascii From: "H. Nikolaus Schaller" In-Reply-To: <5bd687c4-fff9-0381-a811-d4019cacf7e9@ti.com> Date: Wed, 11 Nov 2020 20:27:01 +0100 Cc: Sebastian Reichel , Laurent Pinchart , Nikhil Devshatwar , Linux-OMAP , dri-devel , Sekhar Nori , Tony Lindgren , Discussions about the Letux Kernel Content-Transfer-Encoding: quoted-printable Message-Id: References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <837EA533-9946-43B3-B058-69060EC43981@goldelico.com> <08589e51-f5e6-2743-57ec-8ac509f97ff0@ti.com> <1f1afce4-c822-0fbf-1ce3-dda0064b65c6@ti.com> <67786545-23D2-444F-85B8-7A030070B317@goldelico.com> <17F5238B-1CC3-4764-B744-C57D9CE4EB42@goldelico.com> <6A9407FC-69F7-4E30-B4A3-FFB2E91CAE3B@goldelico.com> <1cf563e5-2dc0-1802-86e3-3e24150f0651@ti.com> <7f820fd2-820b-bfdd-a43b-174ad6b09868@ti.com> <0AF59BFD-89F2-46D3-9EB6-F47FBB52B183@goldelico.com> <917fe1c6-4009-7788-f815-fcc1fc2ba7df@ti.com> <2265AEF5-42BC-4E7B-B263-D0B93B78DE91@goldelico.com> <5bd687c4-fff9-0381-a811-d4019cacf7e9@ti.com> To: Tomi Valkeinen X-Mailer: Apple Mail (2.3124) Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org > Am 11.11.2020 um 11:11 schrieb Tomi Valkeinen : >=20 > On 11/11/2020 09:48, H. Nikolaus Schaller wrote: >>=20 >>> Am 11.11.2020 um 07:40 schrieb Tomi Valkeinen = : >>>=20 >>> On 10/11/2020 23:04, H. Nikolaus Schaller wrote: >>>>=20 >>>>> Am 10.11.2020 um 17:52 schrieb Tomi Valkeinen = : >>>>>=20 >>>>> On 10/11/2020 18:49, H. Nikolaus Schaller wrote: >>>>>=20 >>>>> I guess you have the same issue. It goes to dsi_bridge_mode_valid, = then __dsi_calc_config, and stays >>>>> there finding good clocks. >>>>=20 >>>=20 >>> drm_display_mode.clock is in kHz, but the panel driver writes Hz = (w677l_PIXELCLOCK) to it. >>=20 >> Ok, fixing this removes the stuck thread issue. Thanks for pointing = this out! >>=20 >>> But >>> there's more after fixing that. The DSI gets configured in bridge's = modeset, which I think is before >>> w677l_prepare where the panel already sends DSI commands. Also, the = dsi driver fails to lock the >>> PLL, so possibly the clock calcs are still wrong. >>=20 >> What I now get is >>=20 >> [ 131.035006] [drm:drm_atomic_helper_wait_for_dependencies = [drm_kms_helper]] *ERROR* [CRTC:55:crtc-0] flip_done timed out >> [ 141.272174] [drm:drm_atomic_helper_wait_for_dependencies = [drm_kms_helper]] *ERROR* [CONNECTOR:54:DSI-1] flip_done timed out >>=20 >> I think for further experiments we could hack the device tree to = compatible =3D "orisetech,otm8009a"; >> and configure for panel-orisetech-otm8009a.ko. Since this panel = driver is known to work elsewhere >> we could exclude panel driver issues for the moment. To be safe we = can modify otm8009a_dcs_write_buf() >> to just print what it would be doing. >=20 > I pushed some quick fixes/hacks to: >=20 > git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git 5.11/dsi >=20 > At least I get the DSI PLL configured, and kmstest --flip works with = 60 fps. > I'm pretty sure the panel won't work yet, though. Yes, as expected it still does not work. I see: [ 168.236405] dsi_bridge_mode_valid r=3D-22 [ 168.411769] omapdrm omapdrm.0: [drm] Cannot find any crtc or sizes [ 168.418382] omapdrm omapdrm.0: [drm] crtc_count =3D 0 width=3D-1 = height=3D-1 The -EINVAL seems to come from dss_pll_calc_a() returning false. So clock calculation sill fails after fixing the pixel clock. No successful combination. BR, Nikolaus=