From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Support Opensource <Support.Opensource@diasemi.com>,
Lee Jones <lee.jones@linaro.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Tony Lindgren <tony@atomide.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"patches@opensource.cirrus.com" <patches@opensource.cirrus.com>
Subject: RE: [PATCH 3/7] mfd: da9052: Simplify getting of_device_id match data
Date: Mon, 19 Apr 2021 11:00:04 +0000 [thread overview]
Message-ID: <PR3PR10MB414231DE2AC6E7B8326D0CE380499@PR3PR10MB4142.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210419081726.67867-3-krzysztof.kozlowski@canonical.com>
On 19 April 2021 09:17, Krzysztof Kozlowski wrote:
> Use of_device_get_match_data() to make the code slightly smaller.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> drivers/mfd/da9052-i2c.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c
> index 47556d2d9abe..5d8ce8dca3fc 100644
> --- a/drivers/mfd/da9052-i2c.c
> +++ b/drivers/mfd/da9052-i2c.c
> @@ -154,13 +154,8 @@ static int da9052_i2c_probe(struct i2c_client *client,
> return ret;
>
> #ifdef CONFIG_OF
> - if (!id) {
> - struct device_node *np = client->dev.of_node;
> - const struct of_device_id *deviceid;
> -
> - deviceid = of_match_node(dialog_dt_ids, np);
> - id = deviceid->data;
> - }
> + if (!id)
> + id = of_device_get_match_data(&client->dev);
> #endif
>
> if (!id) {
> --
> 2.25.1
next prev parent reply other threads:[~2021-04-19 11:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 8:17 [PATCH 1/7] mfd: max8997: Simplify getting of_device_id match data Krzysztof Kozlowski
2021-04-19 8:17 ` [PATCH 2/7] mfd: max8998: " Krzysztof Kozlowski
2021-04-19 8:17 ` [PATCH 3/7] mfd: da9052: " Krzysztof Kozlowski
2021-04-19 11:00 ` Adam Thomson [this message]
2021-04-19 8:17 ` [PATCH 4/7] " Krzysztof Kozlowski
2021-04-19 11:00 ` Adam Thomson
2021-04-19 11:04 ` Krzysztof Kozlowski
2021-04-19 8:17 ` [PATCH 5/7] mfd: sec: " Krzysztof Kozlowski
2021-04-20 5:25 ` Marek Szyprowski
2021-04-20 7:03 ` Krzysztof Kozlowski
2021-04-20 7:12 ` Marek Szyprowski
2021-04-20 7:25 ` Krzysztof Kozlowski
2021-04-19 8:17 ` [PATCH 6/7] mfd: wm831x: Correct kerneldoc Krzysztof Kozlowski
2021-04-19 8:41 ` Charles Keepax
2021-04-19 8:17 ` [PATCH 7/7] mfd: twl: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PR3PR10MB414231DE2AC6E7B8326D0CE380499@PR3PR10MB4142.EURPRD10.PROD.OUTLOOK.COM \
--to=adam.thomson.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=b.zolnierkie@samsung.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).