From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 187DFC4361B for ; Tue, 8 Dec 2020 15:42:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D452723A9B for ; Tue, 8 Dec 2020 15:42:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729977AbgLHPmI (ORCPT ); Tue, 8 Dec 2020 10:42:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729929AbgLHPmI (ORCPT ); Tue, 8 Dec 2020 10:42:08 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3F04C061749 for ; Tue, 8 Dec 2020 07:41:27 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3D64EDD; Tue, 8 Dec 2020 16:41:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1607442086; bh=P4KJqA7oTKz05aj0nUmZIboQRZHX37Pwdm5FCEsLdvM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q8iidJyisoeEXGdkahBhpzmXUHS87O2myDOD6x1nQEwR38oMYc18yj8WFABXOHxJy xW9L6obD34DeYeEzgTvdMdOYJXI1m51L+JJPwZOg5tYLXgYk4jvdT6RxMHLIfmGIw1 ia9scOPdHyQIlZn+Up1M/wHoHjvcHvt6n5UwACGs= Date: Tue, 8 Dec 2020 17:41:23 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: Sebastian Reichel , Nikhil Devshatwar , dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, Sekhar Nori , Tony Lindgren , hns@goldelico.com, Sam Ravnborg Subject: Re: [PATCH v5 12/29] drm/omap: dsi: untangle vc & channel Message-ID: References: <20201208122855.254819-1-tomi.valkeinen@ti.com> <20201208122855.254819-13-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201208122855.254819-13-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tomi, Thank you for the patch. On Tue, Dec 08, 2020 at 02:28:38PM +0200, Tomi Valkeinen wrote: > DSI virtual channel and hardware VC blocks have gotten tangled as > described in the previous commits. This has not caused any issues, as > the value for both is 0, so it happens to work. > > To fix the issue, change the code to use the correct one of the two. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 43 +++++++++++++++---------------- > 1 file changed, 21 insertions(+), 22 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index 8d8412199693..a1f3623f45b1 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -2613,7 +2613,7 @@ static inline void dsi_vc_write_long_header(struct dsi_data *dsi, int vc, > > WARN_ON(!dsi_bus_is_locked(dsi)); > > - data_id = data_type | vc << 6; > + data_id = data_type | channel << 6; > > val = FLD_VAL(data_id, 7, 0) | FLD_VAL(len, 23, 8) | > FLD_VAL(ecc, 31, 24); > @@ -2647,12 +2647,12 @@ static int dsi_vc_send_long(struct dsi_data *dsi, int vc, > DSSDBG("dsi_vc_send_long, %d bytes\n", msg->tx_len); > > /* len + header */ > - if (dsi->vc[msg->channel].tx_fifo_size * 32 * 4 < msg->tx_len + 4) { > + if (dsi->vc[vc].tx_fifo_size * 32 * 4 < msg->tx_len + 4) { > DSSERR("unable to send long packet: packet too long.\n"); > return -EINVAL; > } > > - dsi_vc_config_source(dsi, msg->channel, DSI_VC_SOURCE_L4); > + dsi_vc_config_source(dsi, vc, DSI_VC_SOURCE_L4); > > dsi_vc_write_long_header(dsi, vc, msg->channel, msg->type, msg->tx_len, 0); > > @@ -2666,7 +2666,7 @@ static int dsi_vc_send_long(struct dsi_data *dsi, int vc, > b3 = *p++; > b4 = *p++; > > - dsi_vc_write_long_payload(dsi, msg->channel, b1, b2, b3, b4); > + dsi_vc_write_long_payload(dsi, vc, b1, b2, b3, b4); > } > > i = msg->tx_len % 4; > @@ -2691,7 +2691,7 @@ static int dsi_vc_send_long(struct dsi_data *dsi, int vc, > break; > } > > - dsi_vc_write_long_payload(dsi, msg->channel, b1, b2, b3, 0); > + dsi_vc_write_long_payload(dsi, vc, b1, b2, b3, 0); > } > > return r; > @@ -2711,11 +2711,11 @@ static int dsi_vc_send_short(struct dsi_data *dsi, int vc, > > if (dsi->debug_write) > DSSDBG("dsi_vc_send_short(ch%d, dt %#x, b1 %#x, b2 %#x)\n", > - msg->channel, msg->type, pkt.header[1], pkt.header[2]); > + vc, msg->type, pkt.header[1], pkt.header[2]); > > - dsi_vc_config_source(dsi, msg->channel, DSI_VC_SOURCE_L4); > + dsi_vc_config_source(dsi, vc, DSI_VC_SOURCE_L4); > > - if (FLD_GET(dsi_read_reg(dsi, DSI_VC_CTRL(msg->channel)), 16, 16)) { > + if (FLD_GET(dsi_read_reg(dsi, DSI_VC_CTRL(vc)), 16, 16)) { > DSSERR("ERROR FIFO FULL, aborting transfer\n"); > return -EINVAL; > } > @@ -2723,7 +2723,7 @@ static int dsi_vc_send_short(struct dsi_data *dsi, int vc, > r = pkt.header[3] << 24 | pkt.header[2] << 16 | pkt.header[1] << 8 | > pkt.header[0]; > > - dsi_write_reg(dsi, DSI_VC_SHORT_PACKET_HEADER(msg->channel), r); > + dsi_write_reg(dsi, DSI_VC_SHORT_PACKET_HEADER(vc), r); > > return 0; > } > @@ -2731,7 +2731,7 @@ static int dsi_vc_send_short(struct dsi_data *dsi, int vc, > static int dsi_vc_send_null(struct dsi_data *dsi, int vc, int channel) > { > const struct mipi_dsi_msg msg = { > - .channel = vc, > + .channel = channel, > .type = MIPI_DSI_NULL_PACKET, > }; > > @@ -2759,16 +2759,16 @@ static int dsi_vc_write_common(struct omap_dss_device *dssdev, int vc, > * In that case we can return early. > */ > > - r = dsi_vc_send_bta_sync(dssdev, msg->channel); > + r = dsi_vc_send_bta_sync(dssdev, vc); > if (r) { > DSSERR("bta sync failed\n"); > return r; > } > > /* RX_FIFO_NOT_EMPTY */ > - if (REG_GET(dsi, DSI_VC_CTRL(msg->channel), 20, 20)) { > + if (REG_GET(dsi, DSI_VC_CTRL(vc), 20, 20)) { > DSSERR("rx fifo not empty after write, dumping data:\n"); > - dsi_vc_flush_receive_data(dsi, msg->channel); > + dsi_vc_flush_receive_data(dsi, vc); > return -EIO; > } > > @@ -2888,21 +2888,20 @@ static int dsi_vc_dcs_read(struct omap_dss_device *dssdev, int vc, > { > struct dsi_data *dsi = to_dsi_data(dssdev); > u8 cmd = ((u8 *)msg->tx_buf)[0]; > - u8 channel = msg->channel; > int r; > > if (dsi->debug_read) > - DSSDBG("%s(ch %d, cmd %x)\n", __func__, channel, cmd); > + DSSDBG("%s(ch %d, cmd %x)\n", __func__, vc, cmd); How about also renaming ch to vc in the message ? > > r = dsi_vc_send_short(dsi, vc, msg); > if (r) > goto err; > > - r = dsi_vc_send_bta_sync(dssdev, channel); > + r = dsi_vc_send_bta_sync(dssdev, vc); > if (r) > goto err; > > - r = dsi_vc_read_rx_fifo(dsi, channel, msg->rx_buf, msg->rx_len, > + r = dsi_vc_read_rx_fifo(dsi, vc, msg->rx_buf, msg->rx_len, > DSS_DSI_CONTENT_DCS); > if (r < 0) > goto err; > @@ -2914,7 +2913,7 @@ static int dsi_vc_dcs_read(struct omap_dss_device *dssdev, int vc, > > return 0; > err: > - DSSERR("%s(ch %d, cmd 0x%02x) failed\n", __func__, msg->channel, cmd); > + DSSERR("%s(ch %d, cmd 0x%02x) failed\n", __func__, vc, cmd); Same here. > return r; > } > > @@ -2928,11 +2927,11 @@ static int dsi_vc_generic_read(struct omap_dss_device *dssdev, int vc, > if (r) > goto err; > > - r = dsi_vc_send_bta_sync(dssdev, msg->channel); > + r = dsi_vc_send_bta_sync(dssdev, vc); > if (r) > goto err; > > - r = dsi_vc_read_rx_fifo(dsi, msg->channel, msg->rx_buf, msg->rx_len, > + r = dsi_vc_read_rx_fifo(dsi, vc, msg->rx_buf, msg->rx_len, > DSS_DSI_CONTENT_GENERIC); > if (r < 0) > goto err; > @@ -2944,7 +2943,7 @@ static int dsi_vc_generic_read(struct omap_dss_device *dssdev, int vc, > > return 0; > err: > - DSSERR("%s(ch %d, reqlen %d) failed\n", __func__, msg->channel, msg->tx_len); > + DSSERR("%s(ch %d, reqlen %d) failed\n", __func__, vc, msg->tx_len); And here. Reviewed-by: Laurent Pinchart > return r; > } > > @@ -4893,7 +4892,7 @@ static ssize_t _omap_dsi_host_transfer(struct dsi_data *dsi, int vc, > int r; > > if (!!(msg->flags & MIPI_DSI_MSG_USE_LPM) != dsi->in_lp_mode) > - dsi_vc_enable_hs(dssdev, msg->channel, > + dsi_vc_enable_hs(dssdev, vc, > !(msg->flags & MIPI_DSI_MSG_USE_LPM)); > > switch (msg->type) { -- Regards, Laurent Pinchart