From: Lee Jones <lee@kernel.org>
To: Jerome Neanne <jneanne@baylibre.com>
Cc: tony@atomide.com, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, khilman@baylibre.com, nm@ti.com,
afd@ti.com, msp@baylibre.com
Subject: Re: [PATCH] mfd: tps65219: Add support for soft shutdown via sys-off API
Date: Wed, 1 Mar 2023 16:07:25 +0000 [thread overview]
Message-ID: <Y/94Pew4vr6FROcI@google.com> (raw)
In-Reply-To: <20230203140150.13071-1-jneanne@baylibre.com>
On Fri, 03 Feb 2023, Jerome Neanne wrote:
> Use new API for power-off mode support:
> Link: https://lwn.net/Articles/894511/
> Link: https://lore.kernel.org/all/7hfseqa7l0.fsf@baylibre.com/
>
> sys-off API allows support of shutdown handler and restart handler.
>
> Shutdown was not supported before that enhancement.
> This is required for platform that are not using PSCI.
>
> Test:
> - restart:
> # reboot
> Default is cold reset:
> # cat /sys/kernel/reboot/mode
> Switch boot mode to warm reset:
> # echo warm > /sys/kernel/reboot/mode
> - power-off:
> # halt
>
> Tested on AM62-SP-SK board.
>
> Signed-off-by: Jerome Neanne <jneanne@baylibre.com>
> Suggested-by: Andrew Davis <afd@ti.com>
A review from Andrew would be helpful here.
> ---
> drivers/mfd/tps65219.c | 45 +++++++++++++++++++++++++++++++-----------
> 1 file changed, 34 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/mfd/tps65219.c b/drivers/mfd/tps65219.c
> index 0e402fda206b..c134f3f6e202 100644
> --- a/drivers/mfd/tps65219.c
> +++ b/drivers/mfd/tps65219.c
> @@ -25,25 +25,34 @@ static int tps65219_cold_reset(struct tps65219 *tps)
> TPS65219_MFP_COLD_RESET_I2C_CTRL_MASK);
> }
>
> -static int tps65219_restart(struct notifier_block *this,
> - unsigned long reboot_mode, void *cmd)
> +static int tps65219_soft_shutdown(struct tps65219 *tps)
> {
> - struct tps65219 *tps;
> + return regmap_update_bits(tps->regmap, TPS65219_REG_MFP_CTRL,
> + TPS65219_MFP_I2C_OFF_REQ_MASK,
> + TPS65219_MFP_I2C_OFF_REQ_MASK);
> +}
>
> - tps = container_of(this, struct tps65219, nb);
> +static int tps65219_power_off_handler(struct sys_off_data *data)
> +{
> + tps65219_soft_shutdown(data->cb_data);
> + return NOTIFY_DONE;
> +}
>
> +static int tps65219_restart(struct tps65219 *tps,
> + unsigned long reboot_mode)
> +{
> if (reboot_mode == REBOOT_WARM)
> tps65219_warm_reset(tps);
> else
> tps65219_cold_reset(tps);
> -
> return NOTIFY_DONE;
> }
>
> -static struct notifier_block pmic_rst_restart_nb = {
> - .notifier_call = tps65219_restart,
> - .priority = 200,
> -};
> +static int tps65219_restart_handler(struct sys_off_data *data)
> +{
> + tps65219_restart(data->cb_data, data->mode);
> + return NOTIFY_DONE;
> +}
>
> static const struct resource tps65219_pwrbutton_resources[] = {
> DEFINE_RES_IRQ_NAMED(TPS65219_INT_PB_FALLING_EDGE_DETECT, "falling"),
> @@ -269,13 +278,27 @@ static int tps65219_probe(struct i2c_client *client)
> }
> }
>
> - tps->nb = pmic_rst_restart_nb;
> - ret = register_restart_handler(&tps->nb);
> + ret = devm_register_sys_off_handler(tps->dev,
> + SYS_OFF_MODE_RESTART,
> + SYS_OFF_PRIO_HIGH,
> + tps65219_restart_handler,
> + tps);
> +
> if (ret) {
> dev_err(tps->dev, "cannot register restart handler, %d\n", ret);
> return ret;
> }
>
> + ret = devm_register_sys_off_handler(tps->dev,
> + SYS_OFF_MODE_POWER_OFF,
> + SYS_OFF_PRIO_DEFAULT,
> + tps65219_power_off_handler,
> + tps);
> + if (ret) {
> + dev_err(tps->dev, "failed to register sys-off handler: %d\n",
> + ret);
> + return ret;
> + }
> return 0;
> }
>
> --
> 2.34.1
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-03-01 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 14:01 [PATCH] mfd: tps65219: Add support for soft shutdown via sys-off API Jerome Neanne
2023-03-01 16:07 ` Lee Jones [this message]
2023-03-01 16:35 ` Andrew Davis
2023-03-03 15:12 ` jerome Neanne
2023-03-03 5:36 ` Vignesh Raghavendra
2023-03-03 9:48 ` jerome Neanne
2023-05-11 12:21 Jerome Neanne
2023-05-17 6:25 ` Tony Lindgren
2023-05-25 10:48 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/94Pew4vr6FROcI@google.com \
--to=lee@kernel.org \
--cc=afd@ti.com \
--cc=jneanne@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=nm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).