linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: Mark Jackson <mpfj@newflow.co.uk>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] Update Nanobone
Date: Wed, 9 Nov 2022 09:37:04 +0200	[thread overview]
Message-ID: <Y2tYoHSFdJzrp9MW@atomide.com> (raw)
In-Reply-To: <20221108194742.0d9340f4@aktux>

Hi,

* Andreas Kemnade <andreas@kemnade.info> [221108 18:38]:
> Hi,
> 
> On Tue, 8 Nov 2022 17:18:54 +0000
> Mark Jackson <mpfj@newflow.co.uk> wrote:
> 
> > Any update on this patch ?
> > Did it ever get through ?
> 
> it got probably caught in peoples "internal spam filter"
> reasons: 
>  - bad subject line 
>      look at  git log arch/arm/boot/dts/am335x-nano.dts for sane values
>  - bad recipient list
>      get_maintainer.pl is your friend
> 
> Hmm, you already have contributed long time ago, it looks better:
> Author: Mark Jackson <mpfj-list@newflow.co.uk>
> Date:   Thu Dec 15 10:52:13 2016 +0000
> 
>     ARM: dts: Update Nanobone dts file to add external FRAM chip
> 
> That looks ok. But maybe reread the documentation/SubmittingPatches again

Hmm yeah please use similar subject line with the prefix for the dts
changes.

Looking at the dts changes only, the changes for status = "okay" changes
should not be needed for devices enabled by default. Seems like the other
changes are for rs485, please describe why the changes are made in the
patch description.

The separate defconfig should not be needed. Please send any defconfig
changes to multi_v7_defconfig or omap2plu_defconfig as separate patches.

Note that you can run make savedefconfig first to produce a minimal diff.
Then if adding device drivers, please add them as loadable modules where
possible.

Regards,

Tony

  reply	other threads:[~2022-11-09  7:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04 14:39 [PATCH] Update Nanobone Mark Jackson
2022-11-08 17:18 ` Mark Jackson
2022-11-08 18:47   ` Andreas Kemnade
2022-11-09  7:37     ` Tony Lindgren [this message]
2022-11-09 14:44       ` Mark Jackson
2022-11-10  7:11         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2tYoHSFdJzrp9MW@atomide.com \
    --to=tony@atomide.com \
    --cc=andreas@kemnade.info \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mpfj@newflow.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).