Linux-OMAP Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] ARM: OMAP2+: Make symbol 'pdata_quirks_init_clocks' static
@ 2021-03-18 13:56 'w00385741
  2021-03-24 10:19 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: 'w00385741 @ 2021-03-18 13:56 UTC (permalink / raw)
  To: weiyongjun1, Tony Lindgren, Russell King
  Cc: linux-arm-kernel, linux-omap, kernel-janitors, Hulk Robot

From: Wei Yongjun <weiyongjun1@huawei.com>

The sparse tool complains as follows:

arch/arm/mach-omap2/pdata-quirks.c:578:1: warning:
 symbol 'pdata_quirks_init_clocks' was not declared. Should it be static?

This symbol is not used outside of pdata-quirks.c, so this
commit marks it static.

Fixes: a15de032a72d ("ARM: OMAP2+: Init both prm and prcm nodes early for clocks")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 arch/arm/mach-omap2/pdata-quirks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2/pdata-quirks.c
index 3405aa815a24..765809b214e7 100644
--- a/arch/arm/mach-omap2/pdata-quirks.c
+++ b/arch/arm/mach-omap2/pdata-quirks.c
@@ -574,7 +574,7 @@ static const char * const pdata_quirks_init_nodes[] = {
 	"prm",
 };
 
-void __init
+static void __init
 pdata_quirks_init_clocks(const struct of_device_id *omap_dt_match_table)
 {
 	struct device_node *np;


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] ARM: OMAP2+: Make symbol 'pdata_quirks_init_clocks' static
  2021-03-18 13:56 [PATCH -next] ARM: OMAP2+: Make symbol 'pdata_quirks_init_clocks' static 'w00385741
@ 2021-03-24 10:19 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2021-03-24 10:19 UTC (permalink / raw)
  To: 'w00385741
  Cc: Russell King, linux-arm-kernel, linux-omap, kernel-janitors, Hulk Robot

* 'w00385741 <weiyongjun1@huawei.com> [210318 15:49]:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> The sparse tool complains as follows:
> 
> arch/arm/mach-omap2/pdata-quirks.c:578:1: warning:
>  symbol 'pdata_quirks_init_clocks' was not declared. Should it be static?
> 
> This symbol is not used outside of pdata-quirks.c, so this
> commit marks it static.

Thanks applying into omap-for-v5.13/ti-sysc.

Regards,

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18 13:56 [PATCH -next] ARM: OMAP2+: Make symbol 'pdata_quirks_init_clocks' static 'w00385741
2021-03-24 10:19 ` Tony Lindgren

Linux-OMAP Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-omap/0 linux-omap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-omap linux-omap/ https://lore.kernel.org/linux-omap \
		linux-omap@vger.kernel.org
	public-inbox-index linux-omap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-omap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git