From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D51BC433DB for ; Wed, 24 Mar 2021 16:30:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DADB61A16 for ; Wed, 24 Mar 2021 16:30:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236128AbhCXQaB (ORCPT ); Wed, 24 Mar 2021 12:30:01 -0400 Received: from muru.com ([72.249.23.125]:46692 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235295AbhCXQ3j (ORCPT ); Wed, 24 Mar 2021 12:29:39 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id B8F0C8057; Wed, 24 Mar 2021 16:30:34 +0000 (UTC) Date: Wed, 24 Mar 2021 18:29:34 +0200 From: Tony Lindgren To: Sebastian Reichel Cc: Carl Philipp Klemm , devicetree@vger.kernel.org, linux-omap@vger.kernel.org, Arthur Demchenkov , Merlijn Wajer , Pavel Machek Subject: Re: [PATCH 2/5] ARM: dts: add battery phandle to cpcap_charger Message-ID: References: <20210117224502.0f9a0e80dfd4841ad26a9914@uvos.xyz> <20210324154219.m4xwm3bayzlele6e@earth.universe> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210324154219.m4xwm3bayzlele6e@earth.universe> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi, * Sebastian Reichel [210324 15:43]: > On Wed, Mar 24, 2021 at 01:54:02PM +0200, Tony Lindgren wrote: > > * Carl Philipp Klemm [210117 23:45]: > > > --- a/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi > > > +++ b/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi > > > @@ -61,6 +61,7 @@ &cpcap_adc 2 &cpcap_adc 5 > > > io-channel-names = "battdetb", "battp", > > > "vbus", "chg_isense", > > > "batti"; > > > + battery = <&cpcap_battery>; > > > }; > > > > This seems like good standard stuff to have, picking up this patch into > > omap-for-v5.13/dt thanks. > > This was btw. one of the patches that finally made me convert all > the binding files to YAML. This patch will now result in warning > being printed when you run 'make dtbs_check', since the binding has > not been updated. > > I did not yet have time to review the patchset properly, so I have > not yet replied (partely, because of being busy with the YAML > stuff). > > I think the patch is also wrong, since the information is already > described in DT - just the other way around: The battery references > the charger. This provides all required information to the kernel > for a 1:1 link. OK, I will drop this patch. Regards, Tony