* [PATCH] ARM: OMAP1: fix incorrect kernel-doc comment syntax in file
@ 2021-03-30 20:53 Aditya Srivastava
2021-03-30 21:04 ` Randy Dunlap
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Aditya Srivastava @ 2021-03-30 20:53 UTC (permalink / raw)
To: linux-kernel
Cc: yashsri421, lukas.bulwahn, rdunlap, aaro.koskinen, tony, linux,
linux-kernel-mentees, linux-doc, linux-arm-kernel, linux-omap
The opening comment mark '/**' is used for highlighting the beginning of
kernel-doc comments.
The header for arch/arm/mach-omap1/timer.c follows this syntax, but the
content inside does not comply with kernel-doc.
This line was probably not meant for kernel-doc parsing, but is parsed
due to the presence of kernel-doc like comment syntax(i.e, '/**'), which
causes unexpected warning from kernel-doc:
"warning: expecting prototype for OMAP1 Dual(). Prototype was for OMAP1610_GPTIMER1_BASE() instead"
Provide a simple fix by replacing this occurrence with general comment
format, i.e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
---
* Applies perfectly on next-20210326
arch/arm/mach-omap1/timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap1/timer.c b/arch/arm/mach-omap1/timer.c
index 97fc2096b970..0411d5508d63 100644
--- a/arch/arm/mach-omap1/timer.c
+++ b/arch/arm/mach-omap1/timer.c
@@ -1,4 +1,4 @@
-/**
+/*
* OMAP1 Dual-Mode Timers - platform device registration
*
* Contains first level initialization routines which internally
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP1: fix incorrect kernel-doc comment syntax in file
2021-03-30 20:53 [PATCH] ARM: OMAP1: fix incorrect kernel-doc comment syntax in file Aditya Srivastava
@ 2021-03-30 21:04 ` Randy Dunlap
2021-03-30 21:41 ` Aaro Koskinen
2021-03-31 6:07 ` Tony Lindgren
2 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2021-03-30 21:04 UTC (permalink / raw)
To: Aditya Srivastava, linux-kernel
Cc: lukas.bulwahn, aaro.koskinen, tony, linux, linux-kernel-mentees,
linux-doc, linux-arm-kernel, linux-omap
On 3/30/21 1:53 PM, Aditya Srivastava wrote:
> The opening comment mark '/**' is used for highlighting the beginning of
> kernel-doc comments.
> The header for arch/arm/mach-omap1/timer.c follows this syntax, but the
> content inside does not comply with kernel-doc.
>
> This line was probably not meant for kernel-doc parsing, but is parsed
> due to the presence of kernel-doc like comment syntax(i.e, '/**'), which
> causes unexpected warning from kernel-doc:
> "warning: expecting prototype for OMAP1 Dual(). Prototype was for OMAP1610_GPTIMER1_BASE() instead"
>
> Provide a simple fix by replacing this occurrence with general comment
> format, i.e. '/*', to prevent kernel-doc from parsing it.
>
> Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> * Applies perfectly on next-20210326
>
> arch/arm/mach-omap1/timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap1/timer.c b/arch/arm/mach-omap1/timer.c
> index 97fc2096b970..0411d5508d63 100644
> --- a/arch/arm/mach-omap1/timer.c
> +++ b/arch/arm/mach-omap1/timer.c
> @@ -1,4 +1,4 @@
> -/**
> +/*
> * OMAP1 Dual-Mode Timers - platform device registration
> *
> * Contains first level initialization routines which internally
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP1: fix incorrect kernel-doc comment syntax in file
2021-03-30 20:53 [PATCH] ARM: OMAP1: fix incorrect kernel-doc comment syntax in file Aditya Srivastava
2021-03-30 21:04 ` Randy Dunlap
@ 2021-03-30 21:41 ` Aaro Koskinen
2021-03-31 6:07 ` Tony Lindgren
2 siblings, 0 replies; 4+ messages in thread
From: Aaro Koskinen @ 2021-03-30 21:41 UTC (permalink / raw)
To: Aditya Srivastava
Cc: linux-kernel, lukas.bulwahn, rdunlap, tony, linux,
linux-kernel-mentees, linux-doc, linux-arm-kernel, linux-omap
Hi,
On Wed, Mar 31, 2021 at 02:23:30AM +0530, Aditya Srivastava wrote:
> The opening comment mark '/**' is used for highlighting the beginning of
> kernel-doc comments.
> The header for arch/arm/mach-omap1/timer.c follows this syntax, but the
> content inside does not comply with kernel-doc.
>
> This line was probably not meant for kernel-doc parsing, but is parsed
> due to the presence of kernel-doc like comment syntax(i.e, '/**'), which
> causes unexpected warning from kernel-doc:
> "warning: expecting prototype for OMAP1 Dual(). Prototype was for OMAP1610_GPTIMER1_BASE() instead"
>
> Provide a simple fix by replacing this occurrence with general comment
> format, i.e. '/*', to prevent kernel-doc from parsing it.
>
> Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
A.
> ---
> * Applies perfectly on next-20210326
>
> arch/arm/mach-omap1/timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap1/timer.c b/arch/arm/mach-omap1/timer.c
> index 97fc2096b970..0411d5508d63 100644
> --- a/arch/arm/mach-omap1/timer.c
> +++ b/arch/arm/mach-omap1/timer.c
> @@ -1,4 +1,4 @@
> -/**
> +/*
> * OMAP1 Dual-Mode Timers - platform device registration
> *
> * Contains first level initialization routines which internally
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP1: fix incorrect kernel-doc comment syntax in file
2021-03-30 20:53 [PATCH] ARM: OMAP1: fix incorrect kernel-doc comment syntax in file Aditya Srivastava
2021-03-30 21:04 ` Randy Dunlap
2021-03-30 21:41 ` Aaro Koskinen
@ 2021-03-31 6:07 ` Tony Lindgren
2 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2021-03-31 6:07 UTC (permalink / raw)
To: Aditya Srivastava
Cc: linux-kernel, lukas.bulwahn, rdunlap, aaro.koskinen, linux,
linux-kernel-mentees, linux-doc, linux-arm-kernel, linux-omap
* Aditya Srivastava <yashsri421@gmail.com> [210330 23:54]:
> The opening comment mark '/**' is used for highlighting the beginning of
> kernel-doc comments.
> The header for arch/arm/mach-omap1/timer.c follows this syntax, but the
> content inside does not comply with kernel-doc.
>
> This line was probably not meant for kernel-doc parsing, but is parsed
> due to the presence of kernel-doc like comment syntax(i.e, '/**'), which
> causes unexpected warning from kernel-doc:
> "warning: expecting prototype for OMAP1 Dual(). Prototype was for OMAP1610_GPTIMER1_BASE() instead"
>
> Provide a simple fix by replacing this occurrence with general comment
> format, i.e. '/*', to prevent kernel-doc from parsing it.
Thanks applying into omap-for-v5.13/soc.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-31 6:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-30 20:53 [PATCH] ARM: OMAP1: fix incorrect kernel-doc comment syntax in file Aditya Srivastava
2021-03-30 21:04 ` Randy Dunlap
2021-03-30 21:41 ` Aaro Koskinen
2021-03-31 6:07 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).