From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 446C4C433ED for ; Mon, 19 Apr 2021 04:58:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13EB461151 for ; Mon, 19 Apr 2021 04:58:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230114AbhDSE65 (ORCPT ); Mon, 19 Apr 2021 00:58:57 -0400 Received: from gw.atmark-techno.com ([13.115.124.170]:56258 "EHLO gw.atmark-techno.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbhDSE64 (ORCPT ); Mon, 19 Apr 2021 00:58:56 -0400 X-Greylist: delayed 534 seconds by postgrey-1.27 at vger.kernel.org; Mon, 19 Apr 2021 00:58:56 EDT Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) by gw.atmark-techno.com (Postfix) with ESMTPS id 2BDF5804D0 for ; Mon, 19 Apr 2021 13:49:33 +0900 (JST) Received: by mail-oo1-f71.google.com with SMTP id p1-20020a4aa2410000b02901b73bdc1ce3so5480839ool.10 for ; Sun, 18 Apr 2021 21:49:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nwmKkdj5vxFBpFK3bj8w7Gz2YNFOXfPhegLyPurLzW0=; b=R5K7F0UlAdF55NGWiPov2jnEAPkTSGCHP5aZj6Wl8la6w9OGzFUw+4gMYOfWNi/Ucr Si0w9WhqpfjP9n/PcXyppD0xJCK4FXny1OpCMyuektHQo+8dn7fmpFuLL69IXNQj1lt+ hrHu0xPdWU7DSL47rOh7IGmfpVmaNcPN+/FapogaJWxpZgTY24C+QOtXjR3M3DP6dmYb HVh2R2beYdhIlX01uCIivyq6YDeZqIQ5nB1kgxESwW3zjDu4JLrVYsOrCNMZyPgEO1+G a2M6XGS68sDfRX8DiLXp0WfOOOGn8zGYQoqfstRtLL5LCo1rnYp72t+39Cs8qhUZ7320 Jrsw== X-Gm-Message-State: AOAM530AD+kLy9fgaOVBC5JM0LzGbFM1Gwgj8O8l/Oomwxz4n6JGnOgd /BLqaiPrp8vquUmyivBjXYVKN1kCyWmPRUoc75t/tRxmndUtiLwspi0TESVHFVHpv2OEjzxDEIM oeGyXtnO7bJxRXGiAGc4Rvtjpmg== X-Received: by 2002:a17:90a:430e:: with SMTP id q14mr10145514pjg.189.1618807761158; Sun, 18 Apr 2021 21:49:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxUh9TJ2x/K//IB2lTaeXhs2rGXIpLK5cuzzNIi1YdNWpQlLZsRv610IvzYjHsCM08ZYf1MA== X-Received: by 2002:a17:90a:430e:: with SMTP id q14mr10145444pjg.189.1618807760853; Sun, 18 Apr 2021 21:49:20 -0700 (PDT) Received: from pc-0115 (117.209.187.35.bc.googleusercontent.com. [35.187.209.117]) by smtp.gmail.com with ESMTPSA id l22sm13247239pjc.13.2021.04.18.21.49.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Apr 2021 21:49:20 -0700 (PDT) Received: from martinet by pc-0115 with local (Exim 4.94) (envelope-from ) id 1lYLqX-0016Kg-U8; Mon, 19 Apr 2021 13:49:17 +0900 Date: Mon, 19 Apr 2021 13:49:07 +0900 From: Dominique MARTINET To: "Alice Guo (OSS)" Cc: gregkh@linuxfoundation.org, rafael@kernel.org, horia.geanta@nxp.com, aymen.sghaier@nxp.com, herbert@gondor.apana.org.au, davem@davemloft.net, tony@atomide.com, geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, vkoul@kernel.org, peter.ujfalusi@gmail.com, a.hajda@samsung.com, narmstrong@baylibre.com, robert.foss@linaro.org, airlied@linux.ie, daniel@ffwll.ch, khilman@baylibre.com, tomba@kernel.org, jyri.sarha@iki.fi, joro@8bytes.org, will@kernel.org, mchehab@kernel.org, ulf.hansson@linaro.org, adrian.hunter@intel.com, kishon@ti.com, kuba@kernel.org, linus.walleij@linaro.org, Roy.Pledge@nxp.com, leoyang.li@nxp.com, ssantosh@kernel.org, matthias.bgg@gmail.com, edubezval@gmail.com, j-keerthy@ti.com, balbi@kernel.org, linux@prisktech.co.nz, stern@rowland.harvard.edu, wim@linux-watchdog.org, linux@roeck-us.net, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-staging@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER Message-ID: References: <20210419042722.27554-1-alice.guo@oss.nxp.com> <20210419042722.27554-2-alice.guo@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210419042722.27554-2-alice.guo@oss.nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org First comment overall for the whole serie: Since it is the solution I had suggested when I reported the problem[1] I have no qualm on the approach, comments for individual patches follow. [1] http://lore.kernel.org/r/YGGZJjAxA1IO+/VU@atmark-techno.com Alice Guo (OSS) wrote on Mon, Apr 19, 2021 at 12:27:20PM +0800: > From: Alice Guo > > In i.MX8M boards, the registration of SoC device is later than caam > driver which needs it. Caam driver needs soc_device_match to provide > -EPROBE_DEFER when no SoC device is registered and no > early_soc_dev_attr. This patch should be last in the set: you can't have soc_device_match return an error before its callers handle it. > Signed-off-by: Alice Guo As the one who reported the problem I would have been appreciated being at least added to Ccs... I only happened to notice you posted this by chance. There is also not a single Fixes tag -- I believe this commit should have Fixes: 7d981405d0fd ("soc: imx8m: change to use platform driver") but I'm not sure how such tags should be handled in case of multiple patches fixing something. -- Dominique