From: Tony Lindgren <tony@atomide.com>
To: Dario Binacchi <dariobin@libero.it>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bin Meng <bmeng.cn@gmail.com>,
Frank Rowand <frowand.list@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-clk <linux-clk@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 0/2] fdt: translate address if #size-cells = <0>
Date: Sat, 17 Apr 2021 11:37:01 +0300 [thread overview]
Message-ID: <YHqeLe/mqzu5OZpg@atomide.com> (raw)
In-Reply-To: <1627640615.696710.1618432773724@mail1.libero.it>
* Dario Binacchi <dariobin@libero.it> [210414 20:40]:
> > Il 12/04/2021 09:41 Tero Kristo <kristo@kernel.org> ha scritto:
> > The change on the DT itself would be pretty large, removing all clock
> > nodes and modifying any existing handles towards the clock nodes, and
> > this would impact all OMAP architectures.
> >
> > Anyways, it is mostly up-to Tony how he wants to see the DT change, as
> > he is the maintainer for the OMAP family DT data.
While I think all the clocks should use a similar binding to the clkctrl
binding, I don't know if it makes sense to start changing things around
at such a large scale.
Certainly if somebody does the patches and they can be tested to not cause
regressions, sure why not :)
> > I am just raising the opinion here that from kernel point of view,
> > adding the missing size cells seems unnecessary, and I can't see why
> > u-boot can't be changed to support the existing broken DT. It is broken
> > now, and it will be broken with the addition of the size cells in place,
> > and the actual "neat" end result would be to get rid of the clock nodes
> > completely.
>
> I'll fix U-boot.
> Thanks for your explanations.
> Hope for SSC patch review from you and/or some TI MAINTAINER.
Best to fix the issues first, then make any clean-up patches a separate
series.
Regards,
Tony
prev parent reply other threads:[~2021-04-17 8:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 19:20 [PATCH 0/2] fdt: translate address if #size-cells = <0> Dario Binacchi
2021-04-02 19:20 ` [PATCH 2/2] clk: ti: get register address from device tree Dario Binacchi
2021-04-06 6:02 ` Tero Kristo
2021-04-06 14:06 ` [PATCH 0/2] fdt: translate address if #size-cells = <0> Rob Herring
2021-04-06 22:02 ` Dario Binacchi
2021-04-07 1:16 ` Rob Herring
2021-04-07 7:07 ` Dario Binacchi
2021-04-07 12:52 ` Rob Herring
2021-04-07 13:21 ` Tero Kristo
2021-04-08 20:24 ` Dario Binacchi
2021-04-09 10:32 ` Tero Kristo
2021-04-11 19:30 ` Dario Binacchi
2021-04-12 7:41 ` Tero Kristo
2021-04-14 20:39 ` Dario Binacchi
2021-04-17 8:37 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHqeLe/mqzu5OZpg@atomide.com \
--to=tony@atomide.com \
--cc=bmeng.cn@gmail.com \
--cc=dariobin@libero.it \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kristo@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).