linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yuehaibing <yuehaibing@huawei.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <rogerq@ti.com>, <tony@atomide.com>, <linux-omap@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] memory: omap-gpmc: Fix -Wunused-function warnings
Date: Tue, 1 Sep 2020 14:58:00 +0800	[thread overview]
Message-ID: <a8b622ac-eb41-1371-9514-f4a31dc6589d@huawei.com> (raw)
In-Reply-To: <20200901065241.GA7720@kozik-lap>

On 2020/9/1 14:52, Krzysztof Kozlowski wrote:
> On Tue, Sep 01, 2020 at 11:56:42AM +0800, YueHaibing wrote:
>> drivers/memory/omap-gpmc.c:987:12: warning: ‘gpmc_cs_remap’ defined but not used [-Wunused-function]
>>  static int gpmc_cs_remap(int cs, u32 base)
>>             ^~~~~~~~~~~~~
>> drivers/memory/omap-gpmc.c:926:20: warning: ‘gpmc_cs_get_name’ defined but not used [-Wunused-function]
>>  static const char *gpmc_cs_get_name(int cs)
>>                     ^~~~~~~~~~~~~~~~
>> drivers/memory/omap-gpmc.c:919:13: warning: ‘gpmc_cs_set_name’ defined but not used [-Wunused-function]
>>  static void gpmc_cs_set_name(int cs, const char *name)
>>              ^~~~~~~~~~~~~~~~
>> Make them as  __maybe_unused to fix this.
> 
> Hi,
> 
> Do you know what configuration triggers these warnings? What has to be
> disabled (e.g. CONFIG_OF)? Such information is useful in the commit
> message.

Yes, this is triggered by disable CONFIG_OF, I will update the commit log.
> 
> Best regards,
> Krzysztof
> 
> .
> 


  reply	other threads:[~2020-09-01  6:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01  3:56 [PATCH -next] memory: omap-gpmc: Fix -Wunused-function warnings YueHaibing
2020-09-01  6:52 ` Krzysztof Kozlowski
2020-09-01  6:58   ` Yuehaibing [this message]
2020-09-01  7:07 ` YueHaibing
2020-09-01  7:11   ` Yuehaibing
2020-09-01  7:09 ` [PATCH v2 " YueHaibing
2020-09-01 11:14   ` Roger Quadros
2020-09-01 11:28 ` [PATCH v3 " YueHaibing
2020-09-01 12:11   ` Roger Quadros
2020-09-02 15:29   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8b622ac-eb41-1371-9514-f4a31dc6589d@huawei.com \
    --to=yuehaibing@huawei.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rogerq@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).