From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84846C433DB for ; Wed, 10 Feb 2021 13:15:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F80464E35 for ; Wed, 10 Feb 2021 13:15:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230419AbhBJNPn (ORCPT ); Wed, 10 Feb 2021 08:15:43 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:49754 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229862AbhBJNPl (ORCPT ); Wed, 10 Feb 2021 08:15:41 -0500 X-IronPort-AV: E=Sophos;i="5.81,168,1610406000"; d="scan'208";a="492258135" Received: from 173.121.68.85.rev.sfr.net (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Feb 2021 14:14:54 +0100 Date: Wed, 10 Feb 2021 14:14:54 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Daniel Vetter cc: Lee Jones , Julia Lawall , Daniel Thompson , linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Jingoo Han , Sascha Hauer , kernel-janitors@vger.kernel.org, Michal Simek , dri-devel@lists.freedesktop.org, Bjorn Andersson , Andy Gross , NXP Linux Team , linux-fbdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Shawn Guo , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] video: use getter/setter functions In-Reply-To: Message-ID: References: <20210209211325.1261842-1-Julia.Lawall@inria.fr> <20210210082341.GH220368@dell> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-2043823747-1612962895=:2881" Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-2043823747-1612962895=:2881 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Wed, 10 Feb 2021, Daniel Vetter wrote: > On Wed, Feb 10, 2021 at 08:23:41AM +0000, Lee Jones wrote: > > On Tue, 09 Feb 2021, Julia Lawall wrote: > > > > > Use getter and setter functions, for platform_device structures and a > > > spi_device structure. > > > > > > Signed-off-by: Julia Lawall > > > > > > --- > > > drivers/video/backlight/qcom-wled.c | 2 +- > > > > This patch is fine. > > > > Could you please split it out and submit it separately though please. > > Or just apply the entire patch through backlight tree, there's nothing > going on in fbdev anyway I think. I was indeed not sure how much to split this up. If it is desired to split it more, I can do that. julia > > Acked-by: Daniel Vetter > > > > > > drivers/video/fbdev/amifb.c | 4 ++-- > > > drivers/video/fbdev/da8xx-fb.c | 4 ++-- > > > drivers/video/fbdev/imxfb.c | 2 +- > > > drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c | 6 +++--- > > > drivers/video/fbdev/omap2/omapfb/dss/dpi.c | 4 ++-- > > > drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++-- > > > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 2 +- > > > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c | 2 +- > > > drivers/video/fbdev/xilinxfb.c | 2 +- > > > 10 files changed, 16 insertions(+), 16 deletions(-) > > > > ...] > > > > > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c > > > index 3bc7800eb0a9..091f07e7c145 100644 > > > --- a/drivers/video/backlight/qcom-wled.c > > > +++ b/drivers/video/backlight/qcom-wled.c > > > @@ -1692,7 +1692,7 @@ static int wled_probe(struct platform_device *pdev) > > > > > > static int wled_remove(struct platform_device *pdev) > > > { > > > - struct wled *wled = dev_get_drvdata(&pdev->dev); > > > + struct wled *wled = platform_get_drvdata(pdev); > > > > > > mutex_destroy(&wled->lock); > > > cancel_delayed_work_sync(&wled->ovp_work); > > > > For my own reference (apply this as-is to your sign-off block): > > > > Acked-for-Backlight-by: Lee Jones > > > > -- > > Lee Jones [李琼斯] > > Senior Technical Lead - Developer Services > > Linaro.org │ Open source software for Arm SoCs > > Follow Linaro: Facebook | Twitter | Blog > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch > --8323329-2043823747-1612962895=:2881--