From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Networking <netdev@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
"David S. Miller" <davem@davemloft.net>,
Russell King <linux@armlinux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Clay McClure <clay@daemons.net>, Dan Murphy <dmurphy@ti.com>,
Murali Karicheri <m-karicheri2@ti.com>
Subject: Re: [PATCH net v3] net: ethernet: ti: fix build and remove TI_CPTS_MOD workaround
Date: Tue, 12 May 2020 11:35:40 +0300 [thread overview]
Message-ID: <b0e2bd21-f670-f05a-6e23-4c6c75a94868@ti.com> (raw)
In-Reply-To: <CAK8P3a0-6vRpHJugnUFhNNAALmqx4CUW9ffTOojxu5a80tAQTw@mail.gmail.com>
Hi Arnd,
On 08/05/2020 14:25, Arnd Bergmann wrote:
> On Fri, May 8, 2020 at 1:14 PM Grygorii Strashko
> <grygorii.strashko@ti.com> wrote:
>> On 08/05/2020 13:10, Arnd Bergmann wrote:
>>> On Fri, May 8, 2020 at 11:59 AM Grygorii Strashko
>
>>>> That's because TI_CPTS_MOD (which is the symbol gating the _compilation_ of
>>>> cpts.c) now depends on PTP_1588_CLOCK, and so is not enabled in these
>>>> configurations, but TI_CPTS (which is the symbol gating _calls_ to the cpts
>>>> functions) _is_ enabled. So we end up compiling calls to functions that
>>>> don't exist, resulting in the linker errors.
>>>>
>>>> This patch fixes build errors and restores previous behavior by:
>>>> - ensure PTP_1588_CLOCK=y in TI specific configs and CPTS will be built
>>>> - use IS_REACHABLE(CONFIG_TI_CPTS) in code instead of IS_ENABLED()
>>>
>>> I don't understand what IS_REACHABLE() is needed for once all the other
>>> changes are in place. I'd hope we can avoid that. Do you still see
>>> failures without
>>> that or is it just a precaution. I can do some randconfig testing on your patch
>>> to see what else might be needed to avoid IS_REACHABLE().
>>
>> I've not changed this part of original patch, but seems you're right.
>>
>> I can drop it and resend, but, unfortunately, i do not have time today for full build testing.
>
> I have applied to patch locally to my randconfig tree, with the IS_REACHABLE()
> changes taken out.
>
What will be the conclusion here?
--
Best regards,
grygorii
next prev parent reply other threads:[~2020-05-12 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 9:59 [PATCH net v3] net: ethernet: ti: fix build and remove TI_CPTS_MOD workaround Grygorii Strashko
2020-05-08 10:10 ` Arnd Bergmann
2020-05-08 11:14 ` Grygorii Strashko
2020-05-08 11:25 ` Arnd Bergmann
2020-05-12 8:35 ` Grygorii Strashko [this message]
2020-05-12 8:53 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0e2bd21-f670-f05a-6e23-4c6c75a94868@ti.com \
--to=grygorii.strashko@ti.com \
--cc=arnd@arndb.de \
--cc=clay@daemons.net \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).