From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: Alexander Dahl <post@lespocky.de>, Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org> Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Alexander Dahl <ada@thorsis.com>, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Jacek Anaszewski <jacek.anaszewski@gmail.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-leds@vger.kernel.org Subject: Re: [Linux-stm32] [PATCH v7 10/12] ARM: dts: stm32: Fix schema warnings for pwm-leds Date: Tue, 27 Oct 2020 08:03:40 +0100 [thread overview] Message-ID: <b387bda8-3643-1d27-4996-2aa4dc94d69f@pengutronix.de> (raw) In-Reply-To: <20201005203451.9985-11-post@lespocky.de> Hello Alexander, On 10/5/20 10:34 PM, Alexander Dahl wrote: > The node names for devices using the pwm-leds driver follow a certain > naming scheme (now). Parent node name is not enforced, but recommended > by DT project. > > DTC arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml > CHECK arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml > /home/alex/build/linux/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml: led-rgb: 'led-blue', 'led-green', 'led-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml > > Signed-off-by: Alexander Dahl <post@lespocky.de> Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de> But got two questions below: > --- > > Notes: > v6 -> v7: > * split up patch (one per sub arch) > * added actual warnings to commit message > > arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts > index 5700e6b700d3..25d548cb975b 100644 > --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts > +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts > @@ -36,34 +36,34 @@ > stdout-path = &uart4; > }; > > - led-act { > + led-controller-1 { > compatible = "gpio-leds"; > > - led-green { > + led-1 { > label = "mc1:green:act"; > gpios = <&gpioa 13 GPIO_ACTIVE_LOW>; > linux,default-trigger = "heartbeat"; > }; > }; > > - led-rgb { > + led-controller-2 { Is a single RGB LED really a controller? > compatible = "pwm-leds"; > > - led-red { > + led-2 { Shouldn't this have been led-1 as well or is the numbering "global" ? > label = "mc1:red:rgb"; > pwms = <&leds_pwm 1 1000000 0>; > max-brightness = <255>; > active-low; > }; > > - led-green { > + led-3 { > label = "mc1:green:rgb"; > pwms = <&leds_pwm 2 1000000 0>; > max-brightness = <255>; > active-low; > }; > > - led-blue { > + led-4 { > label = "mc1:blue:rgb"; > pwms = <&leds_pwm 3 1000000 0>; > max-brightness = <255>; > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2020-10-27 7:03 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl 2020-10-05 20:34 ` [PATCH v7 01/12] leds: pwm: Remove platform_data support Alexander Dahl 2020-10-07 10:03 ` Pavel Machek 2020-10-05 20:34 ` [PATCH v7 02/12] dt-bindings: leds: Convert pwm to yaml Alexander Dahl 2020-10-07 10:02 ` Pavel Machek 2020-10-07 10:03 ` Krzysztof Kozlowski 2020-10-28 20:39 ` Alexander Dahl 2020-10-29 13:46 ` Russell King - ARM Linux admin 2020-11-25 11:08 ` Pavel Machek 2020-10-05 20:34 ` [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl 2020-10-06 2:17 ` Jeff LaBundy 2020-10-06 6:34 ` Alexander Dahl 2020-10-06 22:27 ` Rob Herring 2020-10-06 22:28 ` Rob Herring 2020-10-07 10:03 ` Pavel Machek 2020-10-07 10:08 ` Alexander Dahl 2020-10-08 7:33 ` Lee Jones 2020-10-08 7:50 ` Pavel Machek 2020-10-05 20:34 ` [PATCH v7 04/12] ARM: dts: at91: smartkiz: Reference led node directly Alexander Dahl 2020-10-05 20:34 ` [PATCH v7 05/12] ARM: dts: at91: Fix schema warnings for pwm-leds Alexander Dahl 2020-10-05 20:34 ` [PATCH v7 06/12] ARM: dts: berlin: " Alexander Dahl 2020-10-05 20:34 ` [PATCH v7 07/12] ARM: dts: exynos: " Alexander Dahl 2020-10-07 6:25 ` Krzysztof Kozlowski 2020-10-26 18:45 ` Krzysztof Kozlowski 2020-10-05 20:34 ` [PATCH v7 08/12] ARM: dts: imx: " Alexander Dahl 2020-10-30 7:46 ` Shawn Guo 2020-10-05 20:34 ` [PATCH v7 09/12] ARM: dts: omap: " Alexander Dahl 2020-11-10 13:25 ` Tony Lindgren 2020-10-05 20:34 ` [PATCH v7 10/12] ARM: dts: stm32: " Alexander Dahl 2020-10-27 7:03 ` Ahmad Fatoum [this message] 2020-10-27 10:05 ` [Linux-stm32] " Alexander Dahl 2020-10-27 10:58 ` Ahmad Fatoum 2020-10-28 7:34 ` Alexander Dahl 2020-11-02 10:47 ` Ahmad Fatoum 2020-10-05 20:34 ` [PATCH v7 11/12] arm64: dts: meson: " Alexander Dahl 2020-10-05 20:34 ` [PATCH v7 12/12] MIPS: DTS: img: " Alexander Dahl 2020-10-28 18:56 ` [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexandre Belloni 2020-10-28 19:21 ` Alexandre Belloni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b387bda8-3643-1d27-4996-2aa4dc94d69f@pengutronix.de \ --to=a.fatoum@pengutronix.de \ --cc=ada@thorsis.com \ --cc=devicetree@vger.kernel.org \ --cc=dmurphy@ti.com \ --cc=jacek.anaszewski@gmail.com \ --cc=linux-amlogic@lists.infradead.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=pavel@ucw.cz \ --cc=post@lespocky.de \ --cc=robh+dt@kernel.org \ --subject='Re: [Linux-stm32] [PATCH v7 10/12] ARM: dts: stm32: Fix schema warnings for pwm-leds' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).