Re: [PATCH] clk/ti/adpll: Add a NULL check for devm_kasprintf()

From: Joe Perches <joe@perches.com>
To: Xu Wang <vulab@iscas.ac.cn>,
	t-kristo@ti.com, mturquette@baylibre.com, sboyd@kernel.org,
	linux-omap@vger.kernel.org, linux-clk@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk/ti/adpll: Add a NULL check for devm_kasprintf()
Date: Sun, 17 May 2020 20:55:30 -0700	[thread overview]
Message-ID: <b8a08623cc0f858e0f961240a0cf610d32c6816d.camel@perches.com> (raw)
In-Reply-To: <1589773618-3658-1-git-send-email-vulab@iscas.ac.cn>

On Mon, 2020-05-18 at 03:46 +0000, Xu Wang wrote:
> devm_kasprintf() may fail, so we should better add a NULL check
> and propagate an error on failure.

You didn't compile this.

All the return values of this function are already checked.

> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
>  drivers/clk/ti/adpll.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c
> index bb2f283..f18a672 100644
> --- a/drivers/clk/ti/adpll.c
> +++ b/drivers/clk/ti/adpll.c
> @@ -196,6 +196,8 @@ static const char *ti_adpll_clk_get_name(struct ti_adpll_data *d,
>  	} else {
>  		name = devm_kasprintf(d->dev, GFP_KERNEL, "%08lx.adpll.%s",
>  				      d->pa, postfix);
> +		if (!name)
> +			return -ENOMEM;
>  	}
>  
>  	return name;