From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8950CC433E0 for ; Fri, 12 Feb 2021 14:33:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 471F864E57 for ; Fri, 12 Feb 2021 14:33:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229713AbhBLOdn (ORCPT ); Fri, 12 Feb 2021 09:33:43 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:36376 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229647AbhBLOdl (ORCPT ); Fri, 12 Feb 2021 09:33:41 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 11CEVf9t111660; Fri, 12 Feb 2021 08:31:41 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1613140301; bh=lUakNV+CV5NffMQmGC2Drd4lNwe79cgtFz1V4jCRJcY=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=lbseuewDdWlwxmebUNQ0jeNXKuGvUuIfQVSJjNLEKm1S8j+KqXF7lDUpoaMmbawQt rkyu1MpMhaWm3RagWE/UhEIr4fK9IH6SlrSTnPvJylIoigO+WYMygLn6vOTTVByei5 Lt3+0OIbkUVogWqSTMckQZguGd7RM9DKNpY34SXE= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 11CEVfNa091029 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 12 Feb 2021 08:31:41 -0600 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 12 Feb 2021 08:31:41 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 12 Feb 2021 08:31:41 -0600 Received: from [10.250.234.120] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 11CEVYtG076171; Fri, 12 Feb 2021 08:31:35 -0600 Subject: Re: [PATCH v4 net-next 0/9] Cleanup in brport flags switchdev offload for DSA To: Grygorii Strashko , Vladimir Oltean , Jakub Kicinski , "David S. Miller" CC: Andrew Lunn , Vivien Didelot , Florian Fainelli , , , , Roopa Prabhu , Nikolay Aleksandrov , Jiri Pirko , Ido Schimmel , Claudiu Manoil , Alexandre Belloni , , Vadym Kochan , Taras Chornyi , Ioana Ciornei , Ivan Vecera , References: <20210212010531.2722925-1-olteanv@gmail.com> <97ae293a-f59d-cc7c-21a6-f83880c69c71@ti.com> From: Vignesh Raghavendra Message-ID: Date: Fri, 12 Feb 2021 20:01:33 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <97ae293a-f59d-cc7c-21a6-f83880c69c71@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Vladimir, On 2/12/21 7:47 PM, Grygorii Strashko wrote: > > > On 12/02/2021 03:05, Vladimir Oltean wrote: >> From: Vladimir Oltean [...] > > Sorry, but we seems just added more work for you. > https://lore.kernel.org/patchwork/cover/1379380/ > Could you squash these when you post new version: Sorry for not noticing earlier. -- >8 -- >From 69f3a1ff1ea0777f5deceefdb0e79ce625e6488a Mon Sep 17 00:00:00 2001 From: Vignesh Raghavendra Date: Fri, 12 Feb 2021 19:34:46 +0530 Subject: [PATCH 1/2] fixup! net: switchdev: propagate extack to port attributes --- drivers/net/ethernet/ti/am65-cpsw-switchdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/am65-cpsw-switchdev.c b/drivers/net/ethernet/ti/am65-cpsw-switchdev.c index 1067e7772dbf..314825acf0a0 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-switchdev.c +++ b/drivers/net/ethernet/ti/am65-cpsw-switchdev.c @@ -81,7 +81,8 @@ static int am65_cpsw_port_attr_br_flags_pre_set(struct net_device *netdev, } static int am65_cpsw_port_attr_set(struct net_device *ndev, - const struct switchdev_attr *attr) + const struct switchdev_attr *attr, + struct netlink_ext_ack *extack) { struct am65_cpsw_port *port = am65_ndev_to_port(ndev); int ret; -- >8 -- >From 7d7fdb79a8b255a1e9fe5d205b0ff1824a16ce56 Mon Sep 17 00:00:00 2001 From: Vignesh Raghavendra Date: Fri, 12 Feb 2021 19:40:48 +0530 Subject: [PATCH 2/2] fixup! net: switchdev: pass flags and mask to both {PRE_,}BRIDGE_FLAGS attributes --- drivers/net/ethernet/ti/am65-cpsw-switchdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/ti/am65-cpsw-switchdev.c b/drivers/net/ethernet/ti/am65-cpsw-switchdev.c index 314825acf0a0..03c7a012f5c5 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-switchdev.c +++ b/drivers/net/ethernet/ti/am65-cpsw-switchdev.c @@ -55,12 +55,12 @@ static int am65_cpsw_port_stp_state_set(struct am65_cpsw_port *port, u8 state) static int am65_cpsw_port_attr_br_flags_set(struct am65_cpsw_port *port, struct net_device *orig_dev, - unsigned long brport_flags) + struct switchdev_brport_flags flags) { struct am65_cpsw_common *cpsw = port->common; bool unreg_mcast_add = false; - if (brport_flags & BR_MCAST_FLOOD) + if (flags.mask & BR_MCAST_FLOOD) unreg_mcast_add = true; netdev_dbg(port->ndev, "BR_MCAST_FLOOD: %d port %u\n", unreg_mcast_add, port->port_id); @@ -72,9 +72,9 @@ static int am65_cpsw_port_attr_br_flags_set(struct am65_cpsw_port *port, } static int am65_cpsw_port_attr_br_flags_pre_set(struct net_device *netdev, - unsigned long flags) + struct switchdev_brport_flags flags) { - if (flags & ~(BR_LEARNING | BR_MCAST_FLOOD)) + if (flags.mask & ~(BR_LEARNING | BR_MCAST_FLOOD)) return -EINVAL; return 0; -- 2.30.0