From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D08F3C433C1 for ; Mon, 22 Mar 2021 15:52:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0617619AC for ; Mon, 22 Mar 2021 15:52:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230021AbhCVPwO (ORCPT ); Mon, 22 Mar 2021 11:52:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231305AbhCVPvz (ORCPT ); Mon, 22 Mar 2021 11:51:55 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DF0AC061756; Mon, 22 Mar 2021 08:51:54 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id u5so22112812ejn.8; Mon, 22 Mar 2021 08:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=P1zx+gVi7eurX/wcAygqpr2CDWPeDaHcriTmolTK1xU=; b=bEVgUuuP2bE/VUwwNcXpOB8inqXkeiuv962axrmdI8HNdb7nsPC8GR9qU1QZnSFHza ngF/NRyQYX1fC7j48cA17HVy8OGoo2tP7YfdDw78JRyku6TBzgftBdYmx5AGkZaDLv9/ /+P4TWV3He3gzQyR7m/IAtJ63lzrNO8Kv7mV/XGcJkmkcXfMMbd5dHmv5RQ9VbbRLhfg 3Gi2eCSzGLyagAsRVVJ78W+IMsquRwt0fR6tozGR7f6YXg4MPaEi3TqpM8m8jLzArlU0 LYZTYbQ6w65YmFl9FRTQaC4hzIqIkB7JiACRNlUG5ocM93u6XillPx8D8Lfxv3OCi8kP pQQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=P1zx+gVi7eurX/wcAygqpr2CDWPeDaHcriTmolTK1xU=; b=EaXeB+Gj/ydh34M7sGPJqvDuRAGJdQulbB/4k/enErOm/RPo4uwu6xTSrNI9s+G3XE cUbCk+Pi9xOsgY9jLtbGmMe+aFP33De8poz2cB9WxNQOEVXhuzlLF9uPMgTx/UFT4und zfrgsfOlcEgCPSt0ONRQ7xnFx0Gt83Z0O4CUE6ju0EKP7+4ucMWDf4YZZKkEmYLcF4IX /QMIH5ZzsB4Zxhs+Ay1zYwPOdMyAHMTdzWoP0ujDvH3mS4EafHYDcbgYJBoEHM08z7U5 q+igupOXA8TSiEw759quumGAKntIF7DxrYDH8SkR6IWsp7vVapNe2W/poA4LuVaxVwem dtUA== X-Gm-Message-State: AOAM532a2tAdrCPPF83ZSnWTpmzbfG1K/IuUylXoN1dDWCT4RkIGmO/N Xd38G0rKm9wWUICtp6LOVfs= X-Google-Smtp-Source: ABdhPJy/+WldZr1xoAOT8UD3w9feWEH8m3O5OU4AeeHQIclNDI0LngFZ3brViaqYNrubVogfwyu+NQ== X-Received: by 2002:a17:906:a413:: with SMTP id l19mr396813ejz.421.1616428312836; Mon, 22 Mar 2021 08:51:52 -0700 (PDT) Received: from [10.230.29.202] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id s9sm11054640edd.16.2021.03.22.08.51.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 08:51:52 -0700 (PDT) Subject: Re: [RFC PATCH v2 net-next 15/16] net: dsa: return -EOPNOTSUPP when driver does not implement .port_lag_join To: Vladimir Oltean , Jakub Kicinski , "David S. Miller" Cc: Andrew Lunn , Vivien Didelot , Tobias Waldekranz , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Roopa Prabhu , Nikolay Aleksandrov , Jiri Pirko , Ido Schimmel , Alexandre Belloni , UNGLinuxDriver@microchip.com, Vadym Kochan , Taras Chornyi , Grygorii Strashko , Vignesh Raghavendra , Ioana Ciornei , Ivan Vecera , linux-omap@vger.kernel.org, Vladimir Oltean References: <20210318231829.3892920-1-olteanv@gmail.com> <20210318231829.3892920-16-olteanv@gmail.com> From: Florian Fainelli Message-ID: Date: Mon, 22 Mar 2021 08:51:45 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210318231829.3892920-16-olteanv@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 3/18/2021 4:18 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > The DSA core has a layered structure, and even though we end up > returning 0 (success) to user space when setting a bonding/team upper > that can't be offloaded, some parts of the framework actually need to > know that we couldn't offload that. > > For example, if dsa_switch_lag_join returns 0 as it currently does, > dsa_port_lag_join has no way to tell a successful offload from a > software fallback, and it will call dsa_port_bridge_join afterwards. > Then we'll think we're offloading the bridge master of the LAG, when in > fact we're not even offloading the LAG. In turn, this will make us set > skb->offload_fwd_mark = true, which is incorrect and the bridge doesn't > like it. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian