From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Adam Ford <aford173@gmail.com>
Cc: linux-fbdev@vger.kernel.org, stable@vger.kernel.org,
Dave Airlie <airlied@gmail.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Rob Clark <robdclark@gmail.com>,
linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] omapfb: dss: Fix max fclk divider for omap36xx
Date: Fri, 10 Jul 2020 16:23:56 +0200 [thread overview]
Message-ID: <e7bb19a5-774c-63c3-058f-1977d29cd94c@samsung.com> (raw)
In-Reply-To: <20200630182636.439015-1-aford173@gmail.com>
On 6/30/20 8:26 PM, Adam Ford wrote:
> The drm/omap driver was fixed to correct an issue where using a
> divider of 32 breaks the DSS despite the TRM stating 32 is a valid
> number. Through experimentation, it appears that 31 works, and
> it is consistent with the value used by the drm/omap driver.
>
> This patch fixes the divider for fbdev driver instead of the drm.
>
> Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
>
> Cc: <stable@vger.kernel.org> #4.9+
> Signed-off-by: Adam Ford <aford173@gmail.com>
Applied to drm-misc-next tree, thanks.
(I marked patch as applicable to stable 4.5+ while merging)
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> Linux 4.4 will need a similar patch, but it doesn't apply cleanly.
>
> The DRM version of this same fix is:
> e2c4ed148cf3 ("drm/omap: fix max fclk divider for omap36xx")
>
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.c b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> index 7252d22dd117..bfc5c4c5a26a 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> @@ -833,7 +833,7 @@ static const struct dss_features omap34xx_dss_feats = {
> };
>
> static const struct dss_features omap3630_dss_feats = {
> - .fck_div_max = 32,
> + .fck_div_max = 31,
> .dss_fck_multiplier = 1,
> .parent_clk_name = "dpll4_ck",
> .dpi_select_source = &dss_dpi_select_source_omap2_omap3,
>
prev parent reply other threads:[~2020-07-10 14:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200630182652eucas1p1ce5e07b065127e32ab734f4447c2f735@eucas1p1.samsung.com>
2020-06-30 18:26 ` [PATCH] omapfb: dss: Fix max fclk divider for omap36xx Adam Ford
2020-07-03 7:17 ` Tomi Valkeinen
2020-07-03 19:36 ` Sam Ravnborg
2020-07-06 6:02 ` Tomi Valkeinen
2020-07-06 11:18 ` Adam Ford
2020-07-08 23:37 ` Adam Ford
2020-07-09 6:10 ` Greg KH
2020-07-10 14:23 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7bb19a5-774c-63c3-058f-1977d29cd94c@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=aford173@gmail.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).