* [PATCH v3 09/13] ASoC: ti: omap-mcbsp-st: Remove set, but unused variable 'w'
[not found] <20200707190612.97799-1-pierre-louis.bossart@linux.intel.com>
@ 2020-07-07 19:06 ` Pierre-Louis Bossart
2020-07-08 5:39 ` Peter Ujfalusi
0 siblings, 1 reply; 2+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-07 19:06 UTC (permalink / raw)
To: alsa-devel
Cc: tiwai, broonie, Lee Jones, Peter Ujfalusi, Jarkko Nikula,
Samuel Ortiz, linux-omap, Pierre-Louis Bossart, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, open list
From: Lee Jones <lee.jones@linaro.org>
Looks like 'w' has remained unchecked since the driver's inception.
Fixes the following W=1 kernel build warning(s):
sound/soc/ti/omap-mcbsp-st.c: In function ‘omap_mcbsp_st_chgain’:
sound/soc/ti/omap-mcbsp-st.c:145:6: warning: variable ‘w’ set but not used [-Wunused-but-set-variable]
Peter suggested that the whole read can be removed, so that's
been done too.
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
Cc: Samuel Ortiz <samuel.ortiz@nokia.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/ti/omap-mcbsp-st.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/ti/omap-mcbsp-st.c b/sound/soc/ti/omap-mcbsp-st.c
index 5a32b54bbf3b..0bc7d26c660a 100644
--- a/sound/soc/ti/omap-mcbsp-st.c
+++ b/sound/soc/ti/omap-mcbsp-st.c
@@ -142,11 +142,8 @@ static void omap_mcbsp_st_fir_write(struct omap_mcbsp *mcbsp, s16 *fir)
static void omap_mcbsp_st_chgain(struct omap_mcbsp *mcbsp)
{
- u16 w;
struct omap_mcbsp_st_data *st_data = mcbsp->st_data;
- w = MCBSP_ST_READ(mcbsp, SSELCR);
-
MCBSP_ST_WRITE(mcbsp, SGAINCR, ST_CH0GAIN(st_data->ch0gain) |
ST_CH1GAIN(st_data->ch1gain));
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 09/13] ASoC: ti: omap-mcbsp-st: Remove set, but unused variable 'w'
2020-07-07 19:06 ` [PATCH v3 09/13] ASoC: ti: omap-mcbsp-st: Remove set, but unused variable 'w' Pierre-Louis Bossart
@ 2020-07-08 5:39 ` Peter Ujfalusi
0 siblings, 0 replies; 2+ messages in thread
From: Peter Ujfalusi @ 2020-07-08 5:39 UTC (permalink / raw)
To: Pierre-Louis Bossart, alsa-devel
Cc: tiwai, broonie, Lee Jones, Jarkko Nikula, Samuel Ortiz,
linux-omap, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
open list
On 07/07/2020 22.06, Pierre-Louis Bossart wrote:
> From: Lee Jones <lee.jones@linaro.org>
>
> Looks like 'w' has remained unchecked since the driver's inception.
>
> Fixes the following W=1 kernel build warning(s):
>
> sound/soc/ti/omap-mcbsp-st.c: In function ‘omap_mcbsp_st_chgain’:
> sound/soc/ti/omap-mcbsp-st.c:145:6: warning: variable ‘w’ set but not used [-Wunused-but-set-variable]
>
> Peter suggested that the whole read can be removed, so that's
> been done too.
Thank you,
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
> Cc: Samuel Ortiz <samuel.ortiz@nokia.com>
> Cc: linux-omap@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/ti/omap-mcbsp-st.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/sound/soc/ti/omap-mcbsp-st.c b/sound/soc/ti/omap-mcbsp-st.c
> index 5a32b54bbf3b..0bc7d26c660a 100644
> --- a/sound/soc/ti/omap-mcbsp-st.c
> +++ b/sound/soc/ti/omap-mcbsp-st.c
> @@ -142,11 +142,8 @@ static void omap_mcbsp_st_fir_write(struct omap_mcbsp *mcbsp, s16 *fir)
>
> static void omap_mcbsp_st_chgain(struct omap_mcbsp *mcbsp)
> {
> - u16 w;
> struct omap_mcbsp_st_data *st_data = mcbsp->st_data;
>
> - w = MCBSP_ST_READ(mcbsp, SSELCR);
> -
> MCBSP_ST_WRITE(mcbsp, SGAINCR, ST_CH0GAIN(st_data->ch0gain) |
> ST_CH1GAIN(st_data->ch1gain));
> }
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-08 5:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200707190612.97799-1-pierre-louis.bossart@linux.intel.com>
2020-07-07 19:06 ` [PATCH v3 09/13] ASoC: ti: omap-mcbsp-st: Remove set, but unused variable 'w' Pierre-Louis Bossart
2020-07-08 5:39 ` Peter Ujfalusi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).