From: Roger Quadros <rogerq@ti.com>
To: Suman Anna <s-anna@ti.com>, Tony Lindgren <tony@atomide.com>
Cc: Tero Kristo <t-kristo@ti.com>, <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 4/5] ARM: dts: AM4372: Add the PRU-ICSS interconnect target-module node
Date: Fri, 28 Feb 2020 10:33:38 +0200 [thread overview]
Message-ID: <f3ba0138-141c-0602-788c-8bf8f802f436@ti.com> (raw)
In-Reply-To: <20200227222837.7329-5-s-anna@ti.com>
On 28/02/2020 00:28, Suman Anna wrote:
> The AM437x family of SoCs contains two dissimilar PRU-ICSS instances,
> but leverage a common reset line and SYSCFG from the larger PRU-ICSS1
> instance. This SYSC register has also very unique bit-fields. Both
> the IPs require the PRCM reset to be deasserted to be able to access
> any registers. Add a common PRUSS interconnect target-module with all
> the required properties.
>
> The PRUSS devices themselves shall be added as child nodes to this
> interconnect node in the future. The PRU-ICSS instances are not
> supported on AM4372 SoC though in the AM437x family, so the target
> module node should be disabled in any derivative board files that
> use this SoC.
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
Reviewed-by: Roger Quadros <rogerq@ti.com>
> ---
> v2:
> - Remove status=disabled
> - Revise last para in patch description
>
> arch/arm/boot/dts/am4372.dtsi | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> index faa14dc0faff..9f39413b0d0e 100644
> --- a/arch/arm/boot/dts/am4372.dtsi
> +++ b/arch/arm/boot/dts/am4372.dtsi
> @@ -344,6 +344,28 @@
> };
> };
>
> + pruss_tm: target-module@54400000 {
> + compatible = "ti,sysc-pruss", "ti,sysc";
> + reg = <0x54426000 0x4>,
> + <0x54426004 0x4>;
> + reg-names = "rev", "sysc";
> + ti,sysc-mask = <(SYSC_PRUSS_STANDBY_INIT |
> + SYSC_PRUSS_SUB_MWAIT)>;
> + ti,sysc-midle = <SYSC_IDLE_FORCE>,
> + <SYSC_IDLE_NO>,
> + <SYSC_IDLE_SMART>;
> + ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> + <SYSC_IDLE_NO>,
> + <SYSC_IDLE_SMART>;
> + clocks = <&pruss_ocp_clkctrl AM4_PRUSS_OCP_PRUSS_CLKCTRL 0>;
> + clock-names = "fck";
> + resets = <&prm_per 1>;
> + reset-names = "rstctrl";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x54400000 0x80000>;
> + };
> +
> gpmc: gpmc@50000000 {
> compatible = "ti,am3352-gpmc";
> ti,hwmods = "gpmc";
>
--
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-02-28 8:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 22:28 [PATCH v2 0/5] ti-sysc support for PRUSS Suman Anna
2020-02-27 22:28 ` [PATCH v2 1/5] dt-bindings: bus: ti-sysc: Add support for PRUSS SYSC type Suman Anna
2020-03-03 22:40 ` Rob Herring
2020-02-27 22:28 ` [PATCH v2 2/5] " Suman Anna
2020-02-27 22:28 ` [PATCH v2 3/5] ARM: dts: AM33xx-l4: Update PRUSS interconnect target-module node Suman Anna
2020-02-28 8:33 ` Roger Quadros
2020-02-27 22:28 ` [PATCH v2 4/5] ARM: dts: AM4372: Add the PRU-ICSS " Suman Anna
2020-02-28 8:33 ` Roger Quadros [this message]
2020-02-27 22:28 ` [PATCH v2 5/5] ARM: dts: dra7: Add PRU-ICSS interconnect target-module nodes Suman Anna
2020-03-04 16:28 ` [PATCH v2 0/5] ti-sysc support for PRUSS Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3ba0138-141c-0602-788c-8bf8f802f436@ti.com \
--to=rogerq@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=s-anna@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).