From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B9FFC43457 for ; Wed, 14 Oct 2020 15:45:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F116A22258 for ; Wed, 14 Oct 2020 15:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602690355; bh=ZO2zzjmGglCwYqkgfRhnAhmiEaEWisPsjKCp4MzM4CE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=EFLu21RNQp0OButoLhq4Mx0XzCrlzs2POlp2C/dHVJ/B2PEgtm1eDnmptGU6vAIPa BGiDsWHQaYQfNPJ8tzUiS9qXTWxC0Iuc1ehOWyVlcehZzV8GE+ux3CzOf7yaRID5Cn hEnzn+kKS4NB5eeHrFRb19DePgkgRCzVRMrS+FNs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387445AbgJNPpx (ORCPT ); Wed, 14 Oct 2020 11:45:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731627AbgJNPpw (ORCPT ); Wed, 14 Oct 2020 11:45:52 -0400 Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7319AC0613D2 for ; Wed, 14 Oct 2020 08:45:52 -0700 (PDT) Received: by mail-io1-xd41.google.com with SMTP id n6so5646863ioc.12 for ; Wed, 14 Oct 2020 08:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GVsFzR74egr+o93/X35XS2maZ1vLsmxHPBrJlJDsuhI=; b=X4aAHpmKSHgU3/84qpUaV903w1xkwCtvsv7XMV8dUuc9QnpjmB/jKfLFcdpqh7UmY4 IG9lWFz+HRgkE8tRa/pOXAXobj0l94fXgiNfyoap+V7yrzg1LQqQgDVrbGZk1Qt7MpXw IsWNMw7UDTAPcoV7udFaMBNkFCpbRweWEvQFc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GVsFzR74egr+o93/X35XS2maZ1vLsmxHPBrJlJDsuhI=; b=V8Agjxq80m3RtFtvb7gnDp79K67IPpBoFvgLy2HM/zwxtAqZ/u9rHxuNuCizPoE/6v t90N67+Z6qimbbc3ZpMjcYStUTpjXsd6IX1cypELaAovBEXlOuuD8Kt/zmrzAnz8WzEH K29GDYzK/AablzRfEtElRU6lEFoHZD1T8HkS3DcSpRtYdCb3N8zgS36DsI+r1baV79iB e52mgKchpRyQS9gDC0k9Hm4jrEa7watFDsc5+aI6QLW1cJt84nCfdJUF7ASZTUcz3ytw 9+P1LEGvXjBhaanOjiY6Al8fiWPqn5B4M7s+aU2sLEO8upmYnH3YPxApaq6wDLA5XoCs yW3A== X-Gm-Message-State: AOAM53203rYcZAcQja3NdHyBukuP+6j8WGDp36shMyjFt3xicjCV/z78 cr2OTHGyNOkqdtMYLzr7oobrPw== X-Google-Smtp-Source: ABdhPJxFL0dEO8+kC0xlhiweNLkyf1APFnjIPT9B9l6CjUgbzU9W6XQstgVJjfauCC4EZCo/jPEspg== X-Received: by 2002:a02:a510:: with SMTP id e16mr43790jam.51.1602690351653; Wed, 14 Oct 2020 08:45:51 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id t22sm3922965ili.9.2020.10.14.08.45.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2020 08:45:50 -0700 (PDT) Subject: Re: [patch 07/12] usbip: Remove in_interrupt() check To: Thomas Gleixner , LKML Cc: Peter Zijlstra , "Ahmed S. Darwish" , Sebastian Andrzej Siewior , Valentina Manea , Shuah Khan , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Thomas Winischhofer , Johan Hovold , Mathias Nyman , Alan Stern , linux-omap@vger.kernel.org, Kukjin Kim , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Felipe Balbi , Duncan Sands , Shuah Khan References: <20201014145215.518912759@linutronix.de> <20201014145727.828083323@linutronix.de> From: Shuah Khan Message-ID: Date: Wed, 14 Oct 2020 09:45:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201014145727.828083323@linutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 10/14/20 8:52 AM, Thomas Gleixner wrote: > From: Ahmed S. Darwish > > The usage of in_interrupt() in drivers is phased out and Linus clearly > requested that code which changes behaviour depending on context should > either be separated or the context be conveyed in an argument passed by the > caller, which usually knows the context. > > usbip_recv() uses in_interrupt() to conditionally print context information > for debugging messages. The value is zero as the function is only called > from various *_rx_loop() kthread functions. Remove it. > > Signed-off-by: Ahmed S. Darwish > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Cc: Valentina Manea > Cc: Shuah Khan > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > > --- > drivers/usb/usbip/usbip_common.c | 5 ----- > 1 file changed, 5 deletions(-) > > --- a/drivers/usb/usbip/usbip_common.c > +++ b/drivers/usb/usbip/usbip_common.c > @@ -324,11 +324,6 @@ int usbip_recv(struct socket *sock, void > } while (msg_data_left(&msg)); > > if (usbip_dbg_flag_xmit) { > - if (!in_interrupt()) > - pr_debug("%-10s:", current->comm); > - else > - pr_debug("interrupt :"); > - > pr_debug("receiving....\n"); > usbip_dump_buffer(buf, size); > pr_debug("received, osize %d ret %d size %zd total %d\n", > > Looks good to me. Acked-by: Shuah Khan thanks, -- Shuah