* [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe()
@ 2020-08-27 20:08 Krzysztof Kozlowski
2020-08-27 20:08 ` [PATCH 2/6] gpio: davinci: " Krzysztof Kozlowski
` (7 more replies)
0 siblings, 8 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-27 20:08 UTC (permalink / raw)
To: Ray Jui, Linus Walleij, Bartosz Golaszewski, Florian Fainelli,
Scott Branden, bcm-kernel-feedback-list, Keerthy,
Grygorii Strashko, Santosh Shilimkar, Kevin Hilman, Michal Simek,
linux-gpio, linux-kernel, linux-omap, linux-arm-kernel
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/gpio/gpio-bcm-kona.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
index cf3687a7925f..1e6b427f2c4a 100644
--- a/drivers/gpio/gpio-bcm-kona.c
+++ b/drivers/gpio/gpio-bcm-kona.c
@@ -590,10 +590,7 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev)
dev_err(dev, "Couldn't determine # GPIO banks\n");
return -ENOENT;
} else if (ret < 0) {
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "Couldn't determine GPIO banks: (%pe)\n",
- ERR_PTR(ret));
- return ret;
+ return dev_err_probe(dev, ret, "Couldn't determine GPIO banks\n");
}
kona_gpio->num_bank = ret;
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/6] gpio: davinci: Simplify with dev_err_probe()
2020-08-27 20:08 [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe() Krzysztof Kozlowski
@ 2020-08-27 20:08 ` Krzysztof Kozlowski
2020-08-27 20:08 ` [PATCH 3/6] gpio: omap: " Krzysztof Kozlowski
` (6 subsequent siblings)
7 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-27 20:08 UTC (permalink / raw)
To: Ray Jui, Linus Walleij, Bartosz Golaszewski, Florian Fainelli,
Scott Branden, bcm-kernel-feedback-list, Keerthy,
Grygorii Strashko, Santosh Shilimkar, Kevin Hilman, Michal Simek,
linux-gpio, linux-kernel, linux-omap, linux-arm-kernel
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/gpio/gpio-davinci.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 085b874db2a9..6f2138503726 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -237,12 +237,8 @@ static int davinci_gpio_probe(struct platform_device *pdev)
for (i = 0; i < nirq; i++) {
chips->irqs[i] = platform_get_irq(pdev, i);
- if (chips->irqs[i] < 0) {
- if (chips->irqs[i] != -EPROBE_DEFER)
- dev_info(dev, "IRQ not populated, err = %d\n",
- chips->irqs[i]);
- return chips->irqs[i];
- }
+ if (chips->irqs[i] < 0)
+ return dev_err_probe(dev, chips->irqs[i], "IRQ not populated\n");
}
chips->chip.label = dev_name(dev);
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/6] gpio: omap: Simplify with dev_err_probe()
2020-08-27 20:08 [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe() Krzysztof Kozlowski
2020-08-27 20:08 ` [PATCH 2/6] gpio: davinci: " Krzysztof Kozlowski
@ 2020-08-27 20:08 ` Krzysztof Kozlowski
2020-08-28 8:01 ` Grygorii Strashko
2020-08-27 20:08 ` [PATCH 4/6] gpio: pca953x: " Krzysztof Kozlowski
` (5 subsequent siblings)
7 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-27 20:08 UTC (permalink / raw)
To: Ray Jui, Linus Walleij, Bartosz Golaszewski, Florian Fainelli,
Scott Branden, bcm-kernel-feedback-list, Keerthy,
Grygorii Strashko, Santosh Shilimkar, Kevin Hilman, Michal Simek,
linux-gpio, linux-kernel, linux-omap, linux-arm-kernel
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/gpio/gpio-omap.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 7fbe0c9e1fc1..2dc12f4addbd 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1394,10 +1394,7 @@ static int omap_gpio_probe(struct platform_device *pdev)
if (bank->irq <= 0) {
if (!bank->irq)
bank->irq = -ENXIO;
- if (bank->irq != -EPROBE_DEFER)
- dev_err(dev,
- "can't get irq resource ret=%d\n", bank->irq);
- return bank->irq;
+ return dev_err_probe(dev, bank->irq, "can't get irq resource\n");
}
bank->chip.parent = dev;
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 4/6] gpio: pca953x: Simplify with dev_err_probe()
2020-08-27 20:08 [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe() Krzysztof Kozlowski
2020-08-27 20:08 ` [PATCH 2/6] gpio: davinci: " Krzysztof Kozlowski
2020-08-27 20:08 ` [PATCH 3/6] gpio: omap: " Krzysztof Kozlowski
@ 2020-08-27 20:08 ` Krzysztof Kozlowski
2020-08-27 20:08 ` [PATCH 5/6] gpio: pisosr: " Krzysztof Kozlowski
` (4 subsequent siblings)
7 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-27 20:08 UTC (permalink / raw)
To: Ray Jui, Linus Walleij, Bartosz Golaszewski, Florian Fainelli,
Scott Branden, bcm-kernel-feedback-list, Keerthy,
Grygorii Strashko, Santosh Shilimkar, Kevin Hilman, Michal Simek,
linux-gpio, linux-kernel, linux-omap, linux-arm-kernel
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/gpio/gpio-pca953x.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index bd2e96c34f82..b5c3e56613a7 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -1000,12 +1000,9 @@ static int pca953x_probe(struct i2c_client *client,
chip->client = client;
reg = devm_regulator_get(&client->dev, "vcc");
- if (IS_ERR(reg)) {
- ret = PTR_ERR(reg);
- if (ret != -EPROBE_DEFER)
- dev_err(&client->dev, "reg get err: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(reg))
+ return dev_err_probe(&client->dev, PTR_ERR(reg), "reg get err\n");
+
ret = regulator_enable(reg);
if (ret) {
dev_err(&client->dev, "reg en err: %d\n", ret);
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 5/6] gpio: pisosr: Simplify with dev_err_probe()
2020-08-27 20:08 [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe() Krzysztof Kozlowski
` (2 preceding siblings ...)
2020-08-27 20:08 ` [PATCH 4/6] gpio: pca953x: " Krzysztof Kozlowski
@ 2020-08-27 20:08 ` Krzysztof Kozlowski
2020-08-27 20:08 ` [PATCH 6/6] gpio: zynq: " Krzysztof Kozlowski
` (3 subsequent siblings)
7 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-27 20:08 UTC (permalink / raw)
To: Ray Jui, Linus Walleij, Bartosz Golaszewski, Florian Fainelli,
Scott Branden, bcm-kernel-feedback-list, Keerthy,
Grygorii Strashko, Santosh Shilimkar, Kevin Hilman, Michal Simek,
linux-gpio, linux-kernel, linux-omap, linux-arm-kernel
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/gpio/gpio-pisosr.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpio/gpio-pisosr.c b/drivers/gpio/gpio-pisosr.c
index 6698feabaced..8e04054cf07e 100644
--- a/drivers/gpio/gpio-pisosr.c
+++ b/drivers/gpio/gpio-pisosr.c
@@ -148,12 +148,9 @@ static int pisosr_gpio_probe(struct spi_device *spi)
return -ENOMEM;
gpio->load_gpio = devm_gpiod_get_optional(dev, "load", GPIOD_OUT_LOW);
- if (IS_ERR(gpio->load_gpio)) {
- ret = PTR_ERR(gpio->load_gpio);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "Unable to allocate load GPIO\n");
- return ret;
- }
+ if (IS_ERR(gpio->load_gpio))
+ return dev_err_probe(dev, PTR_ERR(gpio->load_gpio),
+ "Unable to allocate load GPIO\n");
mutex_init(&gpio->lock);
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 6/6] gpio: zynq: Simplify with dev_err_probe()
2020-08-27 20:08 [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe() Krzysztof Kozlowski
` (3 preceding siblings ...)
2020-08-27 20:08 ` [PATCH 5/6] gpio: pisosr: " Krzysztof Kozlowski
@ 2020-08-27 20:08 ` Krzysztof Kozlowski
2020-08-28 5:20 ` Michal Simek
2020-09-12 9:26 ` Linus Walleij
2020-08-28 10:03 ` [PATCH 1/6] gpio: bcm-kona: " Andy Shevchenko
` (2 subsequent siblings)
7 siblings, 2 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-27 20:08 UTC (permalink / raw)
To: Ray Jui, Linus Walleij, Bartosz Golaszewski, Florian Fainelli,
Scott Branden, bcm-kernel-feedback-list, Keerthy,
Grygorii Strashko, Santosh Shilimkar, Kevin Hilman, Michal Simek,
linux-gpio, linux-kernel, linux-omap, linux-arm-kernel
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/gpio/gpio-zynq.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
index 53d1387592fd..0b5a17ab996f 100644
--- a/drivers/gpio/gpio-zynq.c
+++ b/drivers/gpio/gpio-zynq.c
@@ -929,11 +929,9 @@ static int zynq_gpio_probe(struct platform_device *pdev)
/* Retrieve GPIO clock */
gpio->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(gpio->clk)) {
- if (PTR_ERR(gpio->clk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "input clock not found.\n");
- return PTR_ERR(gpio->clk);
- }
+ if (IS_ERR(gpio->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(gpio->clk), "input clock not found.\n");
+
ret = clk_prepare_enable(gpio->clk);
if (ret) {
dev_err(&pdev->dev, "Unable to enable clock.\n");
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 6/6] gpio: zynq: Simplify with dev_err_probe()
2020-08-27 20:08 ` [PATCH 6/6] gpio: zynq: " Krzysztof Kozlowski
@ 2020-08-28 5:20 ` Michal Simek
2020-09-12 9:26 ` Linus Walleij
1 sibling, 0 replies; 13+ messages in thread
From: Michal Simek @ 2020-08-28 5:20 UTC (permalink / raw)
To: Krzysztof Kozlowski, Ray Jui, Linus Walleij, Bartosz Golaszewski,
Florian Fainelli, Scott Branden, bcm-kernel-feedback-list,
Keerthy, Grygorii Strashko, Santosh Shilimkar, Kevin Hilman,
Michal Simek, linux-gpio, linux-kernel, linux-omap,
linux-arm-kernel
On 27. 08. 20 22:08, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/gpio/gpio-zynq.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
> index 53d1387592fd..0b5a17ab996f 100644
> --- a/drivers/gpio/gpio-zynq.c
> +++ b/drivers/gpio/gpio-zynq.c
> @@ -929,11 +929,9 @@ static int zynq_gpio_probe(struct platform_device *pdev)
>
> /* Retrieve GPIO clock */
> gpio->clk = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(gpio->clk)) {
> - if (PTR_ERR(gpio->clk) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "input clock not found.\n");
> - return PTR_ERR(gpio->clk);
> - }
> + if (IS_ERR(gpio->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(gpio->clk), "input clock not found.\n");
> +
> ret = clk_prepare_enable(gpio->clk);
> if (ret) {
> dev_err(&pdev->dev, "Unable to enable clock.\n");
>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/6] gpio: omap: Simplify with dev_err_probe()
2020-08-27 20:08 ` [PATCH 3/6] gpio: omap: " Krzysztof Kozlowski
@ 2020-08-28 8:01 ` Grygorii Strashko
0 siblings, 0 replies; 13+ messages in thread
From: Grygorii Strashko @ 2020-08-28 8:01 UTC (permalink / raw)
To: Krzysztof Kozlowski, Ray Jui, Linus Walleij, Bartosz Golaszewski,
Florian Fainelli, Scott Branden, bcm-kernel-feedback-list,
Keerthy, Santosh Shilimkar, Kevin Hilman, Michal Simek,
linux-gpio, linux-kernel, linux-omap, linux-arm-kernel
On 27/08/2020 23:08, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/gpio/gpio-omap.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index 7fbe0c9e1fc1..2dc12f4addbd 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1394,10 +1394,7 @@ static int omap_gpio_probe(struct platform_device *pdev)
> if (bank->irq <= 0) {
> if (!bank->irq)
> bank->irq = -ENXIO;
> - if (bank->irq != -EPROBE_DEFER)
> - dev_err(dev,
> - "can't get irq resource ret=%d\n", bank->irq);
> - return bank->irq;
> + return dev_err_probe(dev, bank->irq, "can't get irq resource\n");
> }
>
> bank->chip.parent = dev;
>
Acked-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
Best regards,
grygorii
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe()
2020-08-27 20:08 [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe() Krzysztof Kozlowski
` (4 preceding siblings ...)
2020-08-27 20:08 ` [PATCH 6/6] gpio: zynq: " Krzysztof Kozlowski
@ 2020-08-28 10:03 ` Andy Shevchenko
2020-08-28 17:15 ` Florian Fainelli
2020-08-28 18:17 ` Bartosz Golaszewski
7 siblings, 0 replies; 13+ messages in thread
From: Andy Shevchenko @ 2020-08-28 10:03 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Ray Jui, Linus Walleij, Bartosz Golaszewski, Florian Fainelli,
Scott Branden, bcm-kernel-feedback-list, Keerthy,
Grygorii Strashko, Santosh Shilimkar, Kevin Hilman, Michal Simek,
open list:GPIO SUBSYSTEM, Linux Kernel Mailing List,
Linux OMAP Mailing List, linux-arm Mailing List
On Thu, Aug 27, 2020 at 11:09 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.
>
I believe you are doing this right (after we have discussed previous
series and approaches).
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
for entire series (Linus!)
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/gpio/gpio-bcm-kona.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
> index cf3687a7925f..1e6b427f2c4a 100644
> --- a/drivers/gpio/gpio-bcm-kona.c
> +++ b/drivers/gpio/gpio-bcm-kona.c
> @@ -590,10 +590,7 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev)
> dev_err(dev, "Couldn't determine # GPIO banks\n");
> return -ENOENT;
> } else if (ret < 0) {
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "Couldn't determine GPIO banks: (%pe)\n",
> - ERR_PTR(ret));
> - return ret;
> + return dev_err_probe(dev, ret, "Couldn't determine GPIO banks\n");
> }
> kona_gpio->num_bank = ret;
>
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe()
2020-08-27 20:08 [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe() Krzysztof Kozlowski
` (5 preceding siblings ...)
2020-08-28 10:03 ` [PATCH 1/6] gpio: bcm-kona: " Andy Shevchenko
@ 2020-08-28 17:15 ` Florian Fainelli
2020-08-28 18:17 ` Bartosz Golaszewski
7 siblings, 0 replies; 13+ messages in thread
From: Florian Fainelli @ 2020-08-28 17:15 UTC (permalink / raw)
To: Krzysztof Kozlowski, Ray Jui, Linus Walleij, Bartosz Golaszewski,
Scott Branden, bcm-kernel-feedback-list, Keerthy,
Grygorii Strashko, Santosh Shilimkar, Kevin Hilman, Michal Simek,
linux-gpio, linux-kernel, linux-omap, linux-arm-kernel
On 8/27/20 1:08 PM, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe()
2020-08-27 20:08 [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe() Krzysztof Kozlowski
` (6 preceding siblings ...)
2020-08-28 17:15 ` Florian Fainelli
@ 2020-08-28 18:17 ` Bartosz Golaszewski
2020-09-12 9:27 ` Linus Walleij
7 siblings, 1 reply; 13+ messages in thread
From: Bartosz Golaszewski @ 2020-08-28 18:17 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Ray Jui, Linus Walleij, Florian Fainelli, Scott Branden,
bcm-kernel-feedback-list, Keerthy, Grygorii Strashko,
Santosh Shilimkar, Kevin Hilman, Michal Simek, linux-gpio, LKML,
Linux-OMAP, arm-soc
On Thu, Aug 27, 2020 at 10:08 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/gpio/gpio-bcm-kona.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
> index cf3687a7925f..1e6b427f2c4a 100644
> --- a/drivers/gpio/gpio-bcm-kona.c
> +++ b/drivers/gpio/gpio-bcm-kona.c
> @@ -590,10 +590,7 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev)
> dev_err(dev, "Couldn't determine # GPIO banks\n");
> return -ENOENT;
> } else if (ret < 0) {
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "Couldn't determine GPIO banks: (%pe)\n",
> - ERR_PTR(ret));
> - return ret;
> + return dev_err_probe(dev, ret, "Couldn't determine GPIO banks\n");
> }
> kona_gpio->num_bank = ret;
>
> --
> 2.17.1
>
Queued the entire series with all the tags, thanks!
Bartosz
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 6/6] gpio: zynq: Simplify with dev_err_probe()
2020-08-27 20:08 ` [PATCH 6/6] gpio: zynq: " Krzysztof Kozlowski
2020-08-28 5:20 ` Michal Simek
@ 2020-09-12 9:26 ` Linus Walleij
1 sibling, 0 replies; 13+ messages in thread
From: Linus Walleij @ 2020-09-12 9:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Ray Jui, Bartosz Golaszewski, Florian Fainelli, Scott Branden,
bcm-kernel-feedback-list, Keerthy, Grygorii Strashko,
Santosh Shilimkar, Kevin Hilman, Michal Simek,
open list:GPIO SUBSYSTEM, linux-kernel, Linux-OMAP, Linux ARM
On Thu, Aug 27, 2020 at 10:08 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
All six patches applied!
Thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe()
2020-08-28 18:17 ` Bartosz Golaszewski
@ 2020-09-12 9:27 ` Linus Walleij
0 siblings, 0 replies; 13+ messages in thread
From: Linus Walleij @ 2020-09-12 9:27 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Krzysztof Kozlowski, Ray Jui, Florian Fainelli, Scott Branden,
bcm-kernel-feedback-list, Keerthy, Grygorii Strashko,
Santosh Shilimkar, Kevin Hilman, Michal Simek, linux-gpio, LKML,
Linux-OMAP, arm-soc
On Fri, Aug 28, 2020 at 8:17 PM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
> Queued the entire series with all the tags, thanks!
Oh you already queued them, I'll drop them from my tree.
Thanks!
Linus Walleij
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2020-09-12 9:28 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-27 20:08 [PATCH 1/6] gpio: bcm-kona: Simplify with dev_err_probe() Krzysztof Kozlowski
2020-08-27 20:08 ` [PATCH 2/6] gpio: davinci: " Krzysztof Kozlowski
2020-08-27 20:08 ` [PATCH 3/6] gpio: omap: " Krzysztof Kozlowski
2020-08-28 8:01 ` Grygorii Strashko
2020-08-27 20:08 ` [PATCH 4/6] gpio: pca953x: " Krzysztof Kozlowski
2020-08-27 20:08 ` [PATCH 5/6] gpio: pisosr: " Krzysztof Kozlowski
2020-08-27 20:08 ` [PATCH 6/6] gpio: zynq: " Krzysztof Kozlowski
2020-08-28 5:20 ` Michal Simek
2020-09-12 9:26 ` Linus Walleij
2020-08-28 10:03 ` [PATCH 1/6] gpio: bcm-kona: " Andy Shevchenko
2020-08-28 17:15 ` Florian Fainelli
2020-08-28 18:17 ` Bartosz Golaszewski
2020-09-12 9:27 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).