* [PATCH] parisc: asm: psw.h: missing header guard
@ 2019-06-23 15:09 Denis Efremov
2019-06-23 16:01 ` Rolf Eike Beer
2019-06-24 8:51 ` [PATCH v2] " Denis Efremov
0 siblings, 2 replies; 4+ messages in thread
From: Denis Efremov @ 2019-06-23 15:09 UTC (permalink / raw)
To: James E.J. Bottomley
Cc: Denis Efremov, Helge Deller, linux-parisc, linux-kernel
The psw.h header file contains #ifndef directive of the guard,
but the complimentary #define directive is missing. The patch
adds the appropriate #define to fix the header guard.
Signed-off-by: Denis Efremov <efremov@linux.com>
---
arch/parisc/include/asm/psw.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/parisc/include/asm/psw.h b/arch/parisc/include/asm/psw.h
index 76c301146c31..7a175e866ed0 100644
--- a/arch/parisc/include/asm/psw.h
+++ b/arch/parisc/include/asm/psw.h
@@ -1,5 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0 */
#ifndef _PARISC_PSW_H
+#define _PARISC_PSW_H
#define PSW_I 0x00000001
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] parisc: asm: psw.h: missing header guard
2019-06-23 15:09 [PATCH] parisc: asm: psw.h: missing header guard Denis Efremov
@ 2019-06-23 16:01 ` Rolf Eike Beer
2019-06-24 8:44 ` Denis Efremov
2019-06-24 8:51 ` [PATCH v2] " Denis Efremov
1 sibling, 1 reply; 4+ messages in thread
From: Rolf Eike Beer @ 2019-06-23 16:01 UTC (permalink / raw)
To: Denis Efremov
Cc: James E.J. Bottomley, Helge Deller, linux-parisc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
Denis Efremov wrote:
> The psw.h header file contains #ifndef directive of the guard,
> but the complimentary #define directive is missing. The patch
> adds the appropriate #define to fix the header guard.
>
> Signed-off-by: Denis Efremov <efremov@linux.com>
> ---
> arch/parisc/include/asm/psw.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/parisc/include/asm/psw.h b/arch/parisc/include/asm/psw.h
> index 76c301146c31..7a175e866ed0 100644
> --- a/arch/parisc/include/asm/psw.h
> +++ b/arch/parisc/include/asm/psw.h
> @@ -1,5 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> #ifndef _PARISC_PSW_H
> +#define _PARISC_PSW_H
>
>
> #define PSW_I 0x00000001
You could have removed one of the 2 empty lines then.
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] parisc: asm: psw.h: missing header guard
2019-06-23 16:01 ` Rolf Eike Beer
@ 2019-06-24 8:44 ` Denis Efremov
0 siblings, 0 replies; 4+ messages in thread
From: Denis Efremov @ 2019-06-24 8:44 UTC (permalink / raw)
To: Rolf Eike Beer
Cc: James E.J. Bottomley, Helge Deller, linux-parisc, linux-kernel
Rolf Eike Beer wrote:
>
> You could have removed one of the 2 empty lines then.
>
Will send the v2 in minutes.
Denis
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] parisc: asm: psw.h: missing header guard
2019-06-23 15:09 [PATCH] parisc: asm: psw.h: missing header guard Denis Efremov
2019-06-23 16:01 ` Rolf Eike Beer
@ 2019-06-24 8:51 ` Denis Efremov
1 sibling, 0 replies; 4+ messages in thread
From: Denis Efremov @ 2019-06-24 8:51 UTC (permalink / raw)
To: James E.J. Bottomley
Cc: Denis Efremov, Helge Deller, Rolf Eike Beer, linux-parisc, linux-kernel
The psw.h header file contains #ifndef directive of the guard,
but the complimentary #define directive is missing. The patch
adds the appropriate #define to fix the header guard.
Signed-off-by: Denis Efremov <efremov@linux.com>
---
arch/parisc/include/asm/psw.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/parisc/include/asm/psw.h b/arch/parisc/include/asm/psw.h
index 76c301146c31..46921ffcc407 100644
--- a/arch/parisc/include/asm/psw.h
+++ b/arch/parisc/include/asm/psw.h
@@ -1,6 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0 */
#ifndef _PARISC_PSW_H
-
+#define _PARISC_PSW_H
#define PSW_I 0x00000001
#define PSW_D 0x00000002
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-24 8:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-23 15:09 [PATCH] parisc: asm: psw.h: missing header guard Denis Efremov
2019-06-23 16:01 ` Rolf Eike Beer
2019-06-24 8:44 ` Denis Efremov
2019-06-24 8:51 ` [PATCH v2] " Denis Efremov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).