From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75EF8CA9ED0 for ; Fri, 1 Nov 2019 09:20:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55FCD21924 for ; Fri, 1 Nov 2019 09:20:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728316AbfKAJUP convert rfc822-to-8bit (ORCPT ); Fri, 1 Nov 2019 05:20:15 -0400 Received: from lithops.sigma-star.at ([195.201.40.130]:60088 "EHLO lithops.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728271AbfKAJUP (ORCPT ); Fri, 1 Nov 2019 05:20:15 -0400 Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id DEA1E608313B; Fri, 1 Nov 2019 10:20:11 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 8IWPWn6JPQyM; Fri, 1 Nov 2019 10:20:10 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id B72236083139; Fri, 1 Nov 2019 10:20:10 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id sbwSZl86X70W; Fri, 1 Nov 2019 10:20:10 +0100 (CET) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id F410762EBCC0; Fri, 1 Nov 2019 10:20:09 +0100 (CET) Date: Fri, 1 Nov 2019 10:20:09 +0100 (CET) From: Richard Weinberger To: Mike Rapoport Cc: linux-mm , Andrew Morton , anton ivanov , Arnd Bergmann , davem , Geert Uytterhoeven , Greentime Hu , Greg Ungerer , Helge Deller , "James E.J. Bottomley" , Jeff Dike , "Kirill A. Shutemov" , torvalds , Mark Salter , Matt Turner , Michal Simek , Peter Rosin , Rolf Eike Beer , Russell King , Sam Creasey , Vincent Chen , Vineet Gupta , linux-alpha , linux-arch , linux-arm-kernel , linux-c6x-dev , linux-kernel , linux-m68k , linux-parisc , linux-um , sparclinux , Mike Rapoport Message-ID: <1435962204.69872.1572600009245.JavaMail.zimbra@nod.at> In-Reply-To: <1572597584-6390-13-git-send-email-rppt@kernel.org> References: <1572597584-6390-1-git-send-email-rppt@kernel.org> <1572597584-6390-13-git-send-email-rppt@kernel.org> Subject: Re: [PATCH v2 12/13] um: add support for folded p4d page tables MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF68 (Linux)/8.8.12_GA_3809) Thread-Topic: add support for folded p4d page tables Thread-Index: S6h0nIi9frMaCZ4VaOjeTjwnLFOM0w== Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org ----- Ursprüngliche Mail ----- > Von: "Mike Rapoport" [...] > #define pte_page(x) pfn_to_page(pte_pfn(x)) > diff --git a/arch/um/kernel/mem.c b/arch/um/kernel/mem.c > index 417ff64..6fd17bc 100644 > --- a/arch/um/kernel/mem.c > +++ b/arch/um/kernel/mem.c > @@ -92,10 +92,26 @@ static void __init one_md_table_init(pud_t *pud) > #endif > } > > +static void __init one_pud_table_init(p4d_t *p4d) > +{ > +#if CONFIG_PGTABLE_LEVELS > 3 Isn't this dead code? For uml we have: config PGTABLE_LEVELS int default 3 if 3_LEVEL_PGTABLES default 2 Thanks, //richard