linux-parisc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Mikulas Patocka <mpatocka@redhat.com>,
	Helge Deller <deller@gmx.de>,
	John David Anglin <dave.anglin@bell.net>
Cc: linux-parisc@vger.kernel.org
Subject: Re: [PATCH] parisc: use per-pagetable spinlock
Date: Sat, 06 Apr 2019 12:49:04 -0700	[thread overview]
Message-ID: <1554580144.5053.4.camel@HansenPartnership.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1904061533530.21941@file01.intranet.prod.int.rdu2.redhat.com>

On Sat, 2019-04-06 at 15:36 -0400, Mikulas Patocka wrote:
> Parisc uses a global spinlock to protect pagetable updates in the TLB
> fault handlers. When multiple cores are taking TLB faults
> simultaneously, the cache line containing the spinlock becomes a
> bottleneck.

You can't do this.  As the comment in cache.c says: the lock is to
protect the merced bus, which runs between the CPUs on some systems. 
That means it must be a single, global lock.  Of course, on systems
without a merced bus, we don't need the lock at all, so runtime
patching might be usable to fix that case.

James


  reply	other threads:[~2019-04-06 19:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-06 19:36 [PATCH] parisc: use per-pagetable spinlock Mikulas Patocka
2019-04-06 19:49 ` James Bottomley [this message]
2019-04-06 20:13   ` Mikulas Patocka
2019-04-06 20:32     ` James Bottomley
2019-04-06 20:40       ` Mikulas Patocka
2019-04-06 21:28         ` James Bottomley
2019-04-07 17:07           ` Mikulas Patocka
2019-04-10 15:05         ` John David Anglin
2019-04-10 16:09           ` Mikulas Patocka
     [not found]             ` <e81cc4d8-0da9-454b-6102-c89bb5cdd0b0@bell.net>
2019-04-11 13:18               ` John David Anglin
2019-04-06 20:15   ` Helge Deller
2019-04-07  2:48     ` James Bottomley
2019-04-07 17:23       ` Mikulas Patocka
2019-04-07 17:42         ` James Bottomley
2019-04-10 19:10   ` John David Anglin
2019-04-10 19:27     ` John David Anglin
2019-04-13 16:23       ` Helge Deller
2019-04-13 17:57         ` John David Anglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1554580144.5053.4.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=dave.anglin@bell.net \
    --cc=deller@gmx.de \
    --cc=linux-parisc@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).