From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68595CA9ECF for ; Mon, 4 Nov 2019 08:49:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E15321929 for ; Mon, 4 Nov 2019 08:49:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="h92Y4u9I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728165AbfKDIts (ORCPT ); Mon, 4 Nov 2019 03:49:48 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:37305 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbfKDIts (ORCPT ); Mon, 4 Nov 2019 03:49:48 -0500 Received: by mail-wm1-f67.google.com with SMTP id q130so15070493wme.2 for ; Mon, 04 Nov 2019 00:49:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AZd8DxR702MwoAlKE7sREzCDnCS7TFuUgJFAdqqjsLA=; b=h92Y4u9I19V2o1s+5lGhO17NSFYSHZk9QgvM5mDhCb3p4Vr39mQBIAAeC5nqfpsi7E 4Bu32H/W8VKvnuNSVHaBWMXpaykRQBdpqblyb005vmpwKAd2pPajeArxEgBntM3nBLKj CddUtibvOMTxVJx2KNlPjR3XoBIJe+NH2U3j4K0JJelFf1HEtWdgk3iyAHOejVVD2gf+ RJwDT9t3Hb7iL4cAFs4mdD4rEQqzd1PD/0A6AYCrvWEvFCYF3aqv09lC/5EFGKCN59wI T1KGPDXOWiB478W6LZxF6RvwiHkYgYy1j3yOyQ1KqccT28HwFd28G/rbXCZe5nN7BE4U VQdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AZd8DxR702MwoAlKE7sREzCDnCS7TFuUgJFAdqqjsLA=; b=ot5FtPP35u5puvTbJ3oLufsc9Vt+g+EjT0Ol+Qu5y279H4OtSY1uEoNnp0Br36TdJM YRH4R2Hegx1gT0ShEqRcmQpXl+52tPLhzgKr/wpNHtxVzhqUGdS92UmyrcrucoXB4l1S d0IZm+6vIA5zXJiwtGzAV2YC265YQwX2yXH6jQsmz6uPxvfBISYQLBNSMUL5YUS9PwcN DdAGBeeRy88IpfWGj+93KjdaG8TcrC0e7B24TA6XFoedEIrymRn7KKbtdUYAumNNGxuv cwpaOFzEzH9h3JDLTOEsbDfTtuFozFfaU65LKzZ5ZnVTAM+GtDsIieyN7gLwgOwHIquj LH4Q== X-Gm-Message-State: APjAAAVOO5hpwBHvKdp1HIMDPVL9THGO3EX7DVtaHHBuhIoIpYJDp6K0 YdsNAz6EJkU8rSaAnIs7jc0jkA== X-Google-Smtp-Source: APXvYqzYY3HzDkh794xMS1oJwQdQFMlMRYGSpRhna8XwoC1msLOBd9EdnxKhwo914zrovZJbmWsmAw== X-Received: by 2002:a05:600c:2383:: with SMTP id m3mr18810088wma.166.1572857385472; Mon, 04 Nov 2019 00:49:45 -0800 (PST) Received: from [192.168.86.166] (83-86-89-107.cable.dynamic.v4.ziggo.nl. [83.86.89.107]) by smtp.gmail.com with ESMTPSA id o187sm15137370wmo.20.2019.11.04.00.49.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Nov 2019 00:49:44 -0800 (PST) Subject: Re: ALSA: pcm: use dma_can_mmap() to check if a device supports dma_mmap_* From: Greg Kroah-Hartman To: youling 257 , Takashi Iwai Cc: linux-xtensa@linux-xtensa.org, Michal Simek , Vladimir Murzin , linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Helge Deller , x86@kernel.org, Linux Kernel Mailing List , linux-m68k@lists.linux-m68k.org, Robin Murphy , linux-arm-kernel@lists.infradead.org, hch@lst.de References: <60ee349a-1fe7-46f0-5161-1dcfcb6fbee9@google.com> Message-ID: <19c3f0ca-9b21-0c5e-894d-976594f38a86@google.com> Date: Mon, 4 Nov 2019 09:49:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <60ee349a-1fe7-46f0-5161-1dcfcb6fbee9@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US-large Content-Transfer-Encoding: 7bit Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On 11/4/19 9:32 AM, Greg Kroah-Hartman wrote: > On 11/4/19 9:27 AM, youling 257 wrote: > > This driver > https://android.googlesource.com/kernel/common/+/refs/heads/android-mainline/drivers/usb/gadget/function/f_audio_source.c > > > > > The driver is broken and needs to be fixed. Please feel free to submit > patches to AOSP to do so as you can trigger this easily. Hm, maybe the driver isn't broken... snd_pcm_lib_preallocate_pages_for_all() is called with SNDRV_DMA_TYPE_DEV set, so that should be fine, and the only other buffer I can see allocate here is with a call to snd_pcm_lib_alloc_vmalloc_buffer() which _should_ be ok, right? I don't see any buffers coming off the stack here, unless the gadget controller is the one creating them? thanks, greg k-h