From: John David Anglin <dave.anglin@bell.net>
To: linux-parisc <linux-parisc@vger.kernel.org>
Cc: Helge Deller <deller@gmx.de>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH] parisc: Various spin lock optimizations
Date: Mon, 20 Jul 2020 09:18:47 -0400 [thread overview]
Message-ID: <1b7c4278-973a-7f1f-f187-8d340aa74ce0@bell.net> (raw)
In-Reply-To: <048514e6-5f68-acfa-dd1e-25d4b2d09897@bell.net>
On 2020-07-19 2:41 p.m., John David Anglin wrote:
> #define arch_spin_lock_flags arch_spin_lock_flags
> @@ -46,23 +44,16 @@ static inline void arch_spin_unlock(arch_spinlock_t *x)
> volatile unsigned int *a;
>
> a = __ldcw_align(x);
> -#ifdef CONFIG_SMP
> - (void) __ldcw(a);
> -#else
> - mb();
> -#endif
> + __ldcw_mb(a);
> *a = 1;
> }
I'm retesting using an ordered store for the release. So far, it's looking okay.
Dave
--
John David Anglin dave.anglin@bell.net
prev parent reply other threads:[~2020-07-20 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 18:41 [PATCH] parisc: Various spin lock optimizations John David Anglin
2020-07-20 13:18 ` John David Anglin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b7c4278-973a-7f1f-f187-8d340aa74ce0@bell.net \
--to=dave.anglin@bell.net \
--cc=James.Bottomley@HansenPartnership.com \
--cc=deller@gmx.de \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).