From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D62C5B57D for ; Mon, 8 Jul 2019 05:48:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 86EB320665 for ; Mon, 8 Jul 2019 05:48:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728741AbfGHFsH (ORCPT ); Mon, 8 Jul 2019 01:48:07 -0400 Received: from mx1.mailbox.org ([80.241.60.212]:41686 "EHLO mx1.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728654AbfGHFsG (ORCPT ); Mon, 8 Jul 2019 01:48:06 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id D5ED350844; Mon, 8 Jul 2019 07:47:59 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter05.heinlein-hosting.de (spamfilter05.heinlein-hosting.de [80.241.56.123]) (amavisd-new, port 10030) with ESMTP id 6HYUzmgqQjbZ; Mon, 8 Jul 2019 07:47:45 +0200 (CEST) Date: Mon, 8 Jul 2019 15:47:35 +1000 From: Aleksa Sarai To: Michael Ellerman Cc: Al Viro , Jeff Layton , "J. Bruce Fields" , Arnd Bergmann , David Howells , Shuah Khan , Shuah Khan , Eric Biederman , Andy Lutomirski , Andrew Morton , Alexei Starovoitov , Kees Cook , Jann Horn , Christian Brauner , Tycho Andersen , David Drysdale , Chanho Min , Oleg Nesterov , Aleksa Sarai , Linus Torvalds , containers@lists.linux-foundation.org, linux-alpha@vger.kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v9 10/10] selftests: add openat2(2) selftests Message-ID: <20190708054735.3fepxxtolqaqwmrp@yavin> References: <20190706145737.5299-1-cyphar@cyphar.com> <20190706145737.5299-11-cyphar@cyphar.com> <878st9iax4.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fv76k6im74ofqhz7" Content-Disposition: inline In-Reply-To: <878st9iax4.fsf@concordia.ellerman.id.au> Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org --fv76k6im74ofqhz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2019-07-08, Michael Ellerman wrote: > Aleksa Sarai writes: > > diff --git a/tools/testing/selftests/openat2/Makefile b/tools/testing/s= elftests/openat2/Makefile > > new file mode 100644 > > index 000000000000..8235a49928f6 > > --- /dev/null > > +++ b/tools/testing/selftests/openat2/Makefile > > @@ -0,0 +1,12 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > + > > +CFLAGS +=3D -Wall -O2 -g > > +TEST_GEN_PROGS :=3D linkmode_test resolve_test rename_attack_test > > + > > +include ../lib.mk > > + > > +$(OUTPUT)/linkmode_test: linkmode_test.c helpers.o > > +$(OUTPUT)/rename_attack_test: rename_attack_test.c helpers.o > > +$(OUTPUT)/resolve_test: resolve_test.c helpers.o >=20 > You don't need to tell make that foo depends on foo.c. >=20 > Also if you make the dependency be on helpers.c then you won't get an > intermediate helpers.o, and then you don't need to clean it. >=20 > So the above three lines could just be: >=20 > $(TEST_GEN_PROGS): helpers.c I had some trouble getting this to work (hence why I went with the version in the patch), but it looks like this works. I'll include it in the next set. > > +EXTRA_CLEAN =3D helpers.o $(wildcard /tmp/ksft-openat2-*) >=20 > If you follow my advice above you don't need helpers.o in there. >=20 > Deleting things from /tmp is also a bit fishy on shared machines, ie. it > will error if those files happen to be owned by another user. Good point. I'll drop that hunk in the next set. Thanks! --=20 Aleksa Sarai Senior Software Engineer (Containers) SUSE Linux GmbH --fv76k6im74ofqhz7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQSxZm6dtfE8gxLLfYqdlLljIbnQEgUCXSLY8wAKCRCdlLljIbnQ Enn2AQC9g0o7YHWuxFtQCLt+aHIE39RQMQDzB5QWrvZA8DdIUQEA69BwekXhnh8X m2czJJrJISBz5Nz1y3qJzwUUGBvxEgY= =RdsA -----END PGP SIGNATURE----- --fv76k6im74ofqhz7--