From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62036C7618B for ; Thu, 25 Jul 2019 08:28:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2496E22BEF for ; Thu, 25 Jul 2019 08:28:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389662AbfGYI2u (ORCPT ); Thu, 25 Jul 2019 04:28:50 -0400 Received: from mail-qt1-f171.google.com ([209.85.160.171]:35443 "EHLO mail-qt1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389623AbfGYI2u (ORCPT ); Thu, 25 Jul 2019 04:28:50 -0400 Received: by mail-qt1-f171.google.com with SMTP id d23so48291558qto.2 for ; Thu, 25 Jul 2019 01:28:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=W9gVDQuWc00uLJaqP5LZiohnBPPDA5P8er6pMpADl+8=; b=jdlYdPH0mM8w//MTWmokEB5EGd6hc5LfcBIctMHLsiQMfrUwQNs7nQE+6JRSYvg7C+ Lt0VljGiJuryIMSXcVK0jUjiCzTTTFhjMq17yUb0t8i/Qw3vkZpbjgD008ZcZzoBqjK5 qZyBO4uZn7PvL4xVmfoaiByvaOReE4a0QFmFelx9yaf5pBggZsJCxoIrmifgnFeA78Lp 5tidCMeVOeIJc/FcfDiBtk07dPp9ckdV713LNonVlQCBVhMzXkO4oFHHA6ka1mcEmhrY ezVtn7Q8IotsOTdkxWJhfGXt39T/4vVUd9wKITSSKTqBLsbBcBwTQ8QF4IDTF9genrmT oGpA== X-Gm-Message-State: APjAAAVe1fcFZocUBPKz3bM885k0exu6MxNljUy4K3yLy8M0ul3CjM1U LKDnQiBtlqijpOgSh9Edyvbc3w== X-Google-Smtp-Source: APXvYqypxxYh1SBYrdx7sBULiRodWoRyZYhZUU0NIqTYlxg9WD9pqSvNPlHTYL+xZ+kptrKYhL64aw== X-Received: by 2002:aed:3667:: with SMTP id e94mr55831866qtb.382.1564043329003; Thu, 25 Jul 2019 01:28:49 -0700 (PDT) Received: from redhat.com (bzq-79-181-91-42.red.bezeqint.net. [79.181.91.42]) by smtp.gmail.com with ESMTPSA id z21sm19762286qto.48.2019.07.25.01.28.41 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 25 Jul 2019 01:28:48 -0700 (PDT) Date: Thu, 25 Jul 2019 04:28:39 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: syzbot , aarcange@redhat.com, akpm@linux-foundation.org, christian@brauner.io, davem@davemloft.net, ebiederm@xmission.com, elena.reshetova@intel.com, guro@fb.com, hch@infradead.org, james.bottomley@hansenpartnership.com, jglisse@redhat.com, keescook@chromium.org, ldv@altlinux.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, luto@amacapital.net, mhocko@suse.com, mingo@kernel.org, namit@vmware.com, peterz@infradead.org, syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk, wad@chromium.org Subject: Re: WARNING in __mmdrop Message-ID: <20190725042651-mutt-send-email-mst@kernel.org> References: <20190723010019-mutt-send-email-mst@kernel.org> <20190723032024-mutt-send-email-mst@kernel.org> <1d14de4d-0133-1614-9f64-3ded381de04e@redhat.com> <20190723035725-mutt-send-email-mst@kernel.org> <3f4178f1-0d71-e032-0f1f-802428ceca59@redhat.com> <20190723051828-mutt-send-email-mst@kernel.org> <20190725012149-mutt-send-email-mst@kernel.org> <55e8930c-2695-365f-a07b-3ad169654d28@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55e8930c-2695-365f-a07b-3ad169654d28@redhat.com> Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Thu, Jul 25, 2019 at 03:43:41PM +0800, Jason Wang wrote: > > On 2019/7/25 下午1:52, Michael S. Tsirkin wrote: > > On Tue, Jul 23, 2019 at 09:31:35PM +0800, Jason Wang wrote: > > > On 2019/7/23 下午5:26, Michael S. Tsirkin wrote: > > > > On Tue, Jul 23, 2019 at 04:49:01PM +0800, Jason Wang wrote: > > > > > On 2019/7/23 下午4:10, Michael S. Tsirkin wrote: > > > > > > On Tue, Jul 23, 2019 at 03:53:06PM +0800, Jason Wang wrote: > > > > > > > On 2019/7/23 下午3:23, Michael S. Tsirkin wrote: > > > > > > > > > > Really let's just use kfree_rcu. It's way cleaner: fire and forget. > > > > > > > > > Looks not, you need rate limit the fire as you've figured out? > > > > > > > > See the discussion that followed. Basically no, it's good enough > > > > > > > > already and is only going to be better. > > > > > > > > > > > > > > > > > And in fact, > > > > > > > > > the synchronization is not even needed, does it help if I leave a comment to > > > > > > > > > explain? > > > > > > > > Let's try to figure it out in the mail first. I'm pretty sure the > > > > > > > > current logic is wrong. > > > > > > > Here is what the code what to achieve: > > > > > > > > > > > > > > - The map was protected by RCU > > > > > > > > > > > > > > - Writers are: MMU notifier invalidation callbacks, file operations (ioctls > > > > > > > etc), meta_prefetch (datapath) > > > > > > > > > > > > > > - Readers are: memory accessor > > > > > > > > > > > > > > Writer are synchronized through mmu_lock. RCU is used to synchronized > > > > > > > between writers and readers. > > > > > > > > > > > > > > The synchronize_rcu() in vhost_reset_vq_maps() was used to synchronized it > > > > > > > with readers (memory accessors) in the path of file operations. But in this > > > > > > > case, vq->mutex was already held, this means it has been serialized with > > > > > > > memory accessor. That's why I think it could be removed safely. > > > > > > > > > > > > > > Anything I miss here? > > > > > > > > > > > > > So invalidate callbacks need to reset the map, and they do > > > > > > not have vq mutex. How can they do this and free > > > > > > the map safely? They need synchronize_rcu or kfree_rcu right? > > > > > Invalidation callbacks need but file operations (e.g ioctl) not. > > > > > > > > > > > > > > > > And I worry somewhat that synchronize_rcu in an MMU notifier > > > > > > is a problem, MMU notifiers are supposed to be quick: > > > > > Looks not, since it can allow to be blocked and lots of driver depends on > > > > > this. (E.g mmu_notifier_range_blockable()). > > > > Right, they can block. So why don't we take a VQ mutex and be > > > > done with it then? No RCU tricks. > > > > > > This is how I want to go with RFC and V1. But I end up with deadlock between > > > vq locks and some MM internal locks. So I decide to use RCU which is 100% > > > under the control of vhost. > > > > > > Thanks > > And I guess the deadlock is because GUP is taking mmu locks which are > > taken on mmu notifier path, right? > > > Yes, but it's not the only lock. I don't remember the details, but I can > confirm I meet issues with one or two other locks. > > > > How about we add a seqlock and take > > that in invalidate callbacks? We can then drop the VQ lock before GUP, > > and take it again immediately after. > > > > something like > > if (!vq_meta_mapped(vq)) { > > vq_meta_setup(&uaddrs); > > mutex_unlock(vq->mutex) > > vq_meta_map(&uaddrs); > > > The problem is the vq address could be changed at this time. > > > > mutex_lock(vq->mutex) > > > > /* recheck both sock->private_data and seqlock count. */ > > if changed - bail out > > } > > > > And also requires that VQ uaddrs is defined like this: > > - writers must have both vq mutex and dev mutex > > - readers must have either vq mutex or dev mutex > > > > > > That's a big change though. For now, how about switching to a per-vq SRCU? > > That is only a little bit more expensive than RCU, and we > > can use synchronize_srcu_expedited. > > > > Consider we switch to use kfree_rcu(), what's the advantage of per-vq SRCU? > > Thanks I thought we established that notifiers must wait for all readers to finish before they mark page dirty, to prevent page from becoming dirty after address has been invalidated. Right?