From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9B4CC3A59E for ; Wed, 21 Aug 2019 11:36:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C44E22CF7 for ; Wed, 21 Aug 2019 11:36:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=duncanthrax.net header.i=@duncanthrax.net header.b="DTHJPH74" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726353AbfHULgB (ORCPT ); Wed, 21 Aug 2019 07:36:01 -0400 Received: from smtp.duncanthrax.net ([89.31.1.170]:40874 "EHLO smtp.duncanthrax.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726349AbfHULgA (ORCPT ); Wed, 21 Aug 2019 07:36:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=duncanthrax.net; s=dkim; h=In-Reply-To:Content-Type:MIME-Version:References :Message-ID:Subject:Cc:To:From:Date; bh=X5zvVv9Ieb3EMIG3hCtybIcz0q5uCNQZMNTgaJo6mF0=; b=DTHJPH74Sg5X+iehiEG8Atemrx 96iyXlm6ilfsmZZ/wM6zn5kdVX4pv1mfY4uIK1BZ2393mIkkrDcEjZNyLsS9/P9R2PbeZ9WhRjEdV nOkED+o36BiRXnFIoBhetGMOL70Ht9URPJkXvC/paanc4JqRTsUQXfjyeup4za6dWdZo=; Received: from [2001:470:70c5:1111:5054:ff:febf:83e1] (helo=stackframe.org) by smtp.eurescom.eu with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1i0Ou8-0006r9-Mg; Wed, 21 Aug 2019 13:35:52 +0200 Date: Wed, 21 Aug 2019 13:35:51 +0200 From: Sven Schnelle To: Jisheng Zhang Cc: "James E.J. Bottomley" , Helge Deller , "linux-parisc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] kprobes/parisc: remove arch_kprobe_on_func_entry() Message-ID: <20190821113551.GB14547@stackframe.org> References: <20190821174533.5736ca90@xhacker.debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190821174533.5736ca90@xhacker.debian> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Wed, Aug 21, 2019 at 09:56:40AM +0000, Jisheng Zhang wrote: > The common kprobes provides a weak implementation of > arch_kprobe_on_func_entry(). The parisc version is the same as the > common version, so remove it. > > Signed-off-by: Jisheng Zhang Acked-by: Sven Schnelle > --- > arch/parisc/kernel/kprobes.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/parisc/kernel/kprobes.c b/arch/parisc/kernel/kprobes.c > index 5d7f2692ac5a..77ec51818916 100644 > --- a/arch/parisc/kernel/kprobes.c > +++ b/arch/parisc/kernel/kprobes.c > @@ -281,10 +281,6 @@ int __kprobes arch_trampoline_kprobe(struct kprobe *p) > { > return p->addr == trampoline_p.addr; > } > -bool arch_kprobe_on_func_entry(unsigned long offset) > -{ > - return !offset; > -} > > int __init arch_init_kprobes(void) > { > -- > 2.23.0.rc1 >