From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E9ACC43331 for ; Mon, 11 Nov 2019 17:23:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 542B521655 for ; Mon, 11 Nov 2019 17:23:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="X/LzmRNI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726964AbfKKRXG (ORCPT ); Mon, 11 Nov 2019 12:23:06 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:36386 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726978AbfKKRXG (ORCPT ); Mon, 11 Nov 2019 12:23:06 -0500 Received: by mail-pf1-f196.google.com with SMTP id v19so11125819pfm.3 for ; Mon, 11 Nov 2019 09:23:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yAajaC8HCWYzucX9F7lpdzKRK9O4DP5SS69z8MpuzC8=; b=X/LzmRNI+PAfGCx7iOXc7jITwTbPHloj6W9cE45iZE62pceyrxHDPEHiavfj9tEFm4 3ssTDoHViE0PIaYRTxiES+N/vQ0V6XBCRSxJLkNHA5EmXVvGMUKq6TH0JVEbtbv7eJIs og7HVJoMSxXZSuRdEpfAiyzG2OcgsCx2ssepg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yAajaC8HCWYzucX9F7lpdzKRK9O4DP5SS69z8MpuzC8=; b=Bu22DZfCsFpn2eDH1+BEgJg49ImHx7ocv7o5cNWJgZh/2gCD5UKschB+Aq8XlFeVtb 41OfPWrf2pabzdBRkVh12WopmWn9ro2UdT4D/ZKcB09BtSUQjvT7OAIhN6Y5abWRrUW9 4IRQyTrrnZJEwoSmxTCiNE+OOHI+B7CoHMmZQmbkZ2yrs1m92nxgeeRXHb8zQlWw5Dzh 4rbh7dlaKYPWpbLrkpFHrVcRVYL/7ZarYLfPO49HBrOKNZx5uHA56znpW1MBtJhztnH0 z7Jrd8wpzdshzWeb9RgiNsfoHWhvPBFiQ6Fp2VRF/mWMye4kZCel65qkOLHaH3LxHFot qYVg== X-Gm-Message-State: APjAAAWZrke5mh1+4MZbCOBMhuOtp5VFpT78RTmZzUtZc7UaeRiCqub4 6RmLNkvXEwRq6rmCbKMRIuYaTw== X-Google-Smtp-Source: APXvYqyYRSzpwUPLuEiDxWQRl2mmu7HM3K81RSwKffyFA1Sp64Zbaq8qhH85VUnK4TNVxH3gOyo1gQ== X-Received: by 2002:a17:90a:5d0e:: with SMTP id s14mr85161pji.55.1573492985697; Mon, 11 Nov 2019 09:23:05 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o15sm22800000pgn.49.2019.11.11.09.23.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 09:23:04 -0800 (PST) Date: Mon, 11 Nov 2019 09:23:03 -0800 From: Kees Cook To: Geert Uytterhoeven Cc: Borislav Petkov , Rick Edgecombe , Dave Hansen , Andy Lutomirski , Arnd Bergmann , Michael Ellerman , Heiko Carstens , Will Deacon , Linux-Arch , Linux ARM , linuxppc-dev , alpha , "linux-ia64@vger.kernel.org" , linux-s390 , linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Michal Simek , Parisc List , linux-xtensa@linux-xtensa.org, the arch/x86 maintainers , Linux Kernel Mailing List Subject: Re: [PATCH v2 11/29] vmlinux.lds.h: Replace RODATA with RO_DATA Message-ID: <201911110922.17A2112B0@keescook> References: <20191011000609.29728-1-keescook@chromium.org> <20191011000609.29728-12-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Mon, Nov 11, 2019 at 05:58:06PM +0100, Geert Uytterhoeven wrote: > Hi Kees, > > On Fri, Oct 11, 2019 at 2:07 AM Kees Cook wrote: > > There's no reason to keep the RODATA macro: replace the callers with > > the expected RO_DATA macro. > > > > Signed-off-by: Kees Cook > > --- > > arch/alpha/kernel/vmlinux.lds.S | 2 +- > > arch/ia64/kernel/vmlinux.lds.S | 2 +- > > arch/microblaze/kernel/vmlinux.lds.S | 2 +- > > arch/mips/kernel/vmlinux.lds.S | 2 +- > > arch/um/include/asm/common.lds.S | 2 +- > > arch/xtensa/kernel/vmlinux.lds.S | 2 +- > > include/asm-generic/vmlinux.lds.h | 4 +--- > > 7 files changed, 7 insertions(+), 9 deletions(-) > > Somehow you missed: > > arch/m68k/kernel/vmlinux-std.lds: RODATA > arch/m68k/kernel/vmlinux-sun3.lds: RODATA Argh. I've sent a patch; sorry and thanks for catching this. For my own cross-build testing, which defconfig targets will hit these two linker scripts? -Kees > > Leading to build failures in next-20191111: > > /opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux-ld:./arch/m68k/kernel/vmlinux.lds:29: > syntax error > make[1]: *** [/kisskb/src/Makefile:1075: vmlinux] Error 1 > > Reported-by: noreply@ellerman.id.au > http://kisskb.ellerman.id.au/kisskb/buildresult/14022846/ > > Gr{oetje,eeting}s, > > Geert > > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Kees Cook