Linux-parisc archive on
 help / color / Atom feed
From: Mike Rapoport <>
To: "James E.J. Bottomley" <>
Cc: Helge Deller <>,,,
	Mike Rapoport <>,
	Mike Rapoport <>, Meelis Roos <>,
	Jeroen Roovers <>,
	Mikulas Patocka <>
Subject: [PATCH] parisc: fix map_pages() to actually populate upper directory
Date: Wed,  8 Jan 2020 14:58:52 +0200
Message-ID: <> (raw)

From: Mike Rapoport <>

The commit d96885e277b5 ("parisc: use pgtable-nopXd instead of
4level-fixup") converted PA-RISC to use folded page tables, but it missed
the conversion of pgd_populate() to pud_populate() in maps_pages()
function. This caused the upper page table directory to remain empty and
the system would crash as a result.

Using pud_populate() that actually populates the page table instead of
dummy pgd_populate() fixes the issue.

Fixes: d96885e277b5 ("parisc: use pgtable-nopXd instead of 4level-fixup")
Reported-by: Meelis Roos <>
Reported-by: Jeroen Roovers <>
Reported-by: Mikulas Patocka <>
Tested-by: Jeroen Roovers <>
Tested-by: Mikulas Patocka <>
Signed-off-by: Mike Rapoport <>
 arch/parisc/mm/init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/parisc/mm/init.c b/arch/parisc/mm/init.c
index ddca8287d43b..354cf060b67f 100644
--- a/arch/parisc/mm/init.c
+++ b/arch/parisc/mm/init.c
@@ -401,7 +401,7 @@ static void __init map_pages(unsigned long start_vaddr,
 			pmd = (pmd_t *) __pa(pmd);
-		pgd_populate(NULL, pg_dir, __va(pmd));
+		pud_populate(NULL, (pud_t *)pg_dir, __va(pmd));

             reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08 12:58 Mike Rapoport [this message]
2020-01-09  6:50 ` Helge Deller
2020-01-09  8:45   ` Mike Rapoport
2020-01-11 15:53     ` Helge Deller

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-parisc archive on

Archives are clonable:
	git clone --mirror linux-parisc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-parisc linux-parisc/ \
	public-inbox-index linux-parisc

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone