* [PATCH] parisc: Improve error return codes when setting rtc time
@ 2020-10-17 18:13 Helge Deller
0 siblings, 0 replies; only message in thread
From: Helge Deller @ 2020-10-17 18:13 UTC (permalink / raw)
To: linux-parisc, James Bottomley, John David Anglin
The HP 730 machine returned strange errors when I tried setting the rtc
time. Add some debug code to improve the possibility to trace errors
and document that hppa probably has as Y2k38 problem.
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/arch/parisc/kernel/time.c b/arch/parisc/kernel/time.c
index 04508158815c..13d94f0f94a0 100644
--- a/arch/parisc/kernel/time.c
+++ b/arch/parisc/kernel/time.c
@@ -180,9 +180,16 @@ static int rtc_generic_get_time(struct device *dev, struct rtc_time *tm)
static int rtc_generic_set_time(struct device *dev, struct rtc_time *tm)
{
time64_t secs = rtc_tm_to_time64(tm);
-
- if (pdc_tod_set(secs, 0) < 0)
+ int ret;
+
+ /* hppa has Y2K38 problem: pdc_tod_set() takes an u32 value! */
+ ret = pdc_tod_set(secs, 0);
+ if (ret != 0) {
+ pr_warn("pdc_tod_set(%lld) returned error %d\n", secs, ret);
+ if (ret == PDC_INVALID_ARG)
+ return -EINVAL;
return -EOPNOTSUPP;
+ }
return 0;
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-10-17 18:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-17 18:13 [PATCH] parisc: Improve error return codes when setting rtc time Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).