From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B28ABCA9EB6 for ; Wed, 23 Oct 2019 10:25:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82A1B20663 for ; Wed, 23 Oct 2019 10:25:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391063AbfJWKZH (ORCPT ); Wed, 23 Oct 2019 06:25:07 -0400 Received: from mail.sf-mail.de ([116.202.16.50]:33033 "EHLO mail.sf-mail.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390977AbfJWKZH (ORCPT ); Wed, 23 Oct 2019 06:25:07 -0400 Received: (qmail 27735 invoked from network); 23 Oct 2019 10:20:38 -0000 Received: from mail.sf-mail.de ([2a01:4f8:1c17:6fae:616d:6c69:616d:6c69]:43938 HELO webmail.sf-mail.de) (auth=eike@sf-mail.de) by mail.sf-mail.de (Qsmtpd 0.36dev) with (DHE-RSA-AES256-GCM-SHA384 encrypted) ESMTPSA for ; Wed, 23 Oct 2019 12:20:38 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 23 Oct 2019 12:20:29 +0200 From: Rolf Eike Beer To: Mike Rapoport Cc: linux-mm@kvack.org, Andrew Morton , Anton Ivanov , Arnd Bergmann , "David S. Miller" , Geert Uytterhoeven , Greentime Hu , Greg Ungerer , Helge Deller , "James E.J. Bottomley" , Jeff Dike , "Kirill A. Shutemov" , Linus Torvalds , Mark Salter , Matt Turner , Michal Simek , Richard Weinberger , Russell King , Sam Creasey , Vincent Chen , Vineet Gupta , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-parisc@vger.kernel.org, linux-um@lists.infradead.org, sparclinux@vger.kernel.org, Mike Rapoport , linux-parisc-owner@vger.kernel.org Subject: Re: [PATCH 08/12] parisc: use pgtable-nopXd instead of 4level-fixup In-Reply-To: <1571822941-29776-9-git-send-email-rppt@kernel.org> References: <1571822941-29776-1-git-send-email-rppt@kernel.org> <1571822941-29776-9-git-send-email-rppt@kernel.org> Message-ID: <70339cfc547e2fa0f6b98fefb1b1a9fa@sf-tec.de> X-Sender: eike-kernel@sf-tec.de User-Agent: Roundcube Webmail/1.3.8 Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org > diff --git a/arch/parisc/include/asm/page.h > b/arch/parisc/include/asm/page.h > index 93caf17..1d339ee 100644 > --- a/arch/parisc/include/asm/page.h > +++ b/arch/parisc/include/asm/page.h > @@ -42,48 +42,54 @@ typedef struct { unsigned long pte; } pte_t; /* > either 32 or 64bit */ > > /* NOTE: even on 64 bits, these entries are __u32 because we allocate > * the pmd and pgd in ZONE_DMA (i.e. under 4GB) */ > -typedef struct { __u32 pmd; } pmd_t; > typedef struct { __u32 pgd; } pgd_t; > typedef struct { unsigned long pgprot; } pgprot_t; > > -#define pte_val(x) ((x).pte) > -/* These do not work lvalues, so make sure we don't use them as such. > */ > +#if CONFIG_PGTABLE_LEVELS == 3 > +typedef struct { __u32 pmd; } pmd_t; > +#define __pmd(x) ((pmd_t) { (x) } ) > +/* pXd_val() do not work lvalues, so make sure we don't use them as > such. */ For me it sounds like there is something missing, maybe an "as" before lvalues? And it was "These", so plural, and now it is singular, so do -> does? Eike